Skip to content

test(instrumentation-aws-sdk): update client in bedrock-runtime tests to use NodeHttpHandler instead of the new default NodeHttp2Handler #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trentm merged 3 commits into from
May 2, 2025
Merged

test(instrumentation-aws-sdk): update client in bedrock-runtime tests to use NodeHttpHandler instead of the new default NodeHttp2Handler #2810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3342bd
test(instrumentation-aws-sdk): update client in bedrock-runtime tests…
jj22ee May 1, 2025
c5d728c
add comment
jj22ee May 1, 2025
ca5bf0b
Merge branch 'main' into bedrock-test-use-http
trentm May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion plugins/node/opentelemetry-instrumentation-aws-sdk/test/bedrock-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import {
import { AwsCredentialIdentity } from '@aws-sdk/types';
import * as path from 'path';
import { Definition, back as nockBack } from 'nock';
import { NodeHttpHandler } from '@smithy/node-http-handler';

import { ReadableSpan } from '@opentelemetry/sdk-trace-base';
import {
Expand Down Expand Up @@ -88,7 +89,12 @@ describe('Bedrock', () => {
};
}

const client = new BedrockRuntimeClient({ region, credentials });
// Use NodeHttpHandler to use HTTP instead of HTTP2 because nock does not support HTTP2
const client = new BedrockRuntimeClient({
region,
credentials,
requestHandler: new NodeHttpHandler(),
});

let nockDone: () => void;
beforeEach(async function () {
Expand Down