fix(test-utils): extend assertCloudResource with cloud.platform #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kasper Borg Nissen <[email protected]>
github-actions
bot
requested review from
blumamir,
dyladan,
legendecas and
pichlermarc
Member
|
@aabmass made a comment here which also I believe applies to this PR: #2818 (comment) We're going to discuss that next week in the SIG meeting. |
Member
|
Closing this PR as it seems to work towards testing #2818, which was also closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I'm currently trying to expand the gcp resource detector (#2818) and for that I will also be adding support for detecting
cloud.platform. Currently the helper does not support this.Short description of the changes
Semantic conventions for
cloudalso includescloud.platform. However, currently the assertion helper forclouddoes not supportcloud.platform. This PR adds support forcloud.platformin theassertCloudResourcetest-util.