-
Notifications
You must be signed in to change notification settings - Fork 619
chore: set isolatedModules compilation option
#2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set isolatedModules compilation option
#2839
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 89.62% 89.66% +0.03%
==========================================
Files 185 184 -1
Lines 9014 9010 -4
Branches 1849 1848 -1
==========================================
Hits 8079 8079
+ Misses 935 931 -4
🚀 New features to boost your workflow:
|
trentm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Which problem is this PR solving?
This is a follow up PR on open-telemetry/opentelemetry-js#5697
IMHO the compilation options should be in sync if possible. Also TypeScript docs recommend to enable it to give better support for bundlers. It may benefit instrumentations targeting browser runtime.
Short description of the changes
isolatedModulesto true intsconfig.base.jsonexport type