Skip to content

Conversation

@cincauhangus
Copy link
Contributor

@cincauhangus cincauhangus commented Jun 3, 2025

Short description of the changes

KoaLayerType is an enum. It was erroneously exported as a type causing errors on in Koa setups. This breaks the configuration setup for ignoring certain Koa Layers when publishing spans.

This was working in @opentelemetry/instrumentation-koa v0.46.0, now broken in v0.50.0.

Typescript linter error:

image

KoaLayerType is an enum. It was erroneously exported as a type causing errors on in Koa setups
@cincauhangus cincauhangus requested a review from a team as a code owner June 3, 2025 09:33
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cincauhangus / name: Aaron Ho (6551696, de50920)
  • ✅ login: david-luna / name: David Luna (321243a)

@github-actions github-actions bot added pkg:instrumentation-koa pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jun 3, 2025
@cincauhangus cincauhangus changed the title Export KoaLayerType enum correctly fix: Export KoaLayerType enum correctly Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (a81ef5f) to head (321243a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2873   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files         187      187           
  Lines        9059     9059           
  Branches     1858     1858           
=======================================
  Hits         8129     8129           
  Misses        930      930           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cincauhangus cincauhangus changed the title fix: Export KoaLayerType enum correctly fix: export KoaLayerType enum correctly Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@cincauhangus
Copy link
Contributor Author

cincauhangus commented Jun 4, 2025

Hi @david-luna, need some assistance to get this PR approved/merged as breaks functionality from your recent commit 60612f2 (#2839)

@david-luna
Copy link
Contributor

@cincauhangus thanks for the fix. Please run npm run lint:fix in the koa instrumentation folder and push the changes. Then I'll be able to approve and merge :)

@david-luna david-luna added the has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions label Jun 4, 2025
@cincauhangus
Copy link
Contributor Author

@david-luna done and ready for review/merge

@david-luna david-luna enabled auto-merge (squash) June 5, 2025 10:55
@david-luna david-luna disabled auto-merge June 5, 2025 11:13
@david-luna david-luna merged commit 11a94b0 into open-telemetry:main Jun 5, 2025
23 checks passed
@dyladan dyladan mentioned this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-koa pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants