fix: http.response_content_length does not get populated when ignoreNetworkEvents is set to true

[howardyoo]

fix: http.response_content_length does not get populated when ignoreNetworkEvents is set to true

This PR fixes the issue #2879 where when the instrumentation is configured with ignoreNetworkEvents set as true, the two attributes: http.response_content_length and http.response_content_length_compressed are also getting omitted, due to a logic flaw that did not call the addSpanNetworkEvents when the ignoreNetworkEvents were set to true.

Regardless of whether ignoreNetworkEvents are set to true or false, the response content length should be returned to the resource fetch span, as it is not a part of network span events.

Fixes: #2879

[dyladan]

This is just applying a fix accepted elsewhere. 🚀

[dyladan]

Please add tests

[JamieDanielson]

Thanks for fixing this!
As Dan mentioned, just needs a test update. Also please run npm run lint to see the change needed to fix the failing status check. In fact you should be able to do npm run lint:fix and it will fix it for you.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (f8ffeb0) to head (a87ab47).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   89.68%   89.73%   +0.04%     
==========================================
  Files         187      187              
  Lines        9059     9059              
  Branches     1858     1858              
==========================================
+ Hits         8125     8129       +4     
+ Misses        934      930       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[howardyoo]

Thanks for fixing this! As Dan mentioned, just needs a test update. Also please run npm run lint to see the change needed to fix the failing status check. In fact you should be able to do npm run lint:fix and it will fix it for you.

Thanks, yes, ran lint:fix and fixed the formatting issue.

[howardyoo]

Please add tests

Sure, added the test for this. Thanks.