chore: Add docker compose and test services scripts #2886
Conversation
github-actions
bot
added
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg-status:unmaintained
david-luna
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
+ Coverage 89.77% 89.82% +0.04%
==========================================
Files 187 187
Lines 9147 9147
Branches 1884 1884
==========================================
+ Hits 8212 8216 +4
+ Misses 935 931 -4 🚀 New features to boost your workflow:
|
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| - name: Set MySQL variables |
There was a problem hiding this comment.
note for reviewer: this is required only for testing @opentelemetry/instrumentation-mysql and can be executed as a query using the client. Hence is removed from there and added in plugins/node/opentelemetry-instrumentation-mysql/test/mysql.test.ts
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
| - name: Set MySQL variables |
There was a problem hiding this comment.
note for reviewer: same here
| const shouldTest = process.env.RUN_MYSQL_TESTS; | ||
|
|
||
| before(async function () { | ||
| const connection = createConnection({ |
There was a problem hiding this comment.
note for reviewer: enabling here the general_log setting instead of doing it in the workflows
| user: process.env.POSTGRES_USER || 'postgres', | ||
| password: process.env.POSTGRES_PASSWORD || 'postgres', | ||
| database: process.env.POSTGRES_DB || 'postgres', | ||
| database: process.env.POSTGRES_DB || 'otel_pg_database', |
There was a problem hiding this comment.
note for reviewer: align the value with the one in workflow services
raphael-theriault-swi
left a comment
raphael-theriault-swi
left a comment
There was a problem hiding this comment.
Love this, small nit tho.
trentm
left a comment
trentm
left a comment
There was a problem hiding this comment.
Should do the cross-env thing. Else I just have nits. Thanks for picking this up!
| If you only want to test a sigle package (e.g. the `instrumentation-mongodb`) you can `cd` into it and run the tests after you started the services. | ||
|
|
||
| ```sh | ||
| npm run test-services:start # starts services in Docker |
There was a problem hiding this comment.
This could optionally be npm run test-services:start mongodb but probably don't need to bother mentioning this. Easier to keep it simple.
There was a problem hiding this comment.
I'm planning to do a follow up PR to add scripts for each package which will use this feature. I'll remember to update this description.
plugins/node/opentelemetry-instrumentation-mysql/test/index.test.ts
Outdated
Show resolved
Hide resolved
pichlermarc
added
has:sponsor
…st.ts Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
thank you for working on this! 🙂
Co-authored-by: Marc Pichler <[email protected]>
5 participants
Which problem is this PR solving?
Short description of the changes