From 65d309926b72b77b523ff97c7ea6db39da8562d9 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan <50715937+svetlanabrennan@users.noreply.github.com> Date: Thu, 26 Jun 2025 11:58:13 -0500 Subject: [PATCH 1/4] remove addlogprocessor --- .../test/baggage-log-record-processor.test.ts | 25 ++++++++----------- packages/winston-transport/README.md | 9 +++---- .../test/openTelemetryTransport.test.ts | 7 +++--- .../test/bunyan.test.ts | 6 +++-- .../test/pino.test.ts | 6 +++-- .../README.md | 16 ++++++------ .../test/winston.test.ts | 7 +++--- 7 files changed, 35 insertions(+), 41 deletions(-) diff --git a/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts b/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts index 3fcfba16e4..65d8e88fab 100644 --- a/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts +++ b/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts @@ -34,12 +34,11 @@ describe('BaggageLogRecordProcessor with all keys', () => { }); it('onEmit adds current Baggage entries to a log record as attributes', () => { - const loggerProvider = new LoggerProvider(); const exporter = new InMemoryLogRecordExporter(); - loggerProvider.addLogRecordProcessor(baggageProcessor); - loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(exporter) - ); + const loggerProvider = new LoggerProvider({ + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + }); + const logger = loggerProvider.getLogger('my-logger'); const ctx = propagation.setBaggage(ROOT_CONTEXT, bag); @@ -75,12 +74,10 @@ describe('BaggageLogRecordProcessor startWith key filter', () => { }); it('onEmit adds current filtered by startWith Baggage entries to a log record as attributes', () => { - const loggerProvider = new LoggerProvider(); const exporter = new InMemoryLogRecordExporter(); - loggerProvider.addLogRecordProcessor(baggageProcessor); - loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(exporter) - ); + const loggerProvider = new LoggerProvider({ + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + }); const logger = loggerProvider.getLogger('my-logger'); const ctx = propagation.setBaggage(ROOT_CONTEXT, bag); @@ -114,12 +111,10 @@ describe('BaggageLogRecordProcessor with regex key filter', () => { }); it('onEmit adds current filtered by regex Baggage entries to a log record as attributes', () => { - const loggerProvider = new LoggerProvider(); const exporter = new InMemoryLogRecordExporter(); - loggerProvider.addLogRecordProcessor(baggageProcessor); - loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(exporter) - ); + const loggerProvider = new LoggerProvider({ + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + }); const logger = loggerProvider.getLogger('my-logger'); const ctx = propagation.setBaggage(ROOT_CONTEXT, bag); diff --git a/packages/winston-transport/README.md b/packages/winston-transport/README.md index 8da57f9634..0d21abcd33 100644 --- a/packages/winston-transport/README.md +++ b/packages/winston-transport/README.md @@ -33,11 +33,10 @@ const winston = require('winston'); // To start a logger, you first need to initialize the Logger provider. -const loggerProvider = new LoggerProvider(); -// Add a processor to export log record -loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(new ConsoleLogRecordExporter()) -); +// And add a processor to export log record. +const loggerProvider = new LoggerProvider({ + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] +}); logsAPI.logs.setGlobalLoggerProvider(loggerProvider); const logger = winston.createLogger({ diff --git a/packages/winston-transport/test/openTelemetryTransport.test.ts b/packages/winston-transport/test/openTelemetryTransport.test.ts index 17516e5e51..8440ab38a6 100644 --- a/packages/winston-transport/test/openTelemetryTransport.test.ts +++ b/packages/winston-transport/test/openTelemetryTransport.test.ts @@ -24,11 +24,10 @@ import * as assert from 'assert'; import * as sinon from 'sinon'; import { OpenTelemetryTransportV3 } from '../src'; -const loggerProvider = new LoggerProvider(); const memoryLogExporter = new InMemoryLogRecordExporter(); -loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(memoryLogExporter) -); +const loggerProvider = new LoggerProvider({ + processors: [new SimpleLogRecordProcessor(memoryLogExporter)], +}); logs.setGlobalLoggerProvider(loggerProvider); const kMessage = 'log-message'; diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts index 168d329aea..088d5bb633 100644 --- a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts +++ b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts @@ -49,9 +49,11 @@ const tracer = tracerProvider.getTracer('default'); const resource = resourceFromAttributes({ [ATTR_SERVICE_NAME]: 'test-instrumentation-bunyan', }); -const loggerProvider = new LoggerProvider({ resource }); const memExporter = new InMemoryLogRecordExporter(); -loggerProvider.addLogRecordProcessor(new SimpleLogRecordProcessor(memExporter)); +const loggerProvider = new LoggerProvider({ + resource, + processors: [new SimpleLogRecordProcessor(memExporter)] +}); logs.setGlobalLoggerProvider(loggerProvider); const instrumentation = new BunyanInstrumentation(); diff --git a/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts b/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts index 9e520965a2..3ec56775e0 100644 --- a/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts +++ b/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts @@ -55,9 +55,11 @@ const tracer = tracerProvider.getTracer('default'); const resource = resourceFromAttributes({ [ATTR_SERVICE_NAME]: 'test-instrumentation-pino', }); -const loggerProvider = new LoggerProvider({ resource }); const memExporter = new InMemoryLogRecordExporter(); -loggerProvider.addLogRecordProcessor(new SimpleLogRecordProcessor(memExporter)); +const loggerProvider = new LoggerProvider({ + resource, + processors: [new SimpleLogRecordProcessor(memExporter)], +}); logs.setGlobalLoggerProvider(loggerProvider); const instrumentation = new PinoInstrumentation(); diff --git a/plugins/node/opentelemetry-instrumentation-winston/README.md b/plugins/node/opentelemetry-instrumentation-winston/README.md index 341226f283..359841ffdf 100644 --- a/plugins/node/opentelemetry-instrumentation-winston/README.md +++ b/plugins/node/opentelemetry-instrumentation-winston/README.md @@ -38,11 +38,10 @@ const tracerProvider = new NodeTracerProvider(); tracerProvider.register(); // To start a logger, you first need to initialize the Logger provider. -const loggerProvider = new LoggerProvider(); -// Add a processor to export log record -loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(new ConsoleLogRecordExporter()) -); +// Add a processor to export log record. +const loggerProvider = new LoggerProvider({ + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] +}); logsAPI.logs.setGlobalLoggerProvider(loggerProvider); registerInstrumentations({ @@ -122,11 +121,10 @@ const winston = require('winston'); // To start a logger, you first need to initialize the Logger provider. -const loggerProvider = new LoggerProvider(); // Add a processor to export log record -loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(new ConsoleLogRecordExporter()) -); +const loggerProvider = new LoggerProvider({ + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] +}); logsAPI.logs.setGlobalLoggerProvider(loggerProvider); const logger = winston.createLogger({ diff --git a/plugins/node/opentelemetry-instrumentation-winston/test/winston.test.ts b/plugins/node/opentelemetry-instrumentation-winston/test/winston.test.ts index b3f2d08347..d9e848b845 100644 --- a/plugins/node/opentelemetry-instrumentation-winston/test/winston.test.ts +++ b/plugins/node/opentelemetry-instrumentation-winston/test/winston.test.ts @@ -41,11 +41,10 @@ const provider = new NodeTracerProvider({ const tracer = provider.getTracer('default'); context.setGlobalContextManager(new AsyncLocalStorageContextManager()); -const loggerProvider = new LoggerProvider(); const memoryLogExporter = new InMemoryLogRecordExporter(); -loggerProvider.addLogRecordProcessor( - new SimpleLogRecordProcessor(memoryLogExporter) -); +const loggerProvider = new LoggerProvider({ + processors: [new SimpleLogRecordProcessor(memoryLogExporter)], +}); logs.setGlobalLoggerProvider(loggerProvider); const kMessage = 'log-message'; From 65e13507086cc219523262208480373edf0995b9 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan <50715937+svetlanabrennan@users.noreply.github.com> Date: Thu, 26 Jun 2025 15:18:54 -0500 Subject: [PATCH 2/4] fix lint --- .../node/opentelemetry-instrumentation-pino/test/pino.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts b/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts index 3ec56775e0..6e485734c7 100644 --- a/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts +++ b/plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts @@ -56,7 +56,7 @@ const resource = resourceFromAttributes({ [ATTR_SERVICE_NAME]: 'test-instrumentation-pino', }); const memExporter = new InMemoryLogRecordExporter(); -const loggerProvider = new LoggerProvider({ +const loggerProvider = new LoggerProvider({ resource, processors: [new SimpleLogRecordProcessor(memExporter)], }); From 4e877b74bb86113dd6a6f2326a1693786e84e497 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan <50715937+svetlanabrennan@users.noreply.github.com> Date: Thu, 26 Jun 2025 15:28:57 -0500 Subject: [PATCH 3/4] fix lint --- .../opentelemetry-instrumentation-bunyan/test/bunyan.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts index 088d5bb633..7e2932e9be 100644 --- a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts +++ b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts @@ -50,7 +50,7 @@ const resource = resourceFromAttributes({ [ATTR_SERVICE_NAME]: 'test-instrumentation-bunyan', }); const memExporter = new InMemoryLogRecordExporter(); -const loggerProvider = new LoggerProvider({ +const loggerProvider = new LoggerProvider({ resource, processors: [new SimpleLogRecordProcessor(memExporter)] }); From 71481b20cd70cd66fc18412ba479d07e364dadc8 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan <50715937+svetlanabrennan@users.noreply.github.com> Date: Thu, 26 Jun 2025 15:36:54 -0500 Subject: [PATCH 4/4] fix lint --- .../test/baggage-log-record-processor.test.ts | 6 +++--- packages/winston-transport/README.md | 2 +- .../test/bunyan.test.ts | 2 +- .../node/opentelemetry-instrumentation-winston/README.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts b/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts index 65d8e88fab..9c2887bed1 100644 --- a/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts +++ b/packages/baggage-log-record-processor/test/baggage-log-record-processor.test.ts @@ -36,7 +36,7 @@ describe('BaggageLogRecordProcessor with all keys', () => { it('onEmit adds current Baggage entries to a log record as attributes', () => { const exporter = new InMemoryLogRecordExporter(); const loggerProvider = new LoggerProvider({ - processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)], }); const logger = loggerProvider.getLogger('my-logger'); @@ -76,7 +76,7 @@ describe('BaggageLogRecordProcessor startWith key filter', () => { it('onEmit adds current filtered by startWith Baggage entries to a log record as attributes', () => { const exporter = new InMemoryLogRecordExporter(); const loggerProvider = new LoggerProvider({ - processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)], }); const logger = loggerProvider.getLogger('my-logger'); const ctx = propagation.setBaggage(ROOT_CONTEXT, bag); @@ -113,7 +113,7 @@ describe('BaggageLogRecordProcessor with regex key filter', () => { it('onEmit adds current filtered by regex Baggage entries to a log record as attributes', () => { const exporter = new InMemoryLogRecordExporter(); const loggerProvider = new LoggerProvider({ - processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)] + processors: [baggageProcessor, new SimpleLogRecordProcessor(exporter)], }); const logger = loggerProvider.getLogger('my-logger'); const ctx = propagation.setBaggage(ROOT_CONTEXT, bag); diff --git a/packages/winston-transport/README.md b/packages/winston-transport/README.md index 0d21abcd33..64b0f40c50 100644 --- a/packages/winston-transport/README.md +++ b/packages/winston-transport/README.md @@ -35,7 +35,7 @@ const winston = require('winston'); // To start a logger, you first need to initialize the Logger provider. // And add a processor to export log record. const loggerProvider = new LoggerProvider({ - processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())], }); logsAPI.logs.setGlobalLoggerProvider(loggerProvider); diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts index 7e2932e9be..e79f7c850b 100644 --- a/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts +++ b/plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts @@ -52,7 +52,7 @@ const resource = resourceFromAttributes({ const memExporter = new InMemoryLogRecordExporter(); const loggerProvider = new LoggerProvider({ resource, - processors: [new SimpleLogRecordProcessor(memExporter)] + processors: [new SimpleLogRecordProcessor(memExporter)], }); logs.setGlobalLoggerProvider(loggerProvider); diff --git a/plugins/node/opentelemetry-instrumentation-winston/README.md b/plugins/node/opentelemetry-instrumentation-winston/README.md index 359841ffdf..f67ff3182e 100644 --- a/plugins/node/opentelemetry-instrumentation-winston/README.md +++ b/plugins/node/opentelemetry-instrumentation-winston/README.md @@ -40,7 +40,7 @@ tracerProvider.register(); // To start a logger, you first need to initialize the Logger provider. // Add a processor to export log record. const loggerProvider = new LoggerProvider({ - processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())], }); logsAPI.logs.setGlobalLoggerProvider(loggerProvider); @@ -123,7 +123,7 @@ const winston = require('winston'); // To start a logger, you first need to initialize the Logger provider. // Add a processor to export log record const loggerProvider = new LoggerProvider({ - processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())] + processors: [new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())], }); logsAPI.logs.setGlobalLoggerProvider(loggerProvider);