From a28636ce03991bb6b2937899e25c73070fc015d0 Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Thu, 31 Jul 2025 16:39:31 -0700 Subject: [PATCH 1/2] chore(instrumentation-express, instrumentation-fastify): drop unused devDep @types/express --- package-lock.json | 4 ---- packages/instrumentation-express/package.json | 1 - packages/instrumentation-fastify/package.json | 1 - 3 files changed, 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index af13903f44..26d6ef5f29 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32600,7 +32600,6 @@ "@opentelemetry/contrib-test-utils": "^0.49.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4", @@ -32663,7 +32662,6 @@ "@opentelemetry/instrumentation-http": "^0.203.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.15.3", "@types/semver": "7.5.8", @@ -42709,7 +42707,6 @@ "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", "@opentelemetry/semantic-conventions": "^1.27.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4", @@ -42757,7 +42754,6 @@ "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", "@opentelemetry/semantic-conventions": "^1.27.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.15.3", "@types/semver": "7.5.8", diff --git a/packages/instrumentation-express/package.json b/packages/instrumentation-express/package.json index a87a98d046..42c30f882c 100644 --- a/packages/instrumentation-express/package.json +++ b/packages/instrumentation-express/package.json @@ -53,7 +53,6 @@ "@opentelemetry/contrib-test-utils": "^0.49.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4", diff --git a/packages/instrumentation-fastify/package.json b/packages/instrumentation-fastify/package.json index 86a5150fc5..15f7cba178 100644 --- a/packages/instrumentation-fastify/package.json +++ b/packages/instrumentation-fastify/package.json @@ -54,7 +54,6 @@ "@opentelemetry/instrumentation-http": "^0.203.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", - "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.15.3", "@types/semver": "7.5.8", From 3c909d7678b6eb6c134c6205ecf35c02d920d4d0 Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Mon, 11 Aug 2025 08:50:30 -0700 Subject: [PATCH 2/2] revert the change to instr-express per feedback from David (correct identifying that @types/express *is* used in the test files) --- package-lock.json | 2 ++ packages/instrumentation-express/package.json | 1 + 2 files changed, 3 insertions(+) diff --git a/package-lock.json b/package-lock.json index 26d6ef5f29..4f3decf858 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32600,6 +32600,7 @@ "@opentelemetry/contrib-test-utils": "^0.49.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", + "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4", @@ -42707,6 +42708,7 @@ "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", "@opentelemetry/semantic-conventions": "^1.27.0", + "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4", diff --git a/packages/instrumentation-express/package.json b/packages/instrumentation-express/package.json index 42c30f882c..a87a98d046 100644 --- a/packages/instrumentation-express/package.json +++ b/packages/instrumentation-express/package.json @@ -53,6 +53,7 @@ "@opentelemetry/contrib-test-utils": "^0.49.0", "@opentelemetry/sdk-trace-base": "^2.0.0", "@opentelemetry/sdk-trace-node": "^2.0.0", + "@types/express": "4.17.23", "@types/mocha": "10.0.10", "@types/node": "18.18.14", "@types/sinon": "17.0.4",