Skip to content

Conversation

@overbalance
Copy link
Contributor

@overbalance overbalance commented Aug 28, 2025

Which problem is this PR solving?

No problem, just cleaning up.

Short description of the changes

Updated the name of the root package to reflect the repo.

  • opentelemetry-contrib --> opentelemetry-js-contrib
  • same thing in ./scripts
  • Removed non-existent exports at root

@overbalance overbalance requested a review from a team as a code owner August 28, 2025 03:26
@overbalance overbalance force-pushed the overbalance/housekeeping branch from feb8865 to f24ab7c Compare August 28, 2025 03:27
@overbalance overbalance changed the title chore(package): rename repo and scripts package chore(package): rename repo and scripts packages Aug 28, 2025
@overbalance overbalance force-pushed the overbalance/housekeeping branch from f24ab7c to 64967cd Compare August 28, 2025 03:30
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (ca26f63) to head (a7a6c15).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         193      193           
  Lines        9698     9698           
  Branches     2011     2011           
=======================================
  Hits         8685     8685           
  Misses       1013     1013           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc enabled auto-merge (squash) August 28, 2025 08:44
@maryliag
Copy link
Contributor

hi @overbalance, you will need to solve the conflicts, so we can get this merged :)

auto-merge was automatically disabled August 28, 2025 15:06

Head branch was pushed to by a user without write access

@overbalance overbalance force-pushed the overbalance/housekeeping branch from 64967cd to 1e3025c Compare August 28, 2025 15:06
@overbalance
Copy link
Contributor Author

overbalance commented Aug 28, 2025

@maryliag thanks! I rebased instead of merging from main so auto-merge was disabled. Can you merge for me please?

@overbalance overbalance requested a review from maryliag August 28, 2025 15:13
@pichlermarc
Copy link
Member

@overbalance looks like you're using an organization fork and that has maintainer edits disabled by default.
You cannot turn it on via the GitHub UI, but it can be done via the API.

When that is on, maintainers/approvers usually merge main and resolve trivial conflicts before merging a PR.

I am also constraint to using an organization fork by my company, so I usually use this alias to allow maintainer edit on all my PRs in a repo:

alias allow-edit-prs="gh pr list --author @me --json number --template '{{range .}}{{.number}}{{\"\n\"}}{{end}}' | while read PR_NUMBER; do gh api /repos/{owner}/{repo}/pulls/\$PR_NUMBER -F maintainer_can_modify=true; done;"

@overbalance overbalance force-pushed the overbalance/housekeeping branch from 1e3025c to a7a6c15 Compare August 29, 2025 16:22
@pichlermarc

This comment was marked as resolved.

@pichlermarc pichlermarc merged commit 3a1dc57 into open-telemetry:main Sep 1, 2025
35 of 37 checks passed
@overbalance overbalance deleted the overbalance/housekeeping branch September 1, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants