Skip to content

Conversation

@david-luna
Copy link
Contributor

Which problem is this PR solving?

The new release of [email protected] changed the internal model of, at least, the insert command response. this does not break the instrumentation but the responseHook tests were relying on that to make certain assertions. As a result running test-all-versions failed when selecting such version of the package.

Short description of the changes

  • update dependency to v6.19.0
  • change test code to consider both models in the response object

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (41d272d) to head (041d1ff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3003   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         193      193           
  Lines        9698     9698           
  Branches     2011     2011           
=======================================
  Hits         8685     8685           
  Misses       1013     1013           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc changed the title tests(instr-mongodb): fix tests mongdb tests for 6.19.0 test(instr-mongodb): fix tests mongdb tests for 6.19.0 Aug 29, 2025
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this 🙌

@pichlermarc pichlermarc merged commit c51fef1 into open-telemetry:main Aug 29, 2025
21 of 22 checks passed
@david-luna david-luna deleted the monogo-tav-failing branch August 29, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants