Skip to content

Conversation

@aabmass
Copy link
Member

@aabmass aabmass commented Aug 29, 2025

Which problem is this PR solving?

Isolate GcpDetectorIntegration.test.ts (using runTestFixture()) so that it doesn't leak it's changes into other test cases

Short description of the changes

This was breaking some tests I am working on for #2933 (comment). It also just overall simplifies the test since we don't need to play with require.cache.

I verified this test fails properly without suppressTracing() in the detector.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (35c7754) to head (ec59f53).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3005   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         193      193           
  Lines        9698     9698           
  Branches     2011     2011           
=======================================
  Hits         8685     8685           
  Misses       1013     1013           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aabmass aabmass marked this pull request as ready for review August 29, 2025 22:33
@aabmass aabmass requested a review from a team as a code owner August 29, 2025 22:33
@aabmass aabmass removed the request for review from punya August 29, 2025 22:33
@aabmass aabmass force-pushed the isolate-gcp-integration branch from f3ae4f3 to b53e310 Compare September 2, 2025 20:09
@github-actions github-actions bot requested a review from punya September 2, 2025 20:09
@aabmass aabmass force-pushed the isolate-gcp-integration branch from b53e310 to ec59f53 Compare September 2, 2025 20:13
@aabmass aabmass removed the request for review from punya September 2, 2025 20:13
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@pichlermarc pichlermarc merged commit 0b6a515 into open-telemetry:main Sep 3, 2025
25 checks passed
@aabmass aabmass deleted the isolate-gcp-integration branch September 3, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants