Skip to content

Commit 2260dd6

Browse files
authored
chore(env): update default value for span's attributes/links/events count #1675 (#2098)
1 parent 5dbe53a commit 2260dd6

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

packages/opentelemetry-core/src/utils/environment.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ export const DEFAULT_ENVIRONMENT: Required<ENVIRONMENT> = {
9999
OTEL_PROPAGATORS: ['tracecontext', 'baggage'],
100100
OTEL_RESOURCE_ATTRIBUTES: '',
101101
OTEL_SAMPLING_PROBABILITY: 1,
102-
OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: 1000,
103-
OTEL_SPAN_EVENT_COUNT_LIMIT: 1000,
104-
OTEL_SPAN_LINK_COUNT_LIMIT: 1000,
102+
OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT: 128,
103+
OTEL_SPAN_EVENT_COUNT_LIMIT: 128,
104+
OTEL_SPAN_LINK_COUNT_LIMIT: 128,
105105
};
106106

107107
/**

packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ describe('BasicTracerProvider', () => {
7171
it('should construct an instance with default trace params', () => {
7272
const tracer = new BasicTracerProvider({}).getTracer('default');
7373
assert.deepStrictEqual(tracer.getActiveTraceParams(), {
74-
numberOfAttributesPerSpan: 1000,
75-
numberOfEventsPerSpan: 1000,
76-
numberOfLinksPerSpan: 1000,
74+
numberOfAttributesPerSpan: 128,
75+
numberOfEventsPerSpan: 128,
76+
numberOfLinksPerSpan: 128,
7777
});
7878
});
7979

@@ -85,8 +85,8 @@ describe('BasicTracerProvider', () => {
8585
}).getTracer('default');
8686
assert.deepStrictEqual(tracer.getActiveTraceParams(), {
8787
numberOfAttributesPerSpan: 100,
88-
numberOfEventsPerSpan: 1000,
89-
numberOfLinksPerSpan: 1000,
88+
numberOfEventsPerSpan: 128,
89+
numberOfLinksPerSpan: 128,
9090
});
9191
});
9292

@@ -97,9 +97,9 @@ describe('BasicTracerProvider', () => {
9797
},
9898
}).getTracer('default');
9999
assert.deepStrictEqual(tracer.getActiveTraceParams(), {
100-
numberOfAttributesPerSpan: 1000,
100+
numberOfAttributesPerSpan: 128,
101101
numberOfEventsPerSpan: 300,
102-
numberOfLinksPerSpan: 1000,
102+
numberOfLinksPerSpan: 128,
103103
});
104104
});
105105

@@ -110,8 +110,8 @@ describe('BasicTracerProvider', () => {
110110
},
111111
}).getTracer('default');
112112
assert.deepStrictEqual(tracer.getActiveTraceParams(), {
113-
numberOfAttributesPerSpan: 1000,
114-
numberOfEventsPerSpan: 1000,
113+
numberOfAttributesPerSpan: 128,
114+
numberOfEventsPerSpan: 128,
115115
numberOfLinksPerSpan: 10,
116116
});
117117
});

0 commit comments

Comments
 (0)