Skip to content

Commit 33935e7

Browse files
authored
fix: remove usage of serviceName property in tests for otel collector (#2491)
1 parent 6a78db1 commit 33935e7

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ describe('OTLPMetricExporter - node with json over http', () => {
7272
// Need to stub/spy on the underlying logger as the "diag" instance is global
7373
const spyLoggerWarn = sinon.stub(diag, 'warn');
7474
collectorExporter = new OTLPMetricExporter({
75-
serviceName: 'basic-service',
7675
url: address,
7776
metadata,
7877
} as any);

packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ describe('OTLPTraceExporter - node with json over http', () => {
5858
// Need to stub/spy on the underlying logger as the "diag" instance is global
5959
const spyLoggerWarn = sinon.stub(diag, 'warn');
6060
collectorExporter = new OTLPTraceExporter({
61-
serviceName: 'basic-service',
6261
metadata,
6362
url: address,
6463
} as any);

0 commit comments

Comments
 (0)