Skip to content

Commit 3bc3452

Browse files
weyerttapico-weyertdyladanvmarchaud
authored
feat: updated spec to v1.5.0 and renamed resource class (#2345)
Co-authored-by: Weyert de Boer <[email protected]> Co-authored-by: Daniel Dyla <[email protected]> Co-authored-by: Valentin Marchaud <[email protected]>
1 parent 884d20a commit 3bc3452

File tree

42 files changed

+244
-208
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+244
-208
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ To request automatic tracing support for a module not on this list, please [file
226226

227227
## Upgrade guidelines
228228

229+
### 0.23.x to x
230+
231+
- `ResourceAttributes` renamed to `SemanticResourceAttributes` in the `@opentelemetry/semantic-conventions` package
232+
229233
### 0.20.x to x
230234

231235
### 0.19.x to 0.20.0

examples/basic-tracer-node/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
const opentelemetry = require('@opentelemetry/api');
44
const { Resource } = require('@opentelemetry/resources');
5-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
5+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
66
const { BasicTracerProvider, ConsoleSpanExporter, SimpleSpanProcessor } = require('@opentelemetry/tracing');
77
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
88

99
const provider = new BasicTracerProvider({
1010
resource: new Resource({
11-
[ResourceAttributes.SERVICE_NAME]: 'basic-service',
11+
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-service',
1212
}),
1313
});
1414

examples/collector-exporter-node/metrics.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const { CollectorMetricExporter } = require('@opentelemetry/exporter-collector')
66
// const { CollectorMetricExporter } = require('@opentelemetry/exporter-collector-proto');
77
const { MeterProvider } = require('@opentelemetry/metrics');
88
const { Resource } = require('@opentelemetry/resources');
9-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
9+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
1010

1111
// Optional and only needed to see the internal diagnostic logging (during development)
1212
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
@@ -19,7 +19,7 @@ const meter = new MeterProvider({
1919
exporter: metricExporter,
2020
interval: 1000,
2121
resource: new Resource({
22-
[ResourceAttributes.SERVICE_NAME]: 'basic-metric-service',
22+
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-metric-service',
2323
}),
2424
}).getMeter('example-exporter-collector');
2525

examples/collector-exporter-node/tracing.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { BasicTracerProvider, ConsoleSpanExporter, SimpleSpanProcessor } = require('@opentelemetry/tracing');
55
const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88
// const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector-grpc');
99
// const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector-proto');
1010

@@ -21,7 +21,7 @@ const exporter = new CollectorTraceExporter({
2121

2222
const provider = new BasicTracerProvider({
2323
resource: new Resource({
24-
[ResourceAttributes.SERVICE_NAME]: 'basic-service',
24+
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-service',
2525
}),
2626
});
2727
provider.addSpanProcessor(new SimpleSpanProcessor(exporter));

examples/grpc-js/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || '';
1515
module.exports = (serviceName) => {
1616
const provider = new NodeTracerProvider({
1717
resource: new Resource({
18-
[ResourceAttributes.SERVICE_NAME]: serviceName,
18+
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
1919
}),
2020
});
2121

examples/grpc/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || '';
1515
module.exports = (serviceName) => {
1616
const provider = new NodeTracerProvider({
1717
resource: new Resource({
18-
[ResourceAttributes.SERVICE_NAME]: serviceName,
18+
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
1919
}),
2020
});
2121

examples/http/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || '';
1515
module.exports = (serviceName) => {
1616
const provider = new NodeTracerProvider({
1717
resource: new Resource({
18-
[ResourceAttributes.SERVICE_NAME]: serviceName,
18+
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
1919
}),
2020
});
2121

examples/https/tracer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
44
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
55
const { NodeTracerProvider } = require('@opentelemetry/node');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
99
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
1010
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
@@ -17,7 +17,7 @@ module.exports = (serviceName) => {
1717
let exporter;
1818
const provider = new NodeTracerProvider({
1919
resource: new Resource({
20-
[ResourceAttributes.SERVICE_NAME]: serviceName,
20+
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
2121
}),
2222
});
2323

examples/opentracing-shim/shim.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
3+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
44
const { Resource } = require('@opentelemetry/resources');
55
const { NodeTracerProvider } = require('@opentelemetry/node');
66
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
@@ -10,7 +10,7 @@ const { TracerShim } = require('@opentelemetry/shim-opentracing');
1010

1111
function shim(serviceName) {
1212
const provider = new NodeTracerProvider({
13-
resource: new Resource({ [ResourceAttributes.SERVICE_NAME]: serviceName }),
13+
resource: new Resource({ [SemanticResourceAttributes.SERVICE_NAME]: serviceName }),
1414
});
1515

1616
provider.addSpanProcessor(new SimpleSpanProcessor(getExporter(serviceName)));

examples/tracer-web/examples/metrics/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const { DiagConsoleLogger, DiagLogLevel, diag } = require('@opentelemetry/api');
44
const { CollectorMetricExporter } = require('@opentelemetry/exporter-collector');
55
const { MeterProvider } = require('@opentelemetry/metrics');
66
const { Resource } = require('@opentelemetry/resources');
7-
const { ResourceAttributes } = require('@opentelemetry/semantic-conventions');
7+
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
88

99
// Optional and only needed to see the internal diagnostic logging (during development)
1010
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.DEBUG);
@@ -26,7 +26,7 @@ function startMetrics() {
2626
exporter: metricExporter,
2727
interval: 1000,
2828
resource: new Resource({
29-
[ResourceAttributes.SERVICE_NAME]: 'basic-metric-service',
29+
[SemanticResourceAttributes.SERVICE_NAME]: 'basic-metric-service',
3030
}),
3131
}).getMeter('example-exporter-collector');
3232

0 commit comments

Comments
 (0)