refactor: move ExportResult to @opentelemetry/sdk-base (#409)

Author: mayurkale22

packages/opentelemetry-exporter-jaeger/package.json

@@ -51,6 +51,7 @@
   },
   "dependencies": {
     "@opentelemetry/core": "^0.1.0",
+    "@opentelemetry/sdk-base": "^0.1.0",
     "@opentelemetry/tracer-basic": "^0.1.0",
     "@opentelemetry/types": "^0.1.0",
     "jaeger-client": "^3.15.0"

packages/opentelemetry-exporter-jaeger/src/jaeger.ts

@@ -14,11 +14,8 @@
  * limitations under the License.
  */
 
-import {
-  SpanExporter,
-  ReadableSpan,
-  ExportResult,
-} from '@opentelemetry/tracer-basic';
+import { SpanExporter, ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ExportResult } from '@opentelemetry/sdk-base';
 import * as jaegerTypes from './types';
 import { NoopLogger } from '@opentelemetry/core';
 import * as types from '@opentelemetry/types';

packages/opentelemetry-exporter-jaeger/test/jaeger.test.ts

@@ -19,7 +19,8 @@ import { JaegerExporter } from '../src';
 import { NoopLogger } from '@opentelemetry/core';
 import * as types from '@opentelemetry/types';
 import { ThriftProcess } from '../src/types';
-import { ExportResult, ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ExportResult } from '@opentelemetry/sdk-base';
 
 describe('JaegerExporter', () => {
   describe('constructor', () => {

packages/opentelemetry-exporter-zipkin/package.json

@@ -53,6 +53,7 @@
   },
   "dependencies": {
     "@opentelemetry/core": "^0.1.0",
+    "@opentelemetry/sdk-base": "^0.1.0",
     "@opentelemetry/tracer-basic": "^0.1.0",
     "@opentelemetry/types": "^0.1.0"
   }

packages/opentelemetry-exporter-zipkin/src/zipkin.ts

@@ -19,12 +19,8 @@ import * as http from 'http';
 import * as https from 'https';
 import * as url from 'url';
 import { NoopLogger } from '@opentelemetry/core';
-import {
-  SpanExporter,
-  ReadableSpan,
-  ExportResult,
-} from '@opentelemetry/tracer-basic';
-
+import { SpanExporter, ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ExportResult } from '@opentelemetry/sdk-base';
 import * as zipkinTypes from './types';
 import {
   toZipkinSpan,

packages/opentelemetry-exporter-zipkin/test/zipkin.test.ts

@@ -16,7 +16,8 @@
 
 import * as assert from 'assert';
 import * as nock from 'nock';
-import { ExportResult, ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ReadableSpan } from '@opentelemetry/tracer-basic';
+import { ExportResult } from '@opentelemetry/sdk-base';
 import { NoopLogger, hrTimeToMicroseconds } from '@opentelemetry/core';
 import * as types from '@opentelemetry/types';
 import { ZipkinExporter } from '../src';

packages/opentelemetry-metrics/src/export/types.ts

@@ -23,7 +23,7 @@
  */
 
 import { HrTime } from '@opentelemetry/types';
-import { Resource } from '@opentelemetry/sdk-base';
+import { Resource, ExportResult } from '@opentelemetry/sdk-base';
 
 export interface ReadableMetric {
   /**
@@ -348,12 +348,3 @@ export interface MetricExporter {
     resultCallback: (result: ExportResult) => void
   ): void;
 }
-
-/**
- * @TODO: Wait on https://github.com/open-telemetry/opentelemetry-js/issues/309
- */
-export enum ExportResult {
-  SUCCESS,
-  FAILED_NOT_RETRYABLE,
-  FAILED_RETRYABLE,
-}

packages/opentelemetry-tracer-basic/src/export/ExportResult.ts renamed to packages/opentelemetry-sdk-base/src/ExportResult.ts

@@ -15,3 +15,4 @@
  */
 
 export * from './resources/Resource';
+export * from './ExportResult';

packages/opentelemetry-sdk-base/src/index.ts

@@ -67,6 +67,7 @@
   "dependencies": {
     "@opentelemetry/core": "^0.1.0",
     "@opentelemetry/scope-base": "^0.1.0",
+    "@opentelemetry/sdk-base": "^0.1.0",
     "@opentelemetry/types": "^0.1.0"
   }
 }