refactor(exporter-zipkin): update semconv usage to ATTR_ exports (#5673)

Author: trentm

packages/opentelemetry-exporter-zipkin/src/zipkin.ts

@@ -28,7 +28,7 @@ import {
   defaultStatusCodeTagName,
   defaultStatusErrorTagName,
 } from './transform';
-import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
+import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
 import { prepareGetHeaders } from './utils';
 
 /**
@@ -74,7 +74,7 @@ export class ZipkinExporter implements SpanExporter {
   ): void {
     const serviceName = String(
       this._serviceName ||
-        spans[0].resource.attributes[SEMRESATTRS_SERVICE_NAME] ||
+        spans[0].resource.attributes[ATTR_SERVICE_NAME] ||
         this.DEFAULT_SERVICE_NAME
     );
 
@@ -147,8 +147,8 @@ export class ZipkinExporter implements SpanExporter {
       toZipkinSpan(
         span,
         String(
-          span.attributes[SEMRESATTRS_SERVICE_NAME] ||
-            span.resource.attributes[SEMRESATTRS_SERVICE_NAME] ||
+          span.attributes[ATTR_SERVICE_NAME] ||
+            span.resource.attributes[ATTR_SERVICE_NAME] ||
             serviceName
         ),
         this._statusCodeTagName,

packages/opentelemetry-exporter-zipkin/test/common/transform.test.ts

@@ -24,7 +24,7 @@ import {
 import { Resource } from '@opentelemetry/resources';
 import { ReadableSpan } from '@opentelemetry/sdk-trace-base';
 import * as assert from 'assert';
-import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
+import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
 import {
   defaultStatusCodeTagName,
   defaultStatusErrorTagName,
@@ -37,7 +37,7 @@ import { VERSION } from '../../src/version';
 
 const resource = {
   attributes: {
-    [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+    [ATTR_SERVICE_NAME]: 'zipkin-test',
     cost: '112.12',
     service: 'ui',
     version: '1',
@@ -128,7 +128,7 @@ describe('transform', () => {
         tags: {
           key1: 'value1',
           key2: 'value2',
-          [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+          [ATTR_SERVICE_NAME]: 'zipkin-test',
           cost: '112.12',
           service: 'ui',
           version: '1',
@@ -163,7 +163,7 @@ describe('transform', () => {
           name: span.name,
           parentId: undefined,
           tags: {
-            [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+            [ATTR_SERVICE_NAME]: 'zipkin-test',
             cost: '112.12',
             service: 'ui',
             version: '1',
@@ -209,7 +209,7 @@ describe('transform', () => {
           name: span.name,
           parentId: span.parentSpanContext?.spanId,
           tags: {
-            [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+            [ATTR_SERVICE_NAME]: 'zipkin-test',
             cost: '112.12',
             service: 'ui',
             version: '1',
@@ -241,7 +241,7 @@ describe('transform', () => {
       assert.deepStrictEqual(tags, {
         key1: 'value1',
         key2: 'value2',
-        [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+        [ATTR_SERVICE_NAME]: 'zipkin-test',
         'telemetry.sdk.language': 'nodejs',
         'telemetry.sdk.name': 'opentelemetry',
         'telemetry.sdk.version': VERSION,
@@ -267,7 +267,7 @@ describe('transform', () => {
       assert.deepStrictEqual(tags, {
         key1: 'value1',
         key2: 'value2',
-        [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+        [ATTR_SERVICE_NAME]: 'zipkin-test',
         'telemetry.sdk.language': 'nodejs',
         'telemetry.sdk.name': 'opentelemetry',
         'telemetry.sdk.version': VERSION,
@@ -294,7 +294,7 @@ describe('transform', () => {
         key1: 'value1',
         key2: 'value2',
         [defaultStatusCodeTagName]: 'ERROR',
-        [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+        [ATTR_SERVICE_NAME]: 'zipkin-test',
         'telemetry.sdk.language': 'nodejs',
         'telemetry.sdk.name': 'opentelemetry',
         'telemetry.sdk.version': VERSION,
@@ -322,7 +322,7 @@ describe('transform', () => {
         key2: 'value2',
         [defaultStatusCodeTagName]: 'ERROR',
         [defaultStatusErrorTagName]: 'my-message',
-        [SEMRESATTRS_SERVICE_NAME]: 'zipkin-test',
+        [ATTR_SERVICE_NAME]: 'zipkin-test',
         'telemetry.sdk.language': 'nodejs',
         'telemetry.sdk.name': 'opentelemetry',
         'telemetry.sdk.version': VERSION,

packages/opentelemetry-exporter-zipkin/test/node/zipkin.test.ts

@@ -30,7 +30,7 @@ import {
 import { ZipkinExporter } from '../../src';
 import * as zipkinTypes from '../../src/types';
 import { TraceFlags } from '@opentelemetry/api';
-import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
+import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
 
 const MICROS_PER_SECS = 1e6;
 
@@ -396,7 +396,7 @@ describe('Zipkin Exporter - node', () => {
         },
       ],
       resource: resourceFromAttributes({
-        [SEMRESATTRS_SERVICE_NAME]: resource_service_name,
+        [ATTR_SERVICE_NAME]: resource_service_name,
       }),
       instrumentationScope: { name: 'default', version: '0.0.1' },
       droppedAttributesCount: 0,
@@ -422,7 +422,7 @@ describe('Zipkin Exporter - node', () => {
       links: [],
       events: [],
       resource: resourceFromAttributes({
-        [SEMRESATTRS_SERVICE_NAME]: resource_service_name_prime,
+        [ATTR_SERVICE_NAME]: resource_service_name_prime,
       }),
       instrumentationScope: { name: 'default', version: '0.0.1' },
       droppedAttributesCount: 0,
@@ -485,7 +485,7 @@ describe('Zipkin Exporter - node', () => {
       attributes: {
         key1: 'value1',
         key2: 'value2',
-        [SEMRESATTRS_SERVICE_NAME]: span_service_name,
+        [ATTR_SERVICE_NAME]: span_service_name,
       },
       links: [],
       events: [
@@ -517,7 +517,7 @@ describe('Zipkin Exporter - node', () => {
         code: api.SpanStatusCode.OK,
       },
       attributes: {
-        [SEMRESATTRS_SERVICE_NAME]: span_service_name_prime,
+        [ATTR_SERVICE_NAME]: span_service_name_prime,
       },
       links: [],
       events: [],