Skip to content

Commit ca7b7d9

Browse files
authored
Update Getting started Guide (#862)
1 parent 253fa50 commit ca7b7d9

File tree

4 files changed

+48
-32
lines changed

4 files changed

+48
-32
lines changed

getting-started/README.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -303,17 +303,20 @@ Next, modify your `monitoring.js` file to look like this:
303303
const { MeterProvider } = require('@opentelemetry/metrics');
304304
const { PrometheusExporter } = require('@opentelemetry/exporter-prometheus');
305305
306-
const meter = new MeterProvider().getMeter('your-meter-name');
307-
308-
meter.addExporter(
309-
new PrometheusExporter(
310-
{ startServer: true },
311-
() => {
312-
console.log("prometheus scrape endpoint: http://localhost:9464/metrics");
313-
}
314-
)
306+
const exporter = new PrometheusExporter(
307+
{
308+
startServer: true,
309+
},
310+
() => {
311+
console.log('prometheus scrape endpoint: http://localhost:9464/metrics');
312+
},
315313
);
316314
315+
const meter = new MeterProvider({
316+
exporter,
317+
interval: 1000,
318+
}).getMeter('your-meter-name');
319+
317320
const requestCount = meter.createCounter("requests", {
318321
monotonic: true,
319322
labelKeys: ["route"],

getting-started/monitored-example/monitoring.js

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,20 @@
33
const { MeterProvider } = require('@opentelemetry/metrics');
44
const { PrometheusExporter } = require('@opentelemetry/exporter-prometheus');
55

6-
const meter = new MeterProvider().getMeter('example-monitored');
7-
8-
meter.addExporter(
9-
new PrometheusExporter(
10-
{
11-
startServer: true
12-
},
13-
() => {
14-
console.log("prometheus scrape endpoint: http://localhost:9464/metrics");
15-
}
16-
)
6+
const exporter = new PrometheusExporter(
7+
{
8+
startServer: true,
9+
},
10+
() => {
11+
console.log('prometheus scrape endpoint: http://localhost:9464/metrics');
12+
},
1713
);
1814

15+
const meter = new MeterProvider({
16+
exporter,
17+
interval: 1000,
18+
}).getMeter('example-monitored');
19+
1920
const requestCount = meter.createCounter("requests", {
2021
monotonic: true,
2122
labelKeys: ["route"],

getting-started/ts-example/README.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,14 +301,20 @@ import { MeterProvider } from '@opentelemetry/metrics';
301301
import { Metric, BoundCounter } from '@opentelemetry/api';
302302
import { PrometheusExporter } from '@opentelemetry/exporter-prometheus';
303303
304-
const meter = new MeterProvider().getMeter('your-meter-name');
305-
306-
meter.addExporter(
307-
new PrometheusExporter({ startServer: true }, () => {
308-
console.log("prometheus scrape endpoint: http://localhost:9464/metrics");
309-
})
304+
const exporter = new PrometheusExporter(
305+
{
306+
startServer: true,
307+
},
308+
() => {
309+
console.log('prometheus scrape endpoint: http://localhost:9464/metrics');
310+
},
310311
);
311312
313+
const meter = new MeterProvider({
314+
exporter,
315+
interval: 1000,
316+
}).getMeter('your-meter-name');
317+
312318
const requestCount: Metric<BoundCounter> = meter.createCounter("requests", {
313319
monotonic: true,
314320
labelKeys: ["route"],

getting-started/ts-example/monitoring.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,20 @@ import { MeterProvider } from '@opentelemetry/metrics';
22
import { Metric, BoundCounter } from '@opentelemetry/api';
33
import { PrometheusExporter } from '@opentelemetry/exporter-prometheus';
44

5-
const meter = new MeterProvider().getMeter('example-ts');
6-
7-
meter.addExporter(
8-
new PrometheusExporter({ startServer: true }, () => {
9-
console.log("prometheus scrape endpoint: http://localhost:9464/metrics");
10-
})
5+
const exporter = new PrometheusExporter(
6+
{
7+
startServer: true,
8+
},
9+
() => {
10+
console.log('prometheus scrape endpoint: http://localhost:9464/metrics');
11+
},
1112
);
1213

14+
const meter = new MeterProvider({
15+
exporter,
16+
interval: 1000,
17+
}).getMeter('example-ts');
18+
1319
const requestCount: Metric<BoundCounter> = meter.createCounter("requests", {
1420
monotonic: true,
1521
labelKeys: ["route"],

0 commit comments

Comments
 (0)