Skip to content

Commit e42fbb9

Browse files
serkan-ozaltrentm
andauthored
feat(opentelemetry-instrumentation): replace semver package with internal semantic versioning check implementation (#5305)
Co-authored-by: Trent Mick <[email protected]>
1 parent 199fd8d commit e42fbb9

File tree

10 files changed

+969
-8
lines changed

10 files changed

+969
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
7474
* refactor(sdk-trace-base): rename `BasicTracerProvider.activeSpanProcessor` private property. [#5211](https://github.com/open-telemetry/opentelemetry-js/pull/5211) @david-luna
7575
* chore(selenium-tests): remove internal selenium-tests/ package, it wasn't being used @trentm
7676
* chore: update typescript `module` compiler option to `node16`. [#5347](https://github.com/open-telemetry/opentelemetry-js/pull/5347) @david-luna
77+
* feat(opentelemetry-instrumentation): replace `semver` package with internal semantic versioning check implementation to get rid of `semver` package initialization overhead especially in the AWS Lambda environment during coldstart [#5305](https://github.com/open-telemetry/opentelemetry-js/pull/5305) @serkan-ozal
7778

7879
## 1.30.0
7980

experimental/packages/opentelemetry-instrumentation/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
"@types/shimmer": "^1.2.0",
7575
"import-in-the-middle": "^1.8.1",
7676
"require-in-the-middle": "^7.1.1",
77-
"semver": "^7.5.2",
7877
"shimmer": "^1.2.1"
7978
},
8079
"peerDependencies": {

experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import * as types from '../../types';
1818
import * as path from 'path';
1919
import { types as utilTypes } from 'util';
20-
import { satisfies } from 'semver';
20+
import { satisfies } from '../../semver';
2121
import { wrap, unwrap, massWrap, massUnwrap } from 'shimmer';
2222
import { InstrumentationAbstract } from '../../instrumentation';
2323
import {

0 commit comments

Comments
 (0)