test(@opentelemetry/sdk-trace-node): refactor tests to allow use of mocha context (#5587)

Author: okpedersen

packages/opentelemetry-sdk-trace-node/test/NodeTracerProvider.test.ts

@@ -38,7 +38,7 @@ const sleep = (time: number) =>
     return setTimeout(resolve, time);
   });
 
-describe('NodeTracerProvider', () => {
+describe('NodeTracerProvider', function () {
   let provider: NodeTracerProvider;
   let contextManager: ContextManager;
 
@@ -52,39 +52,39 @@ describe('NodeTracerProvider', () => {
     context.disable();
   });
 
-  describe('constructor', () => {
-    it('should construct an instance with required only options', () => {
+  describe('constructor', function () {
+    it('should construct an instance with required only options', function () {
       provider = new NodeTracerProvider();
       assert.ok(provider instanceof NodeTracerProvider);
     });
 
-    it('should construct an instance with logger', () => {
+    it('should construct an instance with logger', function () {
       provider = new NodeTracerProvider();
       assert.ok(provider instanceof NodeTracerProvider);
     });
 
-    it('should construct an instance with sampler', () => {
+    it('should construct an instance with sampler', function () {
       provider = new NodeTracerProvider({
         sampler: new AlwaysOnSampler(),
       });
       assert.ok(provider instanceof NodeTracerProvider);
     });
   });
 
-  describe('.startSpan()', () => {
-    it('should start a span with name only', () => {
+  describe('.startSpan()', function () {
+    it('should start a span with name only', function () {
       provider = new NodeTracerProvider();
       const span = provider.getTracer('default').startSpan('my-span');
       assert.ok(span);
     });
 
-    it('should start a span with name and options', () => {
+    it('should start a span with name and options', function () {
       provider = new NodeTracerProvider();
       const span = provider.getTracer('default').startSpan('my-span', {});
       assert.ok(span);
     });
 
-    it('should return a default span with no sampling (AlwaysOffSampler)', () => {
+    it('should return a default span with no sampling (AlwaysOffSampler)', function () {
       provider = new NodeTracerProvider({
         sampler: new AlwaysOffSampler(),
       });
@@ -93,7 +93,7 @@ describe('NodeTracerProvider', () => {
       assert.strictEqual(span.isRecording(), false);
     });
 
-    it('should start a recording span with always sampling (AlwaysOnSampler)', () => {
+    it('should start a recording span with always sampling (AlwaysOnSampler)', function () {
       provider = new NodeTracerProvider({
         sampler: new AlwaysOnSampler(),
       });
@@ -102,7 +102,7 @@ describe('NodeTracerProvider', () => {
       assert.strictEqual(span.isRecording(), true);
     });
 
-    it('should sample with AlwaysOnSampler if parent was not sampled', () => {
+    it('should sample with AlwaysOnSampler if parent was not sampled', function () {
       provider = new NodeTracerProvider({
         sampler: new AlwaysOnSampler(),
       });
@@ -133,7 +133,7 @@ describe('NodeTracerProvider', () => {
       assert.strictEqual(span.isRecording(), true);
     });
 
-    it('should assign resource to span', () => {
+    it('should assign resource to span', function () {
       provider = new NodeTracerProvider();
       const span = provider.getTracer('default').startSpan('my-span') as Span;
       assert.ok(span);
@@ -145,7 +145,7 @@ describe('NodeTracerProvider', () => {
     });
   });
 
-  describe('.withSpan()', () => {
+  describe('.withSpan()', function () {
     it('should run context with AsyncHooksContextManager context manager', done => {
       provider = new NodeTracerProvider({});
       const span = provider.getTracer('default').startSpan('my-span');
@@ -178,7 +178,7 @@ describe('NodeTracerProvider', () => {
       assert.deepStrictEqual(trace.getSpan(context.active()), undefined);
     });
 
-    it('should find correct context with promises', async () => {
+    it('should find correct context with promises', async function () {
       provider = new NodeTracerProvider();
       const span = provider.getTracer('default').startSpan('my-span');
       await context.with(trace.setSpan(context.active(), span), async () => {
@@ -192,7 +192,7 @@ describe('NodeTracerProvider', () => {
     });
   });
 
-  describe('.bind()', () => {
+  describe('.bind()', function () {
     it('should bind context with AsyncHooksContextManager context manager', done => {
       const provider = new NodeTracerProvider({});
       const span = provider.getTracer('default').startSpan('my-span');

packages/opentelemetry-sdk-trace-node/test/registration.test.ts

@@ -37,14 +37,14 @@ const assertInstanceOf = (actual: object, ExpectedConstructor: Function) => {
   );
 };
 
-describe('API registration', () => {
+describe('API registration', function () {
   beforeEach(() => {
     context.disable();
     trace.disable();
     propagation.disable();
   });
 
-  it('should register default implementations', () => {
+  it('should register default implementations', function () {
     const tracerProvider = new NodeTracerProvider();
     tracerProvider.register();
 
@@ -61,7 +61,7 @@ describe('API registration', () => {
     assert.ok(apiTracerProvider.getDelegate() === tracerProvider);
   });
 
-  it('should register configured implementations', () => {
+  it('should register configured implementations', function () {
     const tracerProvider = new NodeTracerProvider();
 
     const mockContextManager = {
@@ -82,7 +82,7 @@ describe('API registration', () => {
     assert.strictEqual(apiTracerProvider.getDelegate(), tracerProvider);
   });
 
-  it('should skip null context manager', () => {
+  it('should skip null context manager', function () {
     const tracerProvider = new NodeTracerProvider();
     const ctxManager = context['_getContextManager']();
     tracerProvider.register({
@@ -104,7 +104,7 @@ describe('API registration', () => {
     assert.ok(apiTracerProvider.getDelegate() === tracerProvider);
   });
 
-  it('should skip null propagator', () => {
+  it('should skip null propagator', function () {
     const propagator = propagation['_getGlobalPropagator']();
 
     const tracerProvider = new NodeTracerProvider();