amqplib instrumentation: could not extract connection attribute protocol from user supplied url

[Shawnyeungcf]

Get message while using amqplib instrumentation.

registerInstrumentations({
  tracerProvider,
  instrumentations: [
    new AmqplibInstrumentation({
      publishHook: (span, publishParams) => {
        console.log('>>> publishHook')
      },
    }),
  ],
})

Full code tracer.js, and imported this file at the starting line of entry main js file.

import { NodeTracerProvider } from '@opentelemetry/node'
import { registerInstrumentations } from '@opentelemetry/instrumentation'
import api, { DiagConsoleLogger, DiagLogLevel } from '@opentelemetry/api'

import { AmqplibInstrumentation } from 'opentelemetry-instrumentation-amqplib'
import {
  BatchSpanProcessor,
} from '@opentelemetry/tracing'
import { JaegerExporter } from '@opentelemetry/exporter-jaeger'

// Not functionally required but gives some insight what happens behind the scenes
api.diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.INFO)

// Create a tracer provider
const tracerProvider = new NodeTracerProvider()

// This will automatically enable all instrumentations
registerInstrumentations({
  tracerProvider,
  instrumentations: [
    new AmqplibInstrumentation({
      publishHook: (span, publishParams) => {
        console.log('>>> publishHook')
      },
    }),
  ],
})

// Initialize the exporter.
const options = {
  serviceName: 'example-service',
  endpoint: 'http://jaeger:14268/api/traces',
}

tracerProvider.addSpanProcessor(new BatchSpanProcessor(new JaegerExporter(options)))

tracerProvider.register()

export const tracer = api.trace.getTracer('example-service')

console.log('tracing initialized for %s sending span to %s', options.serviceName, options.endpoint)

[Flarna]

The AmqplibInstrumentation package is hosted there: https://github.com/aspecto-io/opentelemetry-ext-js

I recommend to create an issue there.

fyi @blumamir

[blumamir]

Thanks @Flarna

I checked the code, and the protocol value is optional in the Options.Connect object and has a default value of amqp, but instrumentation is expecting it to be set.
This is a bug, I'll create a fix soon.
Thank you @Shawnyeungcf for reporting it

[blumamir]

Anyway, besides from the log print and the missing protocol attribute, instrumentation should work normally.
@Shawnyeungcf please share if you observe any effect on the traces

[blumamir]

PR with fix: aspecto-io/opentelemetry-ext-js#159