Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

Pins to [email protected] to avoid npm/cli#8628. When updating the lockfile to v3, I was met with quite a few missing "optional" dependencies for both @bufbuild/buf and nx that were previously installed.

I'm not sure if it's the same change in npm that caused it, but I've also seen an out-of-sync package-lock.json for older npm versions in #5976

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (8110127) to head (b918c81).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5979   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         316      316           
  Lines        8521     8521           
  Branches     1763     1763           
=======================================
  Hits         8110     8110           
  Misses        411      411           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc marked this pull request as ready for review October 2, 2025 13:37
@pichlermarc pichlermarc requested a review from a team as a code owner October 2, 2025 13:37
@pichlermarc pichlermarc added this pull request to the merge queue Oct 2, 2025
Merged via the queue into open-telemetry:main with commit b0c6fab Oct 2, 2025
25 of 26 checks passed
@pichlermarc pichlermarc deleted the ci/pin-npm branch October 2, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants