Skip to content

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 16, 2025

Which problem is this PR solving?

Node 25 has been released, but is not tested in the CI.

Fixes # N/A

Short description of the changes

This commit adds Node 25 to the CI.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran the test suite locally on Node 25

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner October 16, 2025 15:22
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (91e0d23) to head (0bc8c70).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6019   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         313      313           
  Lines        8799     8799           
  Branches     1888     1888           
=======================================
  Hits         8360     8360           
  Misses        439      439           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JacksonWeber
Copy link
Contributor

JacksonWeber commented Oct 17, 2025

The README.md claims that "Only Node.js Active or Maintenance LTS versions are supported", and Node.js v25 is neither of those. I'm not opposed to adding it to the CI necessarily, but this may give the impression that we "support" a runtime that we don't claim to.

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 17, 2025

I think it's good to test on the latest version. Node 25 in particular came with a bunch of breaking changes. It seems like a good idea to understand how those might impact the library since Node 26 will still include those breaking changes, and probably new ones.

That statement in the README is already a bit inaccurate anyway since Node 18 is supported but it has been EOL for some time now 😄

@pichlermarc
Copy link
Member

pichlermarc commented Oct 20, 2025

I think testing against Node.js 25 is okay. 🙂

While we don't officially support it, testing against it helps with two things:

  • when the next LTS comes around, we already have addressed any problems that came up during the non-LTS version's development, so we're quicker to support the next LTS
  • people will use it anyway (😅) and if we address issues on a best-effort basis while it's not supported, we reduce the amount of issues we need to triage - that helps cut down on noise.

We also did that with Node.js 21 and 23 IIRC.

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 20, 2025

@pichlermarc I'm not sure what's going on with the Windows tests results not being reported in the GitHub UI. It looks like they ran successfully - https://github.com/open-telemetry/opentelemetry-js/actions/runs/18654677064/job/53180745887?pr=6019

@pichlermarc pichlermarc enabled auto-merge October 20, 2025 16:09
@pichlermarc
Copy link
Member

@cjihrig I think the status check update got lost somewhere in GitHub's infra. I re-started the test - PR will be added to the merge queue once it's done running. :)

@pichlermarc pichlermarc added this pull request to the merge queue Oct 20, 2025
Merged via the queue into open-telemetry:main with commit 2d115fd Oct 20, 2025
37 checks passed
Copy link
Contributor

otelbot bot commented Oct 20, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the node25 branch October 20, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants