-
Notifications
You must be signed in to change notification settings - Fork 938
test: test Node.js 25 in CI #6019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6019 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 313 313
Lines 8799 8799
Branches 1888 1888
=======================================
Hits 8360 8360
Misses 439 439 🚀 New features to boost your workflow:
|
The |
I think it's good to test on the latest version. Node 25 in particular came with a bunch of breaking changes. It seems like a good idea to understand how those might impact the library since Node 26 will still include those breaking changes, and probably new ones. That statement in the README is already a bit inaccurate anyway since Node 18 is supported but it has been EOL for some time now 😄 |
I think testing against Node.js 25 is okay. 🙂 While we don't officially support it, testing against it helps with two things:
We also did that with Node.js 21 and 23 IIRC. |
@pichlermarc I'm not sure what's going on with the Windows tests results not being reported in the GitHub UI. It looks like they ran successfully - https://github.com/open-telemetry/opentelemetry-js/actions/runs/18654677064/job/53180745887?pr=6019 |
@cjihrig I think the status check update got lost somewhere in GitHub's infra. I re-started the test - PR will be added to the merge queue once it's done running. :) |
Which problem is this PR solving?
Node 25 has been released, but is not tested in the CI.
Fixes # N/A
Short description of the changes
This commit adds Node 25 to the CI.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: