From 7cbc531641204d5a437ae9b3b4cf546095ef1a88 Mon Sep 17 00:00:00 2001 From: Jisu Sim Date: Sat, 8 Nov 2025 00:49:46 +0900 Subject: [PATCH] chore(opentelemetry-instrumentation): improve _warnOnPreloadedModules function not to show warning logs when the module is not marked as loaded --- CHANGELOG.md | 2 ++ .../src/platform/node/instrumentation.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0acc8263db5..10ca3eb8ceb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,8 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2 * feat(sdk-trace-base): implement on ending in span processor [#6024](https://github.com/open-telemetry/opentelemetry-js/pull/6024) @majanjua-amzn * note: this feature is experimental and subject to change +* chore(opentelemetry-instrumentation): improve `_warnOnPreloadedModules` function not to show warning logs when the module is not marked as loaded [#6095](https://github.com/open-telemetry/opentelemetry-js/pull/6095) @rlj1202 + ### :bug: Bug Fixes ### :books: Documentation diff --git a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts index c5b7f5c6f56..29afb4dea90 100644 --- a/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts +++ b/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts @@ -148,7 +148,7 @@ export abstract class InstrumentationBase< const { name } = module; try { const resolvedModule = require.resolve(name); - if (require.cache[resolvedModule]) { + if (require.cache[resolvedModule]?.loaded) { // Module is already cached, which means the instrumentation hook might not work this._diag.warn( `Module ${name} has been loaded before ${this.instrumentationName} so it might not work, please initialize it before requiring ${name}`