Skip to content

Commit 6d26ef7

Browse files
authored
Merge branch 'main' into updatepy
2 parents 68be9fc + 8f4fac6 commit 6d26ef7

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

.github/workflows/codeql.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,12 @@ jobs:
102102
java-version: '11'
103103
if: ${{ matrix.target.language == 'java' }}
104104

105+
- name: Setup Gradle
106+
uses: gradle/actions/setup-gradle@v4
107+
105108
- name: build Java
106-
uses: gradle/gradle-build-action@v3
107-
with:
108-
arguments: build --no-build-cache
109-
build-root-directory: ${{ matrix.target.directory }}
109+
run: ./gradlew build --no-build-cache
110+
working-directory: ${{ matrix.target.directory }}
110111
if: ${{ matrix.target.language == 'java' }}
111112

112113
- name: setup dotnet

collector/go.mod

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ require (
3131
go.opentelemetry.io/collector/confmap/provider/envprovider v1.19.0
3232
go.opentelemetry.io/collector/confmap/provider/fileprovider v1.19.0
3333
go.opentelemetry.io/collector/confmap/provider/httpprovider v1.19.0
34+
go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.19.0
3435
go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.19.0
3536
go.opentelemetry.io/collector/otelcol v0.113.0
3637
go.uber.org/multierr v1.11.0
@@ -93,7 +94,7 @@ require (
9394
github.com/klauspost/compress v1.17.11 // indirect
9495
github.com/knadh/koanf/maps v0.1.1 // indirect
9596
github.com/knadh/koanf/providers/confmap v0.1.0 // indirect
96-
github.com/knadh/koanf/v2 v2.1.1 // indirect
97+
github.com/knadh/koanf/v2 v2.1.2 // indirect
9798
github.com/lightstep/go-expohisto v1.0.0 // indirect
9899
github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
99100
github.com/magefile/mage v1.15.0 // indirect

collector/go.sum

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ github.com/knadh/koanf/maps v0.1.1 h1:G5TjmUh2D7G2YWf5SQQqSiHRJEjaicvU0KpypqB3NI
129129
github.com/knadh/koanf/maps v0.1.1/go.mod h1:npD/QZY3V6ghQDdcQzl1W4ICNVTkohC8E73eI2xW4yI=
130130
github.com/knadh/koanf/providers/confmap v0.1.0 h1:gOkxhHkemwG4LezxxN8DMOFopOPghxRVp7JbIvdvqzU=
131131
github.com/knadh/koanf/providers/confmap v0.1.0/go.mod h1:2uLhxQzJnyHKfxG927awZC7+fyHFdQkd697K4MdLnIU=
132-
github.com/knadh/koanf/v2 v2.1.1 h1:/R8eXqasSTsmDCsAyYj+81Wteg8AqrV9CP6gvsTsOmM=
133-
github.com/knadh/koanf/v2 v2.1.1/go.mod h1:4mnTRbZCK+ALuBXHZMjDfG9y714L7TykVnZkXbMU3Es=
132+
github.com/knadh/koanf/v2 v2.1.2 h1:I2rtLRqXRy1p01m/utEtpZSSA6dcJbgGVuE27kW2PzQ=
133+
github.com/knadh/koanf/v2 v2.1.2/go.mod h1:Gphfaen0q1Fc1HTgJgSTC4oRX9R2R5ErYMZJy8fLJBo=
134134
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
135135
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
136136
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
@@ -291,6 +291,8 @@ go.opentelemetry.io/collector/confmap/provider/fileprovider v1.19.0 h1:TYwyk4ea3
291291
go.opentelemetry.io/collector/confmap/provider/fileprovider v1.19.0/go.mod h1:i3mL4OSGI5JM0hnzHujhJK+LDlvO3XrJxBsuclfU/jY=
292292
go.opentelemetry.io/collector/confmap/provider/httpprovider v1.19.0 h1:a077jcs3DVtaVdmgmCk3x4rRYuTkIqMDsoUc+VICHZk=
293293
go.opentelemetry.io/collector/confmap/provider/httpprovider v1.19.0/go.mod h1:HjYkzhHbwUacv27nq0JLsslGpbtrXyyfU30Oc72AWLU=
294+
go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.19.0 h1:8LoQxjlduFQUEwYuHWnxEj0A+GcAtpv2qPpDJVz7A5E=
295+
go.opentelemetry.io/collector/confmap/provider/httpsprovider v1.19.0/go.mod h1:Y8ErEl5m9+1AWzWcMn52PATH5dw50wuyyPMffK62RCI=
294296
go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.19.0 h1:oV66DKiEdAt8EMZqGSChK2iEOxjrVaWRhf4OqqmqjbM=
295297
go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.19.0/go.mod h1:jtNUdO6i1k38BG7vFst+d1jk/N+c419uVR8HB4J0VjI=
296298
go.opentelemetry.io/collector/connector v0.113.0 h1:ii+s1CjsLxtglqRlFs6tv8UU/uX45dyN9lbTRbR0p8g=

collector/internal/collector/collector.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"go.opentelemetry.io/collector/confmap/provider/envprovider"
2727
"go.opentelemetry.io/collector/confmap/provider/fileprovider"
2828
"go.opentelemetry.io/collector/confmap/provider/httpprovider"
29+
"go.opentelemetry.io/collector/confmap/provider/httpsprovider"
2930
"go.opentelemetry.io/collector/confmap/provider/yamlprovider"
3031
"go.opentelemetry.io/collector/otelcol"
3132
"go.uber.org/zap"
@@ -73,7 +74,7 @@ func NewCollector(logger *zap.Logger, factories otelcol.Factories, version strin
7374
cfgSet := otelcol.ConfigProviderSettings{
7475
ResolverSettings: confmap.ResolverSettings{
7576
URIs: []string{getConfig(l)},
76-
ProviderFactories: []confmap.ProviderFactory{fileprovider.NewFactory(), envprovider.NewFactory(), yamlprovider.NewFactory(), httpprovider.NewFactory(), s3provider.NewFactory(), secretsmanagerprovider.NewFactory()},
77+
ProviderFactories: []confmap.ProviderFactory{fileprovider.NewFactory(), envprovider.NewFactory(), yamlprovider.NewFactory(), httpsprovider.NewFactory(), httpprovider.NewFactory(), s3provider.NewFactory(), secretsmanagerprovider.NewFactory()},
7778
ConverterFactories: []confmap.ConverterFactory{
7879
confmap.NewConverterFactory(func(set confmap.ConverterSettings) confmap.Converter {
7980
return disablequeuedretryconverter.New()

docs/design_proposal.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ It's important to clarify that auto-instrumentation is not library instrumentati
4343
We can have three layers of wrapper on a user's Lambda function: ___Lambda function instrumentation___, ___execution wrapper___ and ___Lambda EXEC Wrapper___. Each one can add new functionality by wrapping the previous one, to further improve user experience.
4444
![wrappers](https://user-images.githubusercontent.com/66336933/113330096-3af7b880-92d3-11eb-89bf-580ed8614807.png)
4545
1. ___Lambda function instrumentation___:
46-
Lambda function instrumentation is the first step of OpenTelemetry Lambda support, which is wrapping the Lambda handler function with beginSpan() and endSpan(), adding OpenTelemetry attributes by following [trace](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/faas.md) and [resource](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/semantic_conventions/faas.md) FaaS spec. Java and Python implementations are in place, other languages can refer to the code for them.
46+
Lambda function instrumentation is the first step of OpenTelemetry Lambda support, which is wrapping the Lambda handler function with beginSpan() and endSpan(), adding OpenTelemetry attributes by following [trace](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/faas/faas-spans.md) and [resource](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/faas.md) FaaS spec. Java and Python implementations are in place, other languages can refer to the code for them.
4747
2. ___Lambda execution wrapper___:
4848
Lambda execution wrapper uses reflection to dynamically decorate the user’s original Lambda function. It can add functionality to a user's existing Lambda function without changing source code, but the user must change the Lambda handler name and add the original handler path as an environment variable. With OpenTelemetry, the decoration can be anything, such as initializing OpenTelemetry components, calling instrumentation, or even implementing instrumentation directly. If desired, a developer can also merge Lambda function instrumentation and Lambda execution wrapper into one wrapper.
4949
See [Java example](https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/1471/files) (decorate Lambda instrumentation) and [Python example](https://github.com/open-telemetry/opentelemetry-lambda/blob/main/python/src/otel/otel_sdk/otel_wrapper.py) (initialize OpenTelemetry components for auto-instrumentation).

0 commit comments

Comments
 (0)