Skip to content

Conversation

@duncanista
Copy link
Contributor

@duncanista duncanista commented May 28, 2025

What?

Creates an otel-handler script which forwards arguments directly to otel-instrument

Motivation

#1788

Notes

Docs PR: open-telemetry/opentelemetry.io#7048

Tests

  • Manually built a layer and tested it

@duncanista duncanista requested a review from a team as a code owner May 28, 2025 20:49
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@serkan-ozal
Copy link
Contributor

serkan-ozal commented May 31, 2025

Hi @duncanista can you also update

removing references to the old handler should be ok, because the new one should be a wrapper which just acts upon the old one
@duncanista
Copy link
Contributor Author

duncanista commented Jun 4, 2025

Looking at the pipeline error – added docs in PR description

-- edit
Looks like a permissions issue, file indeed required permissions, but that hasn't fixed it in my side, still researching.

@serkan-ozal serkan-ozal self-requested a review June 4, 2025 19:19
unit tests actually required us to register both files so it worked as expected
@duncanista
Copy link
Contributor Author

Updated permissions and issue in unit tests, thanks for running the tests, allowed me to understand how they worked!

@duncanista
Copy link
Contributor Author

Updated docs, they might be required to be approved by the maintainers of this repository – cheers!

@tylerbenson tylerbenson added the python Pull requests that update Python code label Jun 6, 2025
@tylerbenson
Copy link
Member

@open-telemetry/lambda-extension-maintainers Please comment here when this is released so the docs can be published.

@tylerbenson tylerbenson merged commit 759d579 into open-telemetry:main Jun 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants