[chore]: enable unused-receiver rule from revive (#4786)

mmorel-35 · web-flow · commit 1ef7486816bc · 2026-03-03T11:36:14.000+01:00
Signed-off-by: Matthieu MOREL &lt;matthieu.morel35@gmail.com&gt;
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -142,8 +142,6 @@ linters:
           disabled: true
         - name: unused-parameter
           disabled: true # FIXME
-        - name: unused-receiver
-          disabled: true # FIXME
         - name: use-waitgroup-go
           disabled: true
         - name: var-naming
diff --git a/apis/v1alpha1/instrumentation_webhook.go b/apis/v1alpha1/instrumentation_webhook.go
@@ -198,7 +198,7 @@ func (w InstrumentationWebhook) defaulter(r *Instrumentation) error {
 	return nil
 }
 
-func (w InstrumentationWebhook) validate(r *Instrumentation) (admission.Warnings, error) {
+func (InstrumentationWebhook) validate(r *Instrumentation) (admission.Warnings, error) {
 	var warnings []string
 	switch r.Spec.Type {
 	case "":
diff --git a/apis/v1alpha1/opampbridge_webhook.go b/apis/v1alpha1/opampbridge_webhook.go
@@ -66,7 +66,7 @@ func (o *OpAMPBridgeWebhook) ValidateDelete(ctx context.Context, obj runtime.Obj
 	return o.validate(opampBridge)
 }
 
-func (o *OpAMPBridgeWebhook) defaulter(r *OpAMPBridge) error {
+func (*OpAMPBridgeWebhook) defaulter(r *OpAMPBridge) error {
 	if len(r.Spec.UpgradeStrategy) == 0 {
 		r.Spec.UpgradeStrategy = UpgradeStrategyAutomatic
 	}
@@ -90,7 +90,7 @@ func (o *OpAMPBridgeWebhook) defaulter(r *OpAMPBridge) error {
 	return nil
 }
 
-func (o *OpAMPBridgeWebhook) validate(r *OpAMPBridge) (admission.Warnings, error) {
+func (*OpAMPBridgeWebhook) validate(r *OpAMPBridge) (admission.Warnings, error) {
 	warnings := admission.Warnings{}
 
 	// validate OpAMP server endpoint
diff --git a/apis/v1alpha1/targetallocator_webhook.go b/apis/v1alpha1/targetallocator_webhook.go
@@ -70,7 +70,7 @@ func (w TargetAllocatorWebhook) ValidateDelete(ctx context.Context, obj runtime.
 	return w.validate(ctx, otelcol)
 }
 
-func (w TargetAllocatorWebhook) defaulter(ta *TargetAllocator) error {
+func (TargetAllocatorWebhook) defaulter(ta *TargetAllocator) error {
 	if ta.Labels == nil {
 		ta.Labels = map[string]string{}
 	}
diff --git a/cmd/gather/cluster/cluster_test.go b/cmd/gather/cluster/cluster_test.go
@@ -80,15 +80,15 @@ func (m *MockClient) RESTMapper() meta.RESTMapper {
 	return args.Get(0).(meta.RESTMapper)
 }
 
-func (m *MockClient) GroupVersionKindFor(obj runtime.Object) (schema.GroupVersionKind, error) {
+func (*MockClient) GroupVersionKindFor(obj runtime.Object) (schema.GroupVersionKind, error) {
 	return schema.GroupVersionKind{}, nil
 }
 
-func (m *MockClient) IsObjectNamespaced(_ runtime.Object) (bool, error) {
+func (*MockClient) IsObjectNamespaced(runtime.Object) (bool, error) {
 	return true, nil
 }
 
-func (m *MockClient) SubResource(string) client.SubResourceClient {
+func (*MockClient) SubResource(string) client.SubResourceClient {
 	return nil
 }
 
diff --git a/cmd/operator-opamp-bridge/internal/agent/agent.go b/cmd/operator-opamp-bridge/internal/agent/agent.go
@@ -158,7 +158,7 @@ func (agent *Agent) generateCollectorPoolHealth() (map[string]*protobufs.Compone
 }
 
 // getCollectorSelector destructures the collectors scale selector if present, it uses the labelmap from the operator.
-func (agent *Agent) getCollectorSelector(col v1beta1.OpenTelemetryCollector) map[string]string {
+func (*Agent) getCollectorSelector(col v1beta1.OpenTelemetryCollector) map[string]string {
 	if len(col.Status.Scale.Selector) > 0 {
 		selMap := map[string]string{}
 		for kvPair := range strings.SplitSeq(col.Status.Scale.Selector, ",") {
diff --git a/cmd/operator-opamp-bridge/internal/agent/agent_test.go b/cmd/operator-opamp-bridge/internal/agent/agent_test.go
@@ -184,15 +184,15 @@ type mockOpampClient struct {
 	settings            types.StartSettings
 }
 
-func (m *mockOpampClient) SetCustomCapabilities(_ *protobufs.CustomCapabilities) error {
+func (*mockOpampClient) SetCustomCapabilities(*protobufs.CustomCapabilities) error {
 	return nil
 }
 
-func (m *mockOpampClient) SendCustomMessage(_ *protobufs.CustomMessage) (messageSendingChannel chan struct{}, err error) {
+func (*mockOpampClient) SendCustomMessage(*protobufs.CustomMessage) (messageSendingChannel chan struct{}, err error) {
 	return nil, nil
 }
 
-func (m *mockOpampClient) RequestConnectionSettings(_ *protobufs.ConnectionSettingsRequest) error {
+func (*mockOpampClient) RequestConnectionSettings(*protobufs.ConnectionSettingsRequest) error {
 	return nil
 }
 
@@ -203,15 +203,15 @@ func (m *mockOpampClient) Start(_ context.Context, settings types.StartSettings)
 	return nil
 }
 
-func (m *mockOpampClient) Stop(_ context.Context) error {
+func (*mockOpampClient) Stop(context.Context) error {
 	return nil
 }
 
-func (m *mockOpampClient) SetAgentDescription(_ *protobufs.AgentDescription) error {
+func (*mockOpampClient) SetAgentDescription(*protobufs.AgentDescription) error {
 	return nil
 }
 
-func (m *mockOpampClient) AgentDescription() *protobufs.AgentDescription {
+func (*mockOpampClient) AgentDescription() *protobufs.AgentDescription {
 	return nil
 }
 
@@ -240,7 +240,7 @@ func (m *mockOpampClient) SetRemoteConfigStatus(status *protobufs.RemoteConfigSt
 	return nil
 }
 
-func (m *mockOpampClient) SetPackageStatuses(_ *protobufs.PackageStatuses) error {
+func (*mockOpampClient) SetPackageStatuses(*protobufs.PackageStatuses) error {
 	return nil
 }
 
diff --git a/cmd/operator-opamp-bridge/internal/config/config.go b/cmd/operator-opamp-bridge/internal/config/config.go
@@ -157,11 +157,11 @@ func (c *Config) GetAgentScheme() string {
 	return uri.Scheme
 }
 
-func (c *Config) GetAgentType() string {
+func (*Config) GetAgentType() string {
 	return agentType
 }
 
-func (c *Config) GetAgentVersion() string {
+func (*Config) GetAgentVersion() string {
 	return agentVersion
 }
 
diff --git a/cmd/operator-opamp-bridge/internal/proxy/agent.go b/cmd/operator-opamp-bridge/internal/proxy/agent.go
@@ -128,7 +128,7 @@ func (a *Agent) UpdateStatus(newStatus *protobufs.AgentToServer, response *proto
 	return agentDescrChanged
 }
 
-func (a *Agent) calcConnectionSettings(response *protobufs.ServerToAgent) {
+func (*Agent) calcConnectionSettings(response *protobufs.ServerToAgent) {
 	// Here we can use Agent's description to send the appropriate connection
 	// settings to the Agent.
 	// In this simple example the connection settings do not depend on the
diff --git a/cmd/operator-opamp-bridge/internal/proxy/server_test.go b/cmd/operator-opamp-bridge/internal/proxy/server_test.go
@@ -143,19 +143,19 @@ func TestGetInstanceId(t *testing.T) {
 type mockConnection struct{}
 
 // Connection implements types.Connection.
-func (m *mockConnection) Connection() net.Conn {
+func (*mockConnection) Connection() net.Conn {
 	panic("unimplemented")
 }
 
 // Disconnect implements types.Connection.
-func (m *mockConnection) Disconnect() error {
+func (*mockConnection) Disconnect() error {
 	panic("unimplemented")
 }
 
-func (m *mockConnection) Send(ctx context.Context, msg *protobufs.ServerToAgent) error {
+func (*mockConnection) Send(ctx context.Context, msg *protobufs.ServerToAgent) error {
 	return nil
 }
 
-func (m *mockConnection) Close() error {
+func (*mockConnection) Close() error {
 	return nil
 }
diff --git a/cmd/otel-allocator/internal/allocation/consistent_hashing.go b/cmd/otel-allocator/internal/allocation/consistent_hashing.go
@@ -16,7 +16,7 @@ const consistentHashingStrategyName = "consistent-hashing"
 
 type hasher struct{}
 
-func (h hasher) Sum64(data []byte) uint64 {
+func (hasher) Sum64(data []byte) uint64 {
 	return xxhash.Sum64(data)
 }
 
@@ -42,7 +42,7 @@ func newConsistentHashingStrategy() Strategy {
 	return chStrategy
 }
 
-func (s *consistentHashingStrategy) GetName() string {
+func (*consistentHashingStrategy) GetName() string {
 	return consistentHashingStrategyName
 }
 
@@ -72,4 +72,4 @@ func (s *consistentHashingStrategy) SetCollectors(collectors map[string]*Collect
 	s.consistentHasher = consistent.New(members, s.config)
 }
 
-func (s *consistentHashingStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
+func (*consistentHashingStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
diff --git a/cmd/otel-allocator/internal/allocation/least_weighted.go b/cmd/otel-allocator/internal/allocation/least_weighted.go
@@ -17,11 +17,11 @@ func newleastWeightedStrategy() Strategy {
 	return &leastWeightedStrategy{}
 }
 
-func (s *leastWeightedStrategy) GetName() string {
+func (*leastWeightedStrategy) GetName() string {
 	return leastWeightedStrategyName
 }
 
-func (s *leastWeightedStrategy) GetCollectorForTarget(collectors map[string]*Collector, item *target.Item) (*Collector, error) {
+func (*leastWeightedStrategy) GetCollectorForTarget(collectors map[string]*Collector, item *target.Item) (*Collector, error) {
 	// if a collector is already assigned, do nothing
 	// TODO: track this in a separate map
 	if item.CollectorName != "" {
@@ -53,6 +53,6 @@ func (s *leastWeightedStrategy) GetCollectorForTarget(collectors map[string]*Col
 	return col, nil
 }
 
-func (s *leastWeightedStrategy) SetCollectors(_ map[string]*Collector) {}
+func (*leastWeightedStrategy) SetCollectors(map[string]*Collector) {}
 
-func (s *leastWeightedStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
+func (*leastWeightedStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
diff --git a/cmd/otel-allocator/internal/allocation/per_node.go b/cmd/otel-allocator/internal/allocation/per_node.go
@@ -29,7 +29,7 @@ func (s *perNodeStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {
 	s.fallbackStrategy = fallbackStrategy
 }
 
-func (s *perNodeStrategy) GetName() string {
+func (*perNodeStrategy) GetName() string {
 	return perNodeStrategyName
 }
 
diff --git a/cmd/otel-allocator/internal/collector/collector.go b/cmd/otel-allocator/internal/collector/collector.go
@@ -151,7 +151,7 @@ func (k *Watcher) Close() {
 	close(k.close)
 }
 
-func (k *Watcher) isPodUnhealthy(pod *v1.Pod, collectorNotReadyGracePeriod time.Duration) bool {
+func (*Watcher) isPodUnhealthy(pod *v1.Pod, collectorNotReadyGracePeriod time.Duration) bool {
 	if collectorNotReadyGracePeriod == 0*time.Second {
 		return false
 	}
diff --git a/cmd/otel-allocator/internal/collector/collector_test.go b/cmd/otel-allocator/internal/collector/collector_test.go
@@ -40,7 +40,7 @@ func (r *reportingGauge) Record(_ context.Context, value int64, _ ...metric.Reco
 	r.value.Store(value)
 }
 
-func (r *reportingGauge) Enabled(_ context.Context) bool {
+func (*reportingGauge) Enabled(context.Context) bool {
 	return true
 }
 
diff --git a/cmd/otel-allocator/internal/server/mocks_test.go b/cmd/otel-allocator/internal/server/mocks_test.go
@@ -16,12 +16,12 @@ type mockAllocator struct {
 	targetItems map[target.ItemHash]*target.Item
 }
 
-func (m *mockAllocator) SetCollectors(_ map[string]*allocation.Collector)               {}
-func (m *mockAllocator) SetTargets(_ []*target.Item)                                    {}
-func (m *mockAllocator) Collectors() map[string]*allocation.Collector                   { return nil }
-func (m *mockAllocator) GetTargetsForCollectorAndJob(_ string, _ string) []*target.Item { return nil }
-func (m *mockAllocator) SetFilter(_ allocation.Filter)                                  {}
-func (m *mockAllocator) SetFallbackStrategy(_ allocation.Strategy)                      {}
+func (*mockAllocator) SetCollectors(map[string]*allocation.Collector)             {}
+func (*mockAllocator) SetTargets([]*target.Item)                                  {}
+func (*mockAllocator) Collectors() map[string]*allocation.Collector               { return nil }
+func (*mockAllocator) GetTargetsForCollectorAndJob(string, string) []*target.Item { return nil }
+func (*mockAllocator) SetFilter(allocation.Filter)                                {}
+func (*mockAllocator) SetFallbackStrategy(allocation.Strategy)                    {}
 
 func (m *mockAllocator) TargetItems() map[target.ItemHash]*target.Item {
 	return m.targetItems
diff --git a/cmd/otel-allocator/internal/server/server.go b/cmd/otel-allocator/internal/server/server.go
@@ -277,7 +277,7 @@ func (s *Server) JobsHandler(c *gin.Context) {
 	s.jsonHandler(c.Writer, displayData)
 }
 
-func (s *Server) LivenessProbeHandler(c *gin.Context) {
+func (*Server) LivenessProbeHandler(c *gin.Context) {
 	c.Status(http.StatusOK)
 }
 
diff --git a/internal/autodetect/main.go b/internal/autodetect/main.go
@@ -262,7 +262,7 @@ func (a *autoDetect) OpAmpBridgeAvailablity() (opampbridge.Availability, error)
 	return opampbridge.NotAvailable, nil
 }
 
-func (a *autoDetect) FIPSEnabled(_ context.Context) bool {
+func (*autoDetect) FIPSEnabled(context.Context) bool {
 	return fips.IsFipsEnabled()
 }
 
diff --git a/internal/autodetect/main_test.go b/internal/autodetect/main_test.go
@@ -431,7 +431,7 @@ func (m *mockAutoDetect) CollectorAvailability() (collector.Availability, error)
 	return collector.NotAvailable, nil
 }
 
-func (m *mockAutoDetect) FIPSEnabled(_ context.Context) bool {
+func (*mockAutoDetect) FIPSEnabled(context.Context) bool {
 	return false
 }
 
diff --git a/internal/components/multi_endpoint.go b/internal/components/multi_endpoint.go
@@ -94,23 +94,23 @@ func (m *MultiPortReceiver) GetDefaultConfig(logger logr.Logger, config any) (an
 	}, nil
 }
 
-func (m *MultiPortReceiver) GetLivenessProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
+func (*MultiPortReceiver) GetLivenessProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
 	return nil, nil
 }
 
-func (m *MultiPortReceiver) GetReadinessProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
+func (*MultiPortReceiver) GetReadinessProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
 	return nil, nil
 }
 
-func (m *MultiPortReceiver) GetStartupProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
+func (*MultiPortReceiver) GetStartupProbe(logger logr.Logger, config any) (*corev1.Probe, error) {
 	return nil, nil
 }
 
-func (m *MultiPortReceiver) GetRBACRules(logr.Logger, any) ([]rbacv1.PolicyRule, error) {
+func (*MultiPortReceiver) GetRBACRules(logr.Logger, any) ([]rbacv1.PolicyRule, error) {
 	return nil, nil
 }
 
-func (m *MultiPortReceiver) GetEnvironmentVariables(logger logr.Logger, config any) ([]corev1.EnvVar, error) {
+func (*MultiPortReceiver) GetEnvironmentVariables(logger logr.Logger, config any) ([]corev1.EnvVar, error) {
 	return nil, nil
 }
 
diff --git a/internal/controllers/clusterobservability_controller.go b/internal/controllers/clusterobservability_controller.go
@@ -531,7 +531,7 @@ func (r *ClusterObservabilityReconciler) cleanupClusterScopedResources(ctx conte
 // GetOwnedResourceTypes returns CRs directly created by ClusterObservability.
 // Note: We only track OpenTelemetry CRs we create, not the underlying K8s resources
 // (those are managed by OpenTelemetryCollector controller).
-func (r *ClusterObservabilityReconciler) GetOwnedResourceTypes() []client.Object {
+func (*ClusterObservabilityReconciler) GetOwnedResourceTypes() []client.Object {
 	return []client.Object{
 		&v1beta1.OpenTelemetryCollector{},
 		&v1alpha1.Instrumentation{},
diff --git a/internal/controllers/suite_test.go b/internal/controllers/suite_test.go
@@ -100,11 +100,11 @@ type mockAutoDetect struct {
 	OpAmpBridgeAvailabilityFunc     func() (opampbridge.Availability, error)
 }
 
-func (m *mockAutoDetect) FIPSEnabled(_ context.Context) bool {
+func (*mockAutoDetect) FIPSEnabled(context.Context) bool {
 	return false
 }
 
-func (m *mockAutoDetect) NativeSidecarSupport() (bool, error) {
+func (*mockAutoDetect) NativeSidecarSupport() (bool, error) {
 	return false, nil
 }
 
diff --git a/internal/instrumentation/sdk.go b/internal/instrumentation/sdk.go
@@ -296,7 +296,7 @@ func containersToInstrument(inst *instrumentationWithContainers, pod *corev1.Pod
 	return append(initContainers, regularContainers...)
 }
 
-func (i *sdkInjector) setInitContainerSecurityContext(pod corev1.Pod, securityContext *corev1.SecurityContext, instrInitContainerName string) corev1.Pod {
+func (*sdkInjector) setInitContainerSecurityContext(pod corev1.Pod, securityContext *corev1.SecurityContext, instrInitContainerName string) corev1.Pod {
 	for i, initContainer := range pod.Spec.InitContainers {
 		if initContainer.Name == instrInitContainerName {
 			pod.Spec.InitContainers[i].SecurityContext = securityContext
@@ -352,7 +352,7 @@ func getContainerByName(containerName string, pod *corev1.Pod) *corev1.Container
 	return container
 }
 
-func (i *sdkInjector) injectCommonEnvVar(otelinst v1alpha1.Instrumentation, container *corev1.Container) {
+func (*sdkInjector) injectCommonEnvVar(otelinst v1alpha1.Instrumentation, container *corev1.Container) {
 	idx := getIndexOfEnv(container.Env, constants.EnvPodIP)
 	if idx == -1 {
 		container.Env = append([]corev1.EnvVar{{
@@ -386,23 +386,23 @@ func (i *sdkInjector) injectCommonEnvVar(otelinst v1alpha1.Instrumentation, cont
 }
 
 // injectDefaultJavaEnvVars injects default environment variables for Java.
-func (i *sdkInjector) injectDefaultJavaEnvVars(container *corev1.Container, javaSpec v1alpha1.Java) {
+func (*sdkInjector) injectDefaultJavaEnvVars(container *corev1.Container, javaSpec v1alpha1.Java) {
 	container.Env = appendOrReplace(container.Env, getDefaultJavaEnvVars(container, javaSpec)...)
 }
 
 // injectDefaultNodeJSEnvVars injects default environment variables for Node.js.
-func (i *sdkInjector) injectDefaultNodeJSEnvVars(container *corev1.Container) {
+func (*sdkInjector) injectDefaultNodeJSEnvVars(container *corev1.Container) {
 	envVars := getDefaultNodeJSEnvVars(container)
 	container.Env = appendOrReplace(container.Env, envVars...)
 }
 
 // injectDefaultPythonEnvVars injects default environment variables for Python.
-func (i *sdkInjector) injectDefaultPythonEnvVars(container *corev1.Container) {
+func (*sdkInjector) injectDefaultPythonEnvVars(container *corev1.Container) {
 	container.Env = appendIfNotSet(container.Env, getDefaultPythonEnvVars()...)
 }
 
 // injectDefaultDotNetEnvVarsWrapper injects default environment variables for .NET.
-func (i *sdkInjector) injectDefaultDotNetEnvVarsWrapper(pod corev1.Pod, container *corev1.Container, runtime string) corev1.Pod {
+func (*sdkInjector) injectDefaultDotNetEnvVarsWrapper(pod corev1.Pod, container *corev1.Container, runtime string) corev1.Pod {
 	injectDefaultDotNetEnvVars(container, runtime)
 	return pod
 }
diff --git a/internal/manifests/clusterobservability/config/loader.go b/internal/manifests/clusterobservability/config/loader.go
diff --git a/internal/manifests/collector/collector_test.go b/internal/manifests/collector/collector_test.go
diff --git a/internal/openshift/dashboards/dashboards.go b/internal/openshift/dashboards/dashboards.go
diff --git a/internal/operator-metrics/metrics.go b/internal/operator-metrics/metrics.go

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ func (w InstrumentationWebhook) defaulter(r *Instrumentation) error {`
`198`	`198`	`return nil`
`199`	`199`	`}`
`200`	`200`
`201`		`-func (w InstrumentationWebhook) validate(r *Instrumentation) (admission.Warnings, error) {`
	`201`	`+func (InstrumentationWebhook) validate(r *Instrumentation) (admission.Warnings, error) {`
`202`	`202`	`var warnings []string`
`203`	`203`	`switch r.Spec.Type {`
`204`	`204`	`case "":`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func (o *OpAMPBridgeWebhook) ValidateDelete(ctx context.Context, obj runtime.Obj`
`66`	`66`	`return o.validate(opampBridge)`
`67`	`67`	`}`
`68`	`68`
`69`		`-func (o OpAMPBridgeWebhook) defaulter(r OpAMPBridge) error {`
	`69`	`+func (OpAMPBridgeWebhook) defaulter(r OpAMPBridge) error {`
`70`	`70`	`if len(r.Spec.UpgradeStrategy) == 0 {`
`71`	`71`	`r.Spec.UpgradeStrategy = UpgradeStrategyAutomatic`
`72`	`72`	`}`
`@@ -90,7 +90,7 @@ func (o OpAMPBridgeWebhook) defaulter(r OpAMPBridge) error {`
`90`	`90`	`return nil`
`91`	`91`	`}`
`92`	`92`
`93`		`-func (o OpAMPBridgeWebhook) validate(r OpAMPBridge) (admission.Warnings, error) {`
	`93`	`+func (OpAMPBridgeWebhook) validate(r OpAMPBridge) (admission.Warnings, error) {`
`94`	`94`	`warnings := admission.Warnings{}`
`95`	`95`
`96`	`96`	`// validate OpAMP server endpoint`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func (w TargetAllocatorWebhook) ValidateDelete(ctx context.Context, obj runtime.`
`70`	`70`	`return w.validate(ctx, otelcol)`
`71`	`71`	`}`
`72`	`72`
`73`		`-func (w TargetAllocatorWebhook) defaulter(ta *TargetAllocator) error {`
	`73`	`+func (TargetAllocatorWebhook) defaulter(ta *TargetAllocator) error {`
`74`	`74`	`if ta.Labels == nil {`
`75`	`75`	`ta.Labels = map[string]string{}`
`76`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,15 +80,15 @@ func (m *MockClient) RESTMapper() meta.RESTMapper {`
`80`	`80`	`return args.Get(0).(meta.RESTMapper)`
`81`	`81`	`}`
`82`	`82`
`83`		`-func (m *MockClient) GroupVersionKindFor(obj runtime.Object) (schema.GroupVersionKind, error) {`
	`83`	`+func (*MockClient) GroupVersionKindFor(obj runtime.Object) (schema.GroupVersionKind, error) {`
`84`	`84`	`return schema.GroupVersionKind{}, nil`
`85`	`85`	`}`
`86`	`86`
`87`		`-func (m *MockClient) IsObjectNamespaced(_ runtime.Object) (bool, error) {`
	`87`	`+func (*MockClient) IsObjectNamespaced(runtime.Object) (bool, error) {`
`88`	`88`	`return true, nil`
`89`	`89`	`}`
`90`	`90`
`91`		`-func (m *MockClient) SubResource(string) client.SubResourceClient {`
	`91`	`+func (*MockClient) SubResource(string) client.SubResourceClient {`
`92`	`92`	`return nil`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ func (agent Agent) generateCollectorPoolHealth() (map[string]protobufs.Compone`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`// getCollectorSelector destructures the collectors scale selector if present, it uses the labelmap from the operator.`
`161`		`-func (agent *Agent) getCollectorSelector(col v1beta1.OpenTelemetryCollector) map[string]string {`
	`161`	`+func (*Agent) getCollectorSelector(col v1beta1.OpenTelemetryCollector) map[string]string {`
`162`	`162`	`if len(col.Status.Scale.Selector) > 0 {`
`163`	`163`	`selMap := map[string]string{}`
`164`	`164`	`for kvPair := range strings.SplitSeq(col.Status.Scale.Selector, ",") {`
Original file line number	Diff line number	Diff line change
`@@ -184,15 +184,15 @@ type mockOpampClient struct {`
`184`	`184`	`settings types.StartSettings`
`185`	`185`	`}`
`186`	`186`
`187`		`-func (m mockOpampClient) SetCustomCapabilities(_ protobufs.CustomCapabilities) error {`
	`187`	`+func (mockOpampClient) SetCustomCapabilities(protobufs.CustomCapabilities) error {`
`188`	`188`	`return nil`
`189`	`189`	`}`
`190`	`190`
`191`		`-func (m mockOpampClient) SendCustomMessage(_ protobufs.CustomMessage) (messageSendingChannel chan struct{}, err error) {`
	`191`	`+func (mockOpampClient) SendCustomMessage(protobufs.CustomMessage) (messageSendingChannel chan struct{}, err error) {`
`192`	`192`	`return nil, nil`
`193`	`193`	`}`
`194`	`194`
`195`		`-func (m mockOpampClient) RequestConnectionSettings(_ protobufs.ConnectionSettingsRequest) error {`
	`195`	`+func (mockOpampClient) RequestConnectionSettings(protobufs.ConnectionSettingsRequest) error {`
`196`	`196`	`return nil`
`197`	`197`	`}`
`198`	`198`
`@@ -203,15 +203,15 @@ func (m *mockOpampClient) Start(_ context.Context, settings types.StartSettings)`
`203`	`203`	`return nil`
`204`	`204`	`}`
`205`	`205`
`206`		`-func (m *mockOpampClient) Stop(_ context.Context) error {`
	`206`	`+func (*mockOpampClient) Stop(context.Context) error {`
`207`	`207`	`return nil`
`208`	`208`	`}`
`209`	`209`
`210`		`-func (m mockOpampClient) SetAgentDescription(_ protobufs.AgentDescription) error {`
	`210`	`+func (mockOpampClient) SetAgentDescription(protobufs.AgentDescription) error {`
`211`	`211`	`return nil`
`212`	`212`	`}`
`213`	`213`
`214`		`-func (m mockOpampClient) AgentDescription() protobufs.AgentDescription {`
	`214`	`+func (mockOpampClient) AgentDescription() protobufs.AgentDescription {`
`215`	`215`	`return nil`
`216`	`216`	`}`
`217`	`217`
`@@ -240,7 +240,7 @@ func (m mockOpampClient) SetRemoteConfigStatus(status protobufs.RemoteConfigSt`
`240`	`240`	`return nil`
`241`	`241`	`}`
`242`	`242`
`243`		`-func (m mockOpampClient) SetPackageStatuses(_ protobufs.PackageStatuses) error {`
	`243`	`+func (mockOpampClient) SetPackageStatuses(protobufs.PackageStatuses) error {`
`244`	`244`	`return nil`
`245`	`245`	`}`
`246`	`246`
Original file line number	Diff line number	Diff line change
`@@ -157,11 +157,11 @@ func (c *Config) GetAgentScheme() string {`
`157`	`157`	`return uri.Scheme`
`158`	`158`	`}`
`159`	`159`
`160`		`-func (c *Config) GetAgentType() string {`
	`160`	`+func (*Config) GetAgentType() string {`
`161`	`161`	`return agentType`
`162`	`162`	`}`
`163`	`163`
`164`		`-func (c *Config) GetAgentVersion() string {`
	`164`	`+func (*Config) GetAgentVersion() string {`
`165`	`165`	`return agentVersion`
`166`	`166`	`}`
`167`	`167`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ func (a Agent) UpdateStatus(newStatus protobufs.AgentToServer, response *proto`
`128`	`128`	`return agentDescrChanged`
`129`	`129`	`}`
`130`	`130`
`131`		`-func (a Agent) calcConnectionSettings(response protobufs.ServerToAgent) {`
	`131`	`+func (Agent) calcConnectionSettings(response protobufs.ServerToAgent) {`
`132`	`132`	`// Here we can use Agent's description to send the appropriate connection`
`133`	`133`	`// settings to the Agent.`
`134`	`134`	`// In this simple example the connection settings do not depend on the`
Original file line number	Diff line number	Diff line change
`@@ -143,19 +143,19 @@ func TestGetInstanceId(t *testing.T) {`
`143`	`143`	`type mockConnection struct{}`
`144`	`144`
`145`	`145`	`// Connection implements types.Connection.`
`146`		`-func (m *mockConnection) Connection() net.Conn {`
	`146`	`+func (*mockConnection) Connection() net.Conn {`
`147`	`147`	`panic("unimplemented")`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`// Disconnect implements types.Connection.`
`151`		`-func (m *mockConnection) Disconnect() error {`
	`151`	`+func (*mockConnection) Disconnect() error {`
`152`	`152`	`panic("unimplemented")`
`153`	`153`	`}`
`154`	`154`
`155`		`-func (m mockConnection) Send(ctx context.Context, msg protobufs.ServerToAgent) error {`
	`155`	`+func (mockConnection) Send(ctx context.Context, msg protobufs.ServerToAgent) error {`
`156`	`156`	`return nil`
`157`	`157`	`}`
`158`	`158`
`159`		`-func (m *mockConnection) Close() error {`
	`159`	`+func (*mockConnection) Close() error {`
`160`	`160`	`return nil`
`161`	`161`	`}`