[chore]: enable unused-parameter rule from revive (#4790)

Author: mmorel-35

.golangci.yaml

@@ -136,8 +136,6 @@ linters:
           disabled: true # FIXME
         - name: unsecure-url-scheme
           disabled: true
-        - name: unused-parameter
-          disabled: true # FIXME
         - name: use-waitgroup-go
           disabled: true
         - name: var-naming

apis/v1alpha1/instrumentation_webhook.go

@@ -46,31 +46,31 @@ type InstrumentationWebhook struct {
 	scheme *runtime.Scheme
 }
 
-func (w InstrumentationWebhook) Default(ctx context.Context, obj runtime.Object) error {
+func (w InstrumentationWebhook) Default(_ context.Context, obj runtime.Object) error {
 	instrumentation, ok := obj.(*Instrumentation)
 	if !ok {
 		return fmt.Errorf("expected an Instrumentation, received %T", obj)
 	}
 	return w.defaulter(instrumentation)
 }
 
-func (w InstrumentationWebhook) ValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error) {
+func (w InstrumentationWebhook) ValidateCreate(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
 	inst, ok := obj.(*Instrumentation)
 	if !ok {
 		return nil, fmt.Errorf("expected an Instrumentation, received %T", obj)
 	}
 	return w.validate(inst)
 }
 
-func (w InstrumentationWebhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) (admission.Warnings, error) {
+func (w InstrumentationWebhook) ValidateUpdate(_ context.Context, _, newObj runtime.Object) (admission.Warnings, error) {
 	inst, ok := newObj.(*Instrumentation)
 	if !ok {
 		return nil, fmt.Errorf("expected an Instrumentation, received %T", newObj)
 	}
 	return w.validate(inst)
 }
 
-func (w InstrumentationWebhook) ValidateDelete(ctx context.Context, obj runtime.Object) (admission.Warnings, error) {
+func (w InstrumentationWebhook) ValidateDelete(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
 	inst, ok := obj.(*Instrumentation)
 	if !ok || inst == nil {
 		return nil, fmt.Errorf("expected an Instrumentation, received %T", obj)

apis/v1alpha1/opampbridge_webhook.go

@@ -34,31 +34,31 @@ type OpAMPBridgeWebhook struct {
 	scheme *runtime.Scheme
 }
 
-func (o *OpAMPBridgeWebhook) Default(ctx context.Context, obj runtime.Object) error {
+func (o *OpAMPBridgeWebhook) Default(_ context.Context, obj runtime.Object) error {
 	opampBridge, ok := obj.(*OpAMPBridge)
 	if !ok {
 		return fmt.Errorf("expected an OpAMPBridge, received %T", obj)
 	}
 	return o.defaulter(opampBridge)
 }
 
-func (o *OpAMPBridgeWebhook) ValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error) {
+func (o *OpAMPBridgeWebhook) ValidateCreate(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
 	opampBridge, ok := obj.(*OpAMPBridge)
 	if !ok {
 		return nil, fmt.Errorf("expected an OpAMPBridge, received %T", obj)
 	}
 	return o.validate(opampBridge)
 }
 
-func (o *OpAMPBridgeWebhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Object) (admission.Warnings, error) {
+func (o *OpAMPBridgeWebhook) ValidateUpdate(_ context.Context, _, newObj runtime.Object) (admission.Warnings, error) {
 	opampBridge, ok := newObj.(*OpAMPBridge)
 	if !ok {
 		return nil, fmt.Errorf("expected an OpAMPBridge, received %T", newObj)
 	}
 	return o.validate(opampBridge)
 }
 
-func (o *OpAMPBridgeWebhook) ValidateDelete(ctx context.Context, obj runtime.Object) (admission.Warnings, error) {
+func (o *OpAMPBridgeWebhook) ValidateDelete(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
 	opampBridge, ok := obj.(*OpAMPBridge)
 	if !ok || opampBridge == nil {
 		return nil, fmt.Errorf("expected an OpAMPBridge, received %T", obj)

cmd/gather/cluster/cluster_test.go

@@ -80,7 +80,7 @@ func (m *MockClient) RESTMapper() meta.RESTMapper {
 	return args.Get(0).(meta.RESTMapper)
 }
 
-func (*MockClient) GroupVersionKindFor(obj runtime.Object) (schema.GroupVersionKind, error) {
+func (*MockClient) GroupVersionKindFor(runtime.Object) (schema.GroupVersionKind, error) {
 	return schema.GroupVersionKind{}, nil
 }
 

cmd/operator-opamp-bridge/internal/agent/agent.go

@@ -216,17 +216,17 @@ func (agent *Agent) generateCollectorHealth(selectorLabels map[string]string, na
 }
 
 // onConnect is called when an agent is successfully connected to a server.
-func (agent *Agent) onConnect(ctx context.Context) {
+func (agent *Agent) onConnect(context.Context) {
 	agent.logger.V(3).Info("Connected to the server.")
 }
 
 // onConnectFailed is called when an agent was unable to connect to a server.
-func (agent *Agent) onConnectFailed(ctx context.Context, err error) {
+func (agent *Agent) onConnectFailed(_ context.Context, err error) {
 	agent.logger.Error(err, "failed to connect to the server")
 }
 
 // onError is called when an agent receives an error response from the server.
-func (agent *Agent) onError(ctx context.Context, err *protobufs.ServerErrorResponse) {
+func (agent *Agent) onError(_ context.Context, err *protobufs.ServerErrorResponse) {
 	agent.logger.Error(errors.New(err.GetErrorMessage()), "server returned an error response")
 }
 
@@ -340,7 +340,7 @@ func (agent *Agent) updateAgentIdentity(instanceId uuid.UUID) {
 
 // getEffectiveConfig is called when a remote server needs to learn of the current effective configuration of each
 // collector the agent is managing.
-func (agent *Agent) getEffectiveConfig(ctx context.Context) (*protobufs.EffectiveConfig, error) {
+func (agent *Agent) getEffectiveConfig(context.Context) (*protobufs.EffectiveConfig, error) {
 	instances, err := agent.applier.ListInstances()
 	if err != nil {
 		agent.logger.Error(err, "failed to list instances")

cmd/operator-opamp-bridge/internal/logger/logger.go

@@ -21,10 +21,10 @@ func NewLogger(logger logr.Logger) *Logger {
 	return &Logger{Logger: logger}
 }
 
-func (l *Logger) Debugf(ctx context.Context, format string, v ...any) {
+func (l *Logger) Debugf(_ context.Context, format string, v ...any) {
 	l.Logger.V(4).Info(fmt.Sprintf(format, v...))
 }
 
-func (l *Logger) Errorf(ctx context.Context, format string, v ...any) {
+func (l *Logger) Errorf(_ context.Context, format string, v ...any) {
 	l.Logger.V(0).Error(nil, fmt.Sprintf(format, v...))
 }

cmd/operator-opamp-bridge/internal/proxy/server.go

@@ -68,7 +68,7 @@ func (s *OpAMPProxy) Start() error {
 		Settings: server.Settings{
 			CustomCapabilities: []string{},
 			Callbacks: server.CallbacksStruct{
-				OnConnectingFunc: func(request *http.Request) types.ConnectionResponse {
+				OnConnectingFunc: func(*http.Request) types.ConnectionResponse {
 					return types.ConnectionResponse{
 						Accept: true,
 						ConnectionCallbacks: server.ConnectionCallbacksStruct{
@@ -115,7 +115,7 @@ func (s *OpAMPProxy) onDisconnect(conn types.Connection) {
 	s.updatesChan <- struct{}{}
 }
 
-func (s *OpAMPProxy) onMessage(ctx context.Context, conn types.Connection, msg *protobufs.AgentToServer) *protobufs.ServerToAgent {
+func (s *OpAMPProxy) onMessage(_ context.Context, conn types.Connection, msg *protobufs.AgentToServer) *protobufs.ServerToAgent {
 	// Start building the response.
 	response := &protobufs.ServerToAgent{}
 

cmd/operator-opamp-bridge/internal/proxy/server_test.go

@@ -152,7 +152,7 @@ func (*mockConnection) Disconnect() error {
 	panic("unimplemented")
 }
 
-func (*mockConnection) Send(ctx context.Context, msg *protobufs.ServerToAgent) error {
+func (*mockConnection) Send(context.Context, *protobufs.ServerToAgent) error {
 	return nil
 }
 

cmd/otel-allocator/internal/allocation/consistent_hashing.go

@@ -72,4 +72,4 @@ func (s *consistentHashingStrategy) SetCollectors(collectors map[string]*Collect
 	s.consistentHasher = consistent.New(members, s.config)
 }
 
-func (*consistentHashingStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
+func (*consistentHashingStrategy) SetFallbackStrategy(Strategy) {}

cmd/otel-allocator/internal/allocation/least_weighted.go

@@ -55,4 +55,4 @@ func (*leastWeightedStrategy) GetCollectorForTarget(collectors map[string]*Colle
 
 func (*leastWeightedStrategy) SetCollectors(map[string]*Collector) {}
 
-func (*leastWeightedStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}
+func (*leastWeightedStrategy) SetFallbackStrategy(Strategy) {}