[chore](cmd): fix gofumpt issues part 1

#### Description

fix gofumpt issues in cmd/otel-allocator/internal/config

---
This commit was automatically created by review-helper.
Changes are split into focused commits grouped by directory to simplify the review process.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Author: mmorel-35

cmd/gather/cluster/cluster.go

@@ -44,6 +44,7 @@ func NewCluster(cfg *config.Config) Cluster {
 		apiAvailabilityCache: make(map[schema.GroupVersionResource]bool),
 	}
 }
+
 func (c *Cluster) getOperatorNamespace() (string, error) {
 	if c.config.OperatorNamespace != "" {
 		return c.config.OperatorNamespace, nil
@@ -67,7 +68,6 @@ func (c *Cluster) getOperatorDeployment() (appsv1.Deployment, error) {
 			"app.kubernetes.io/name": "opentelemetry-operator",
 		}),
 	})
-
 	if err != nil {
 		return appsv1.Deployment{}, err
 	}

cmd/operator-opamp-bridge/internal/agent/agent_test.go

@@ -92,7 +92,8 @@ var (
 					Phase:     v1.PodRunning,
 				},
 			},
-		}}
+		},
+	}
 	mockPodListUnhealthy = &v1.PodList{
 		TypeMeta: metav1.TypeMeta{
 			Kind:       "PodList",
@@ -117,7 +118,8 @@ var (
 					Phase:     v1.PodRunning,
 				},
 			},
-		}}
+		},
+	}
 )
 
 func getConfigHash(key, file string) string {
@@ -130,8 +132,10 @@ func getConfigHash(key, file string) string {
 	return fmt.Sprintf("%s%d", key, size)
 }
 
-var _ client.OpAMPClient = &mockOpampClient{}
-var _ proxy.Server = newMockProxy(nil, nil, nil)
+var (
+	_ client.OpAMPClient = &mockOpampClient{}
+	_ proxy.Server       = newMockProxy(nil, nil, nil)
+)
 
 func newMockProxy(configs map[uuid.UUID]*protobufs.EffectiveConfig, healths map[uuid.UUID]*protobufs.ComponentHealth, agentsByHostname map[string]uuid.UUID) *mockProxy {
 	return &mockProxy{

cmd/operator-opamp-bridge/internal/agent/kube_resource_key.go

@@ -14,7 +14,7 @@ type kubeResourceKey struct {
 	namespace string
 }
 
-func newKubeResourceKey(namespace string, name string) kubeResourceKey {
+func newKubeResourceKey(namespace, name string) kubeResourceKey {
 	return kubeResourceKey{name: name, namespace: namespace}
 }
 

cmd/operator-opamp-bridge/internal/config/config.go

@@ -194,7 +194,7 @@ func (ad *AgentDescription) nonIdentifyingAttributes() []*protobufs.KeyValue {
 	return toReturn
 }
 
-func keyValuePair(key string, value string) *protobufs.KeyValue {
+func keyValuePair(key, value string) *protobufs.KeyValue {
 	return &protobufs.KeyValue{
 		Key: key,
 		Value: &protobufs.AnyValue{

cmd/operator-opamp-bridge/internal/config/flags.go

@@ -27,9 +27,7 @@ const (
 	defaultHeartbeatInterval  = 30 * time.Second
 )
 
-var (
-	defaultKubeConfigPath = filepath.Join(homedir.HomeDir(), ".kube", "config")
-)
+var defaultKubeConfigPath = filepath.Join(homedir.HomeDir(), ".kube", "config")
 
 // We can't bind this flag to our FlagSet, so we need to handle it separately.
 var zapCmdLineOpts zap.Options
@@ -71,7 +69,7 @@ func getFlagValueAndChanged[T any](flagSet *pflag.FlagSet, flagName string) (val
 	var zero T
 	if changed = flagSet.Changed(flagName); !changed {
 		value, err = zero, nil
-		return
+		return value, changed, err
 	}
 	switch any(zero).(type) {
 	case string:
@@ -85,5 +83,5 @@ func getFlagValueAndChanged[T any](flagSet *pflag.FlagSet, flagName string) (val
 	default:
 		err = fmt.Errorf("unsupported flag type %T", zero)
 	}
-	return
+	return value, changed, err
 }

cmd/operator-opamp-bridge/internal/metrics/reporter.go

@@ -43,7 +43,7 @@ type MetricReporter struct {
 // NewMetricReporter creates an OTLP/HTTP client to the destination address supplied by the server.
 // TODO: do more validation on the endpoint, allow for gRPC.
 // TODO: set global provider and add more metrics to be reported.
-func NewMetricReporter(logger logr.Logger, dest *protobufs.TelemetryConnectionSettings, agentType string, agentVersion string, instanceId uuid.UUID) (*MetricReporter, error) {
+func NewMetricReporter(logger logr.Logger, dest *protobufs.TelemetryConnectionSettings, agentType, agentVersion string, instanceId uuid.UUID) (*MetricReporter, error) {
 	if dest.DestinationEndpoint == "" {
 		return nil, errors.New("metric destination must specify DestinationEndpoint")
 	}

cmd/operator-opamp-bridge/internal/operator/client.go

@@ -30,16 +30,16 @@ const (
 
 type ConfigApplier interface {
 	// Apply receives a name and namespace to apply an OpenTelemetryCollector CRD that is contained in the configmap.
-	Apply(name string, namespace string, configmap *protobufs.AgentConfigFile) error
+	Apply(name, namespace string, configmap *protobufs.AgentConfigFile) error
 
 	// Delete attempts to delete an OpenTelemetryCollector object given a name and namespace.
-	Delete(name string, namespace string) error
+	Delete(name, namespace string) error
 
 	// ListInstances retrieves all OpenTelemetryCollector CRDs created by the operator-opamp-bridge agent.
 	ListInstances() ([]v1beta1.OpenTelemetryCollector, error)
 
 	// GetInstance retrieves an OpenTelemetryCollector CRD given a name and namespace.
-	GetInstance(name string, namespace string) (*v1beta1.OpenTelemetryCollector, error)
+	GetInstance(name, namespace string) (*v1beta1.OpenTelemetryCollector, error)
 
 	// GetCollectorPods retrieves all pods that match the given collector's selector labels and namespace.
 	GetCollectorPods(selectorLabels map[string]string, namespace string) (*v1.PodList, error)
@@ -65,7 +65,7 @@ func NewClient(name string, log logr.Logger, c client.Client, componentsAllowed
 	}
 }
 
-func (c Client) Apply(name string, namespace string, configmap *protobufs.AgentConfigFile) error {
+func (c Client) Apply(name, namespace string, configmap *protobufs.AgentConfigFile) error {
 	c.log.Info("Received new config", "name", name, "namespace", namespace)
 
 	if len(configmap.Body) == 0 {
@@ -166,7 +166,7 @@ func labelSetContainsLabel(resourceLabelSet map[string]string, label, value stri
 	return strings.EqualFold(resourceLabelSet[label], value)
 }
 
-func (c Client) create(ctx context.Context, name string, namespace string, collector *v1beta1.OpenTelemetryCollector) error {
+func (c Client) create(ctx context.Context, name, namespace string, collector *v1beta1.OpenTelemetryCollector) error {
 	// Set the defaults
 	setTypedMeta(collector)
 	collector.Name = name
@@ -181,15 +181,15 @@ func (c Client) create(ctx context.Context, name string, namespace string, colle
 	return c.k8sClient.Create(ctx, collector)
 }
 
-func (c Client) update(ctx context.Context, old *v1beta1.OpenTelemetryCollector, new *v1beta1.OpenTelemetryCollector) error {
+func (c Client) update(ctx context.Context, old, new *v1beta1.OpenTelemetryCollector) error {
 	new.ObjectMeta = old.ObjectMeta
 	new.TypeMeta = old.TypeMeta
 
 	c.log.Info("Updating collector")
 	return c.k8sClient.Update(ctx, new)
 }
 
-func (c Client) Delete(name string, namespace string) error {
+func (c Client) Delete(name, namespace string) error {
 	ctx := context.Background()
 	result := v1beta1.OpenTelemetryCollector{}
 	err := c.k8sClient.Get(ctx, client.ObjectKey{
@@ -240,7 +240,7 @@ func (c Client) ListInstances() ([]v1beta1.OpenTelemetryCollector, error) {
 	return instances, nil
 }
 
-func (c Client) GetInstance(name string, namespace string) (*v1beta1.OpenTelemetryCollector, error) {
+func (c Client) GetInstance(name, namespace string) (*v1beta1.OpenTelemetryCollector, error) {
 	ctx := context.Background()
 	result := v1beta1.OpenTelemetryCollector{}
 

cmd/operator-opamp-bridge/internal/operator/client_test.go

@@ -24,9 +24,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-operator/apis/v1beta1"
 )
 
-var (
-	clientLogger = logr.Discard()
-)
+var clientLogger = logr.Discard()
 
 const (
 	bridgeName = "bridge-test"
@@ -285,9 +283,11 @@ func TestClient_GetCollectorPods(t *testing.T) {
 				},
 				Spec: v1.PodSpec{},
 			},
-		}}
+		},
+	}
 	emptyList := &v1.PodList{
-		Items: []v1.Pod{}}
+		Items: []v1.Pod{},
+	}
 	type args struct {
 		selector  map[string]string
 		namespace string

cmd/otel-allocator/internal/allocation/allocator.go

@@ -162,7 +162,7 @@ func (a *allocator) SetCollectors(collectors map[string]*Collector) {
 	}
 }
 
-func (a *allocator) GetTargetsForCollectorAndJob(collector string, job string) []*target.Item {
+func (a *allocator) GetTargetsForCollectorAndJob(collector, job string) []*target.Item {
 	a.m.RLock()
 	defer a.m.RUnlock()
 	if _, ok := a.targetItemsPerJobPerCollector[collector]; !ok {

cmd/otel-allocator/internal/allocation/consistent_hashing_test.go

@@ -13,7 +13,7 @@ func TestRelativelyEvenDistribution(t *testing.T) {
 	numCols := 15
 	numItems := 10000
 	cols := MakeNCollectors(numCols, 0)
-	var expectedPerCollector = float64(numItems / numCols)
+	expectedPerCollector := float64(numItems / numCols)
 	expectedDelta := (expectedPerCollector * 1.5) - expectedPerCollector
 	c, _ := New("consistent-hashing", logger)
 	c.SetCollectors(cols)
@@ -106,7 +106,7 @@ func TestTargetsWithNoCollectorsConsistentHashing(t *testing.T) {
 	numCols := 2
 	cols := MakeNCollectors(2, 0)
 	c.SetCollectors(cols)
-	var expectedPerCollector = float64(numItemsUpdate / numCols)
+	expectedPerCollector := float64(numItemsUpdate / numCols)
 	expectedDelta := (expectedPerCollector * 1.5) - expectedPerCollector
 	// Checking to see that there is no change to number of targets
 	actualTargetItems = c.TargetItems()