[chore]: enable empty-lines rule from revive (#4783)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Author: mmorel-35

.golangci.yaml

@@ -84,8 +84,6 @@ linters:
           disabled: true # FIXME
         - name: empty-block
           disabled: true
-        - name: empty-lines
-          disabled: true # FIXME
         - name: enforce-switch-style
           disabled: true # FIXME
         - name: error-naming
@@ -180,6 +178,7 @@ linters:
     - staticcheck
     - unparam
     - unused
+    - whitespace
   exclusions:
     generated: lax
     presets:

apis/v1alpha1/opampbridge_webhook_test.go

@@ -112,7 +112,6 @@ func TestOpAMPBridgeDefaultingWebhook(t *testing.T) {
 }
 
 func TestOpAMPBridgeValidatingWebhook(t *testing.T) {
-
 	two := int32(2)
 
 	tests := []struct {

apis/v1beta1/metrics.go

@@ -137,7 +137,6 @@ func (m *Metrics) update(ctx context.Context, oldCollector *OpenTelemetryCollect
 }
 
 func (m *Metrics) updateGeneralCRMetricsComponents(ctx context.Context, collector *OpenTelemetryCollector, up bool) {
-
 	inc := 1
 	if !up {
 		inc = -1
@@ -155,7 +154,6 @@ func (m *Metrics) updateComponentCounters(ctx context.Context, collector *OpenTe
 	moveCounter(ctx, collector, components.processors, m.processorCounter, up)
 	moveCounter(ctx, collector, components.extensions, m.extensionsCounter, up)
 	moveCounter(ctx, collector, components.connectors, m.connectorsCounter, up)
-
 }
 
 func extractElements(elements map[string]any) []string {
@@ -178,7 +176,6 @@ func extractElements(elements map[string]any) []string {
 }
 
 func getComponentsFromConfig(yamlContent Config) *componentDefinitions {
-
 	info := &componentDefinitions{
 		receivers: extractElements(yamlContent.Receivers.Object),
 		exporters: extractElements(yamlContent.Exporters.Object),

apis/v1beta1/metrics_test.go

@@ -25,7 +25,6 @@ var wantInstrumentationScope = instrumentation.Scope{
 }
 
 func TestOTELCollectorCRDMetrics(t *testing.T) {
-
 	otelcollector1 := &OpenTelemetryCollector{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "collector1",
@@ -527,7 +526,6 @@ func checkCreate(t *testing.T, m *Metrics, collectors []*OpenTelemetryCollector,
 }
 
 func checkUpdate(t *testing.T, m *Metrics, collectors []*OpenTelemetryCollector, reader metric.Reader) {
-
 	m.update(context.Background(), collectors[0], collectors[2])
 
 	rm := metricdata.ResourceMetrics{}

cmd/gather/cluster/cluster.go

@@ -77,7 +77,6 @@ func (c *Cluster) getOperatorDeployment() (appsv1.Deployment, error) {
 	}
 
 	return operatorDeployments.Items[0], nil
-
 }
 
 func (c *Cluster) GetOperatorLogs() error {
@@ -157,7 +156,6 @@ func (c *Cluster) GetOLMInfo() error {
 	}
 	for _, o := range operators.Items {
 		writeToFile(outputDir, &o)
-
 	}
 
 	// OperatorGroups
@@ -184,7 +182,6 @@ func (c *Cluster) GetOLMInfo() error {
 	}
 	for _, o := range subscriptions.Items {
 		writeToFile(outputDir, &o)
-
 	}
 
 	// InstallPlan
@@ -386,7 +383,6 @@ func (c *Cluster) getOwnerResources(objList client.ObjectList, owner any) ([]cli
 		}
 	}
 	return resources, nil
-
 }
 
 func (c *Cluster) processResourceType(list client.ObjectList, owner any, folder string) error {

cmd/gather/cluster/cluster_test.go

@@ -125,7 +125,6 @@ func TestGetOperatorNamespace(t *testing.T) {
 }
 
 func TestGetOperatorDeployment(t *testing.T) {
-
 	mockClient := new(MockClient)
 	cfg := &config.Config{
 		KubernetesClient: mockClient,
@@ -151,7 +150,6 @@ func TestGetOperatorDeployment(t *testing.T) {
 }
 
 func TestGetOperatorDeploymentNotFound(t *testing.T) {
-
 	mockClient := new(MockClient)
 	cfg := &config.Config{
 		KubernetesClient: mockClient,

cmd/operator-opamp-bridge/internal/metrics/reporter.go

@@ -44,7 +44,6 @@ type MetricReporter struct {
 // TODO: do more validation on the endpoint, allow for gRPC.
 // TODO: set global provider and add more metrics to be reported.
 func NewMetricReporter(logger logr.Logger, dest *protobufs.TelemetryConnectionSettings, agentType string, agentVersion string, instanceId uuid.UUID) (*MetricReporter, error) {
-
 	if dest.DestinationEndpoint == "" {
 		return nil, errors.New("metric destination must specify DestinationEndpoint")
 	}

cmd/otel-allocator/benchmark_test.go

@@ -92,7 +92,6 @@ func BenchmarkProcessTargetsWithRelabelConfig(b *testing.B) {
 			})
 		}
 	}
-
 }
 
 func prepareBenchmarkData(numTargets, targetsPerGroup, groupsPerJob int) map[string][]*targetgroup.Group {

cmd/otel-allocator/internal/allocation/allocator_test.go

@@ -162,7 +162,6 @@ func TestAddingAndRemovingCollectors(t *testing.T) {
 // Tests that two targets with the same target url and job name but different label set are both added.
 func TestAllocationCollision(t *testing.T) {
 	RunForAllStrategies(t, func(t *testing.T, allocator Allocator) {
-
 		cols := MakeNCollectors(3, 0)
 		allocator.SetCollectors(cols)
 		firstLabels := labels.New(labels.Label{Name: "test", Value: "test1"})

cmd/otel-allocator/internal/allocation/consistent_hashing.go

@@ -70,7 +70,6 @@ func (s *consistentHashingStrategy) SetCollectors(collectors map[string]*Collect
 	}
 
 	s.consistentHasher = consistent.New(members, s.config)
-
 }
 
 func (s *consistentHashingStrategy) SetFallbackStrategy(fallbackStrategy Strategy) {}