[chore]: enable emptyStringTest issues from gocritic (#4834)

mmorel-35 · web-flow · commit 91deeae6c90f · 2026-03-09T21:37:00.000Z
Signed-off-by: Matthieu MOREL &lt;matthieu.morel35@gmail.com&gt;
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -29,7 +29,6 @@ linters:
         - commentedOutCode
         - deferInLoop
         - emptyFallthrough
-        - emptyStringTest
         - exitAfterDefer
         - hugeParam
         - importShadow
diff --git a/apis/v1alpha1/opampbridge_webhook.go b/apis/v1alpha1/opampbridge_webhook.go
@@ -94,7 +94,7 @@ func (*OpAMPBridgeWebhook) validate(r *OpAMPBridge) (admission.Warnings, error)
 	warnings := admission.Warnings{}
 
 	// validate OpAMP server endpoint
-	if len(strings.TrimSpace(r.Spec.Endpoint)) == 0 {
+	if strings.TrimSpace(r.Spec.Endpoint) == "" {
 		return warnings, errors.New("the OpAMP server endpoint is not specified")
 	}
 
diff --git a/apis/v1alpha1/targetallocator_webhook.go b/apis/v1alpha1/targetallocator_webhook.go
@@ -115,7 +115,7 @@ func (w TargetAllocatorWebhook) validate(ctx context.Context, ta *TargetAllocato
 	// if the prometheusCR is enabled, it needs a suite of permissions to function
 	if ta.Spec.PrometheusCR.Enabled {
 		saname := ta.Spec.ServiceAccount
-		if len(ta.Spec.ServiceAccount) == 0 {
+		if ta.Spec.ServiceAccount == "" {
 			saname = naming.TargetAllocatorServiceAccount(ta.Name)
 		}
 		warnings, err := v1beta1.CheckTargetAllocatorPrometheusCRPolicyRules(ctx, w.reviewer, ta.GetNamespace(), saname)
diff --git a/apis/v1beta1/collector_webhook.go b/apis/v1beta1/collector_webhook.go
@@ -359,7 +359,7 @@ func (c CollectorWebhook) validateTargetAllocatorConfig(ctx context.Context, r *
 	// if the prometheusCR is enabled, it needs a suite of permissions to function
 	if r.Spec.TargetAllocator.PrometheusCR.Enabled {
 		saname := r.Spec.TargetAllocator.ServiceAccount
-		if len(r.Spec.TargetAllocator.ServiceAccount) == 0 {
+		if r.Spec.TargetAllocator.ServiceAccount == "" {
 			saname = naming.TargetAllocatorServiceAccount(r.Name)
 		}
 		warnings, err := CheckTargetAllocatorPrometheusCRPolicyRules(
diff --git a/cmd/operator-opamp-bridge/internal/agent/agent.go b/cmd/operator-opamp-bridge/internal/agent/agent.go
@@ -159,7 +159,7 @@ func (agent *Agent) generateCollectorPoolHealth() (map[string]*protobufs.Compone
 
 // getCollectorSelector destructures the collectors scale selector if present, it uses the labelmap from the operator.
 func (*Agent) getCollectorSelector(col v1beta1.OpenTelemetryCollector) map[string]string {
-	if len(col.Status.Scale.Selector) > 0 {
+	if col.Status.Scale.Selector != "" {
 		selMap := map[string]string{}
 		for kvPair := range strings.SplitSeq(col.Status.Scale.Selector, ",") {
 			kv := strings.Split(kvPair, "=")
@@ -401,7 +401,7 @@ func (agent *Agent) applyRemoteConfig(config *protobufs.AgentRemoteConfig) (*pro
 	var errs []error
 	// Apply changes from the received config map
 	for key, file := range config.Config.GetConfigMap() {
-		if len(key) == 0 || len(file.Body) == 0 {
+		if key == "" || len(file.Body) == 0 {
 			continue
 		}
 		colKey, err := kubeResourceFromKey(key)
diff --git a/cmd/operator-opamp-bridge/internal/operator/client_test.go b/cmd/operator-opamp-bridge/internal/operator/client_test.go
@@ -124,7 +124,7 @@ func TestClient_Apply(t *testing.T) {
 			c := NewClient(bridgeName, clientLogger, fakeClient, nil)
 			var colConfig []byte
 			var err error
-			if len(tt.args.file) > 0 {
+			if tt.args.file != "" {
 				colConfig, err = loadConfig(tt.args.file)
 				require.NoError(t, err, "Should be no error on loading test configuration")
 			} else {
diff --git a/cmd/operator-opamp-bridge/internal/proxy/server.go b/cmd/operator-opamp-bridge/internal/proxy/server.go
@@ -105,7 +105,7 @@ func (s *OpAMPProxy) onDisconnect(conn types.Connection) {
 	defer s.mux.Unlock()
 
 	for instanceId := range s.connections[conn] {
-		if hostName := s.agentsById[instanceId].GetHostname(); len(hostName) > 0 {
+		if hostName := s.agentsById[instanceId].GetHostname(); hostName != "" {
 			delete(s.agentsByHostName, hostName)
 		}
 		delete(s.agentsById, instanceId)
@@ -141,7 +141,7 @@ func (s *OpAMPProxy) onMessage(_ context.Context, conn types.Connection, msg *pr
 		agentUpdated = true
 	}
 	agentUpdated = s.agentsById[instanceId].UpdateStatus(msg, response) || agentUpdated
-	if hostName := s.agentsById[instanceId].GetHostname(); len(hostName) > 0 {
+	if hostName := s.agentsById[instanceId].GetHostname(); hostName != "" {
 		s.agentsByHostName[hostName] = instanceId
 	}
 	s.mux.Unlock()
diff --git a/cmd/otel-allocator/internal/server/server_test.go b/cmd/otel-allocator/internal/server/server_test.go
@@ -165,7 +165,7 @@ func TestServer_TargetsHandler(t *testing.T) {
 			body := result.Body
 			bodyBytes, err := io.ReadAll(body)
 			assert.NoError(t, err)
-			if len(tt.want.errString) != 0 {
+			if tt.want.errString != "" {
 				assert.EqualError(t, err, tt.want.errString)
 				return
 			}
diff --git a/internal/components/builder.go b/internal/components/builder.go
@@ -145,7 +145,7 @@ func (b Builder[ComponentConfigType]) WithDefaultsApplier(defaultsApplier Defaul
 func (b Builder[ComponentConfigType]) Build() (*GenericParser[ComponentConfigType], error) {
 	o := NewEmptySettings[ComponentConfigType]()
 	o.Apply(b...)
-	if len(o.name) == 0 {
+	if o.name == "" {
 		return nil, errors.New("invalid settings struct, no name specified")
 	}
 	return &GenericParser[ComponentConfigType]{
diff --git a/internal/components/extensions/healthcheckv1.go b/internal/components/extensions/healthcheckv1.go
@@ -51,7 +51,7 @@ func healthCheckV1Probe(logger logr.Logger, config healthcheckV1Config) (*corev1
 	// but since the function runs only when manifests are deployed,
 	// we must keep these runtime defaults for backward compatibility.
 	path := config.Path
-	if len(path) == 0 {
+	if path == "" {
 		path = defaultHealthcheckV1Path
 	}
 	return &corev1.Probe{
diff --git a/internal/components/extensions/jaeger_query_extension.go b/internal/components/extensions/jaeger_query_extension.go
@@ -42,7 +42,7 @@ func (g *JaegerQueryExtensionConfig) GetPortNumOrDefault(logger logr.Logger, p i
 // GetPortNum attempts to get the port for the given config. If it cannot, the UnsetPort and the given missingPortError
 // are returned.
 func (g *JaegerQueryExtensionConfig) GetPortNum() (int32, error) {
-	if len(g.HTTP.Endpoint) > 0 {
+	if g.HTTP.Endpoint != "" {
 		return components.PortFromEndpoint(g.HTTP.Endpoint)
 	}
 	return components.UnsetPort, components.PortNotFoundErr
diff --git a/internal/components/single_endpoint.go b/internal/components/single_endpoint.go
@@ -43,9 +43,9 @@ func (g *SingleEndpointConfig) GetPortNumOrDefault(logger logr.Logger, p int32)
 // GetPortNum attempts to get the port for the given config. If it cannot, the UnsetPort and the given missingPortError
 // are returned.
 func (g *SingleEndpointConfig) GetPortNum() (int32, error) {
-	if len(g.Endpoint) > 0 {
+	if g.Endpoint != "" {
 		return PortFromEndpoint(g.Endpoint)
-	} else if len(g.ListenAddress) > 0 {
+	} else if g.ListenAddress != "" {
 		return PortFromEndpoint(g.ListenAddress)
 	}
 	return UnsetPort, PortNotFoundErr
diff --git a/internal/controllers/suite_test.go b/internal/controllers/suite_test.go
@@ -331,7 +331,7 @@ func testCollectorWithModeAndReplicas(t *testing.T, name string, mode v1beta1.Mo
 func testCollectorAssertNoErr(t *testing.T, name, taContainerImage, file string) v1beta1.OpenTelemetryCollector {
 	p, err := testCollectorWithConfigFile(name, taContainerImage, file)
 	assert.NoError(t, err)
-	if len(taContainerImage) == 0 {
+	if taContainerImage == "" {
 		p.Spec.TargetAllocator.Enabled = false
 	}
 	return p
diff --git a/internal/instrumentation/annotation.go b/internal/instrumentation/annotation.go
@@ -42,12 +42,12 @@ func annotationValue(ns, pod metav1.ObjectMeta, annotation string) string {
 	nsAnnValue := ns.Annotations[annotation]
 
 	// if the namespace value is empty, the pod annotation should be used, whatever it is
-	if len(nsAnnValue) == 0 {
+	if nsAnnValue == "" {
 		return podAnnValue
 	}
 
 	// if the pod value is empty, the annotation should be used (true, false, instance)
-	if len(podAnnValue) == 0 {
+	if podAnnValue == "" {
 		return nsAnnValue
 	}
 
diff --git a/internal/instrumentation/apachehttpd.go b/internal/instrumentation/apachehttpd.go
@@ -202,9 +202,9 @@ LoadModule otel_apache_module %[1]s/WebServerModule/Apache/libmod_apache_otel%[2
 	}
 	serviceName := chooseServiceName(pod, useLabelsForResourceAttributes, resourceMap, container)
 	serviceNamespace := pod.GetNamespace()
-	if len(serviceNamespace) == 0 {
+	if serviceNamespace == "" {
 		serviceNamespace = resourceMap[string(semconv.K8SNamespaceNameKey)]
-		if len(serviceNamespace) == 0 {
+		if serviceNamespace == "" {
 			serviceNamespace = "apache-httpd"
 		}
 	}
diff --git a/internal/instrumentation/nginx.go b/internal/instrumentation/nginx.go
@@ -262,9 +262,9 @@ func getNginxOtelConfig(pod corev1.Pod, useLabelsForResourceAttributes bool, ngi
 	}
 	serviceName := chooseServiceName(pod, useLabelsForResourceAttributes, resourceMap, container)
 	serviceNamespace := pod.GetNamespace()
-	if len(serviceNamespace) == 0 {
+	if serviceNamespace == "" {
 		serviceNamespace = resourceMap[string(semconv.K8SNamespaceNameKey)]
-		if len(serviceNamespace) == 0 {
+		if serviceNamespace == "" {
 			serviceNamespace = "nginx"
 		}
 	}
diff --git a/internal/instrumentation/podmutator.go b/internal/instrumentation/podmutator.go
@@ -361,7 +361,7 @@ func (pm *instPodMutator) Mutate(ctx context.Context, ns corev1.Namespace, pod c
 func (pm *instPodMutator) getInstrumentationInstance(ctx context.Context, ns corev1.Namespace, pod corev1.Pod, instAnnotation string) (*v1alpha1.Instrumentation, error) {
 	instValue := annotationValue(ns.ObjectMeta, pod.ObjectMeta, instAnnotation)
 
-	if len(instValue) == 0 || strings.EqualFold(instValue, "false") {
+	if instValue == "" || strings.EqualFold(instValue, "false") {
 		return nil, nil
 	}
 
diff --git a/internal/manifests/collector/container.go b/internal/manifests/collector/container.go
@@ -29,7 +29,7 @@ const maxPortLen = 15
 // Container builds a container for the given collector.
 func Container(cfg config.Config, logger logr.Logger, otelcol v1beta1.OpenTelemetryCollector, addConfig bool) corev1.Container {
 	image := otelcol.Spec.Image
-	if len(image) == 0 {
+	if image == "" {
 		image = cfg.CollectorImage
 	}
 
diff --git a/internal/manifests/collector/serviceaccount.go b/internal/manifests/collector/serviceaccount.go
@@ -15,7 +15,7 @@ import (
 
 // ServiceAccountName returns the name of the existing or self-provisioned service account to use for the given instance.
 func ServiceAccountName(instance v1beta1.OpenTelemetryCollector) string {
-	if len(instance.Spec.ServiceAccount) == 0 {
+	if instance.Spec.ServiceAccount == "" {
 		return naming.ServiceAccount(instance.Name)
 	}
 
diff --git a/internal/manifests/opampbridge/configmap.go b/internal/manifests/opampbridge/configmap.go
@@ -23,7 +23,7 @@ func ConfigMap(params manifests.Params) (*corev1.ConfigMap, error) {
 
 	config := make(map[any]any)
 
-	if len(params.OpAMPBridge.Spec.Endpoint) > 0 {
+	if params.OpAMPBridge.Spec.Endpoint != "" {
 		config["endpoint"] = params.OpAMPBridge.Spec.Endpoint
 	}
 
diff --git a/internal/manifests/opampbridge/container.go b/internal/manifests/opampbridge/container.go
@@ -17,7 +17,7 @@ import (
 // Container builds a container for the given OpAMPBridge.
 func Container(cfg config.Config, _ logr.Logger, opampBridge v1alpha1.OpAMPBridge) corev1.Container {
 	image := opampBridge.Spec.Image
-	if len(image) == 0 {
+	if image == "" {
 		image = cfg.OperatorOpAMPBridgeImage
 	}
 
diff --git a/internal/manifests/opampbridge/serviceaccount.go b/internal/manifests/opampbridge/serviceaccount.go
@@ -15,7 +15,7 @@ import (
 
 // ServiceAccountName returns the name of the existing or self-provisioned service account to use for the given instance.
 func ServiceAccountName(instance v1alpha1.OpAMPBridge) string {
-	if len(instance.Spec.ServiceAccount) == 0 {
+	if instance.Spec.ServiceAccount == "" {
 		return naming.OpAMPBridgeServiceAccount(instance.Name)
 	}
 	return instance.Spec.ServiceAccount
diff --git a/internal/manifests/targetallocator/container.go b/internal/manifests/targetallocator/container.go
@@ -23,7 +23,7 @@ import (
 // Container builds a container for the given TargetAllocator.
 func Container(cfg config.Config, _ logr.Logger, instance v1alpha1.TargetAllocator) corev1.Container {
 	image := instance.Spec.Image
-	if len(image) == 0 {
+	if image == "" {
 		image = cfg.TargetAllocatorImage
 	}
 
diff --git a/internal/manifests/targetallocator/serviceaccount.go b/internal/manifests/targetallocator/serviceaccount.go
@@ -14,7 +14,7 @@ import (
 
 // ServiceAccountName returns the name of the existing or self-provisioned service account to use for the given instance.
 func ServiceAccountName(instance v1alpha1.TargetAllocator) string {
-	if len(instance.Spec.ServiceAccount) == 0 {
+	if instance.Spec.ServiceAccount == "" {
 		return naming.TargetAllocatorServiceAccount(instance.Name)
 	}
 
@@ -23,7 +23,7 @@ func ServiceAccountName(instance v1alpha1.TargetAllocator) string {
 
 // ServiceAccount returns the service account for the given instance.
 func ServiceAccount(params Params) *corev1.ServiceAccount {
-	if len(params.TargetAllocator.Spec.ServiceAccount) > 0 {
+	if params.TargetAllocator.Spec.ServiceAccount != "" {
 		return nil
 	}
 	name := naming.TargetAllocatorServiceAccount(params.TargetAllocator.Name)
diff --git a/internal/rbac/format.go b/internal/rbac/format.go
@@ -19,7 +19,7 @@ func WarningsGroupedByResource(reviews []*v1.SubjectAccessReview) []string {
 		}
 		if review.Spec.ResourceAttributes != nil {
 			key := fmt.Sprintf("%s/%s", review.Spec.ResourceAttributes.Group, review.Spec.ResourceAttributes.Resource)
-			if len(review.Spec.ResourceAttributes.Group) == 0 {
+			if review.Spec.ResourceAttributes.Group == "" {
 				key = review.Spec.ResourceAttributes.Resource
 			}
 			userFullResourceToVerbs[review.Spec.User][key] = append(userFullResourceToVerbs[review.Spec.User][key], review.Spec.ResourceAttributes.Verb)
diff --git a/internal/version/main.go b/internal/version/main.go
@@ -81,7 +81,7 @@ func (v Version) String() string {
 
 // OpenTelemetryCollector returns the default OpenTelemetryCollector to use when no versions are specified via CLI or configuration.
 func OpenTelemetryCollector() string {
-	if len(otelCol) > 0 {
+	if otelCol != "" {
 		// this should always be set, as it's specified during the build
 		return otelCol
 	}
@@ -92,7 +92,7 @@ func OpenTelemetryCollector() string {
 
 // TargetAllocator returns the default TargetAllocator to use when no versions are specified via CLI or configuration.
 func TargetAllocator() string {
-	if len(targetAllocator) > 0 {
+	if targetAllocator != "" {
 		// this should always be set, as it's specified during the build
 		return targetAllocator
 	}
@@ -103,7 +103,7 @@ func TargetAllocator() string {
 
 // OperatorOpAMPBridge returns the default OperatorOpAMPBridge to use when no versions are specified via CLI or configuration.
 func OperatorOpAMPBridge() string {
-	if len(operatorOpAMPBridge) > 0 {
+	if operatorOpAMPBridge != "" {
 		// this should always be set, as it's specified during the build
 		return operatorOpAMPBridge
 	}
@@ -113,49 +113,49 @@ func OperatorOpAMPBridge() string {
 }
 
 func AutoInstrumentationJava() string {
-	if len(autoInstrumentationJava) > 0 {
+	if autoInstrumentationJava != "" {
 		return autoInstrumentationJava
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationNodeJS() string {
-	if len(autoInstrumentationNodeJS) > 0 {
+	if autoInstrumentationNodeJS != "" {
 		return autoInstrumentationNodeJS
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationPython() string {
-	if len(autoInstrumentationPython) > 0 {
+	if autoInstrumentationPython != "" {
 		return autoInstrumentationPython
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationDotNet() string {
-	if len(autoInstrumentationDotNet) > 0 {
+	if autoInstrumentationDotNet != "" {
 		return autoInstrumentationDotNet
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationApacheHttpd() string {
-	if len(autoInstrumentationApacheHttpd) > 0 {
+	if autoInstrumentationApacheHttpd != "" {
 		return autoInstrumentationApacheHttpd
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationNginx() string {
-	if len(autoInstrumentationNginx) > 0 {
+	if autoInstrumentationNginx != "" {
 		return autoInstrumentationNginx
 	}
 	return "0.0.0"
 }
 
 func AutoInstrumentationGo() string {
-	if len(autoInstrumentationGo) > 0 {
+	if autoInstrumentationGo != "" {
 		return autoInstrumentationGo
 	}
 	return "0.0.0"
diff --git a/pkg/collector/upgrade/upgrade.go b/pkg/collector/upgrade/upgrade.go
@@ -29,7 +29,7 @@ type VersionUpgrade struct {
 const RecordBufferSize int = 100
 
 func (u VersionUpgrade) semVer() *semver.Version {
-	if len(u.Version.OpenTelemetryCollector) == 0 {
+	if u.Version.OpenTelemetryCollector == "" {
 		return &Latest.Version
 	}
 	v, err := semver.NewVersion(u.Version.OpenTelemetryCollector)
diff --git a/pkg/collector/upgrade/v0_104_0.go b/pkg/collector/upgrade/v0_104_0.go
@@ -52,7 +52,7 @@ func TAUnifyEnvVarExpansion(otelcol *v1beta1.OpenTelemetryCollector) {
 		otelcol.Spec.Args = make(map[string]string)
 	}
 	args, ok := otelcol.Spec.Args[baseFlag]
-	if !ok || len(args) == 0 {
+	if !ok || args == "" {
 		otelcol.Spec.Args[baseFlag] = "-" + fgFlag
 	} else if !strings.Contains(otelcol.Spec.Args[baseFlag], fgFlag) {
 		otelcol.Spec.Args[baseFlag] += ",-" + fgFlag
@@ -72,7 +72,7 @@ func ComponentUseLocalHostAsDefaultHost(otelcol *v1beta1.OpenTelemetryCollector)
 		otelcol.Spec.Args = make(map[string]string)
 	}
 	args, ok := otelcol.Spec.Args[baseFlag]
-	if !ok || len(args) == 0 {
+	if !ok || args == "" {
 		otelcol.Spec.Args[baseFlag] = "-" + fgFlag
 	} else if !strings.Contains(otelcol.Spec.Args[baseFlag], fgFlag) {
 		otelcol.Spec.Args[baseFlag] += ",-" + fgFlag
diff --git a/pkg/collector/upgrade/v0_19_0.go b/pkg/collector/upgrade/v0_19_0.go
@@ -15,7 +15,7 @@ import (
 )
 
 func upgrade0_19_0(u VersionUpgrade, otelcol *v1alpha1.OpenTelemetryCollector) (*v1alpha1.OpenTelemetryCollector, error) {
-	if len(otelcol.Spec.Config) == 0 {
+	if otelcol.Spec.Config == "" {
 		return otelcol, nil
 	}
 
@@ -95,7 +95,7 @@ func upgrade0_19_0(u VersionUpgrade, otelcol *v1alpha1.OpenTelemetryCollector) (
 
 				processors[k] = processor
 			case string:
-				if len(processor) == 0 {
+				if processor == "" {
 					// this processor is using the default configuration
 					continue
 				}
diff --git a/pkg/collector/upgrade/v0_24_0.go b/pkg/collector/upgrade/v0_24_0.go
diff --git a/pkg/collector/upgrade/v0_31_0.go b/pkg/collector/upgrade/v0_31_0.go
diff --git a/pkg/collector/upgrade/v0_36_0.go b/pkg/collector/upgrade/v0_36_0.go
diff --git a/pkg/collector/upgrade/v0_57_2.go b/pkg/collector/upgrade/v0_57_2.go
diff --git a/pkg/collector/upgrade/v0_61_0.go b/pkg/collector/upgrade/v0_61_0.go
diff --git a/pkg/collector/upgrade/v0_9_0.go b/pkg/collector/upgrade/v0_9_0.go
diff --git a/pkg/sidecar/annotation.go b/pkg/sidecar/annotation.go
diff --git a/pkg/sidecar/podmutator.go b/pkg/sidecar/podmutator.go

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ func (OpAMPBridgeWebhook) validate(r OpAMPBridge) (admission.Warnings, error)`
`94`	`94`	`warnings := admission.Warnings{}`
`95`	`95`
`96`	`96`	`// validate OpAMP server endpoint`
`97`		`- if len(strings.TrimSpace(r.Spec.Endpoint)) == 0 {`
	`97`	`+ if strings.TrimSpace(r.Spec.Endpoint) == "" {`
`98`	`98`	`return warnings, errors.New("the OpAMP server endpoint is not specified")`
`99`	`99`	`}`
`100`	`100`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ func (w TargetAllocatorWebhook) validate(ctx context.Context, ta *TargetAllocato`
`115`	`115`	`// if the prometheusCR is enabled, it needs a suite of permissions to function`
`116`	`116`	`if ta.Spec.PrometheusCR.Enabled {`
`117`	`117`	`saname := ta.Spec.ServiceAccount`
`118`		`- if len(ta.Spec.ServiceAccount) == 0 {`
	`118`	`+ if ta.Spec.ServiceAccount == "" {`
`119`	`119`	`saname = naming.TargetAllocatorServiceAccount(ta.Name)`
`120`	`120`	`}`
`121`	`121`	`warnings, err := v1beta1.CheckTargetAllocatorPrometheusCRPolicyRules(ctx, w.reviewer, ta.GetNamespace(), saname)`
Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ func (c CollectorWebhook) validateTargetAllocatorConfig(ctx context.Context, r *`
`359`	`359`	`// if the prometheusCR is enabled, it needs a suite of permissions to function`
`360`	`360`	`if r.Spec.TargetAllocator.PrometheusCR.Enabled {`
`361`	`361`	`saname := r.Spec.TargetAllocator.ServiceAccount`
`362`		`- if len(r.Spec.TargetAllocator.ServiceAccount) == 0 {`
	`362`	`+ if r.Spec.TargetAllocator.ServiceAccount == "" {`
`363`	`363`	`saname = naming.TargetAllocatorServiceAccount(r.Name)`
`364`	`364`	`}`
`365`	`365`	`warnings, err := CheckTargetAllocatorPrometheusCRPolicyRules(`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ func (s *OpAMPProxy) onDisconnect(conn types.Connection) {`
`105`	`105`	`defer s.mux.Unlock()`
`106`	`106`
`107`	`107`	`for instanceId := range s.connections[conn] {`
`108`		`- if hostName := s.agentsById[instanceId].GetHostname(); len(hostName) > 0 {`
	`108`	`+ if hostName := s.agentsById[instanceId].GetHostname(); hostName != "" {`
`109`	`109`	`delete(s.agentsByHostName, hostName)`
`110`	`110`	`}`
`111`	`111`	`delete(s.agentsById, instanceId)`
`@@ -141,7 +141,7 @@ func (s OpAMPProxy) onMessage(_ context.Context, conn types.Connection, msg pr`
`141`	`141`	`agentUpdated = true`
`142`	`142`	`}`
`143`	`143`	`agentUpdated = s.agentsById[instanceId].UpdateStatus(msg, response) \|\| agentUpdated`
`144`		`- if hostName := s.agentsById[instanceId].GetHostname(); len(hostName) > 0 {`
	`144`	`+ if hostName := s.agentsById[instanceId].GetHostname(); hostName != "" {`
`145`	`145`	`s.agentsByHostName[hostName] = instanceId`
`146`	`146`	`}`
`147`	`147`	`s.mux.Unlock()`
Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ func TestServer_TargetsHandler(t *testing.T) {`
`165`	`165`	`body := result.Body`
`166`	`166`	`bodyBytes, err := io.ReadAll(body)`
`167`	`167`	`assert.NoError(t, err)`
`168`		`- if len(tt.want.errString) != 0 {`
	`168`	`+ if tt.want.errString != "" {`
`169`	`169`	`assert.EqualError(t, err, tt.want.errString)`
`170`	`170`	`return`
`171`	`171`	`}`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func (b Builder[ComponentConfigType]) WithDefaultsApplier(defaultsApplier Defaul`
`145`	`145`	`func (b Builder[ComponentConfigType]) Build() (*GenericParser[ComponentConfigType], error) {`
`146`	`146`	`o := NewEmptySettings[ComponentConfigType]()`
`147`	`147`	`o.Apply(b...)`
`148`		`- if len(o.name) == 0 {`
	`148`	`+ if o.name == "" {`
`149`	`149`	`return nil, errors.New("invalid settings struct, no name specified")`
`150`	`150`	`}`
`151`	`151`	`return &GenericParser[ComponentConfigType]{`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func healthCheckV1Probe(logger logr.Logger, config healthcheckV1Config) (*corev1`
`51`	`51`	`// but since the function runs only when manifests are deployed,`
`52`	`52`	`// we must keep these runtime defaults for backward compatibility.`
`53`	`53`	`path := config.Path`
`54`		`- if len(path) == 0 {`
	`54`	`+ if path == "" {`
`55`	`55`	`path = defaultHealthcheckV1Path`
`56`	`56`	`}`
`57`	`57`	`return &corev1.Probe{`