Update Nodejs instrumenation tests to assert telemetry data (#3959)

Author: IshwarKanse

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/00-install-collector.yaml

@@ -1,22 +1,27 @@
-apiVersion: opentelemetry.io/v1alpha1
+apiVersion: opentelemetry.io/v1beta1
 kind: OpenTelemetryCollector
 metadata:
   name: sidecar
 spec:
   mode: sidecar
-  config: |
+  config:
     receivers:
       otlp:
         protocols:
-          grpc:
-          http:
-    processors:
+          grpc: {}
+          http: {}
+
+    processors: {}
 
     exporters:
       debug:
+        verbosity: detailed
 
     service:
       pipelines:
         traces:
           receivers: [otlp]
           exporters: [debug]
+        metrics:
+          receivers: [otlp]
+          exporters: [debug]

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/00-install-instrumentation.yaml

@@ -7,23 +7,20 @@ spec:
     - name: OTEL_TRACES_EXPORTER
       value: otlp
     - name: OTEL_EXPORTER_OTLP_ENDPOINT
-      value: http://localhost:4317
+      value: http://localhost:4318
     - name: OTEL_EXPORTER_OTLP_TIMEOUT
-      value: "20"
+      value: "20000"
     - name: OTEL_TRACES_SAMPLER
-      value: parentbased_traceidratio
-    - name: OTEL_TRACES_SAMPLER_ARG
-      value: "0.85"
+      value: always_on
     - name: SPLUNK_TRACE_RESPONSE_HEADER_ENABLED
       value: "true"
+    - name: OTEL_METRICS_EXPORTER
+      value: otlp
   exporter:
-    endpoint: http://localhost:4317
+    endpoint: http://localhost:4318
   propagators:
     - jaeger
     - b3
-  sampler:
-    type: parentbased_traceidratio
-    argument: "0.25"
   java:
     env:
     - name: OTEL_JAVAAGENT_DEBUG

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/01-assert.yaml

@@ -13,10 +13,12 @@ spec:
     - name: OTEL_NODE_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.hostIP
     - name: OTEL_POD_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.podIP
     - name: NODE_PATH
       value: /usr/local/lib/node_modules
@@ -25,15 +27,15 @@ spec:
     - name: OTEL_TRACES_EXPORTER
       value: otlp
     - name: OTEL_EXPORTER_OTLP_ENDPOINT
-      value: http://localhost:4317
+      value: http://localhost:4318
     - name: OTEL_EXPORTER_OTLP_TIMEOUT
-      value: "20"
+      value: "20000"
     - name: OTEL_TRACES_SAMPLER
-      value: parentbased_traceidratio
-    - name: OTEL_TRACES_SAMPLER_ARG
-      value: "0.85"
+      value: always_on
     - name: SPLUNK_TRACE_RESPONSE_HEADER_ENABLED
       value: "true"
+    - name: OTEL_METRICS_EXPORTER
+      value: otlp
     - name: OTEL_SERVICE_NAME
       value: my-nodejs-multi
     - name: OTEL_RESOURCE_ATTRIBUTES_POD_NAME
@@ -50,6 +52,9 @@ spec:
       value: jaeger,b3
     - name: OTEL_RESOURCE_ATTRIBUTES
     name: myapp
+    ports:
+    - containerPort: 3000
+      protocol: TCP
     volumeMounts:
     - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
       readOnly: true
@@ -59,25 +64,27 @@ spec:
     - name: OTEL_NODE_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.hostIP
     - name: OTEL_POD_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.podIP
     - name: NODE_OPTIONS
       value: ' --require /otel-auto-instrumentation-nodejs/autoinstrumentation.js'
     - name: OTEL_TRACES_EXPORTER
       value: otlp
     - name: OTEL_EXPORTER_OTLP_ENDPOINT
-      value: http://localhost:4317
+      value: http://localhost:4318
     - name: OTEL_EXPORTER_OTLP_TIMEOUT
-      value: "20"
+      value: "20000"
     - name: OTEL_TRACES_SAMPLER
-      value: parentbased_traceidratio
-    - name: OTEL_TRACES_SAMPLER_ARG
-      value: "0.85"
+      value: always_on
     - name: SPLUNK_TRACE_RESPONSE_HEADER_ENABLED
       value: "true"
+    - name: OTEL_METRICS_EXPORTER
+      value: otlp
     - name: OTEL_SERVICE_NAME
       value: my-nodejs-multi
     - name: OTEL_RESOURCE_ATTRIBUTES_POD_NAME

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/01-install-app.yaml

@@ -22,6 +22,8 @@ spec:
         fsGroup: 3000
       containers:
       - name: myapp
+        ports:
+        - containerPort: 3000
         image: ghcr.io/open-telemetry/opentelemetry-operator/e2e-test-app-nodejs:main
         securityContext:
           allowPrivilegeEscalation: false
@@ -30,6 +32,15 @@ spec:
         env:
         - name: NODE_PATH
           value: /usr/local/lib/node_modules
+        readinessProbe:
+          httpGet:
+            path: /rolldice
+            port: 3000
+            scheme: HTTP
+          initialDelaySeconds: 5
+          periodSeconds: 15
+          timeoutSeconds: 2
+          failureThreshold: 3
       - name: myrabbit
         image: rabbitmq:3
         securityContext:

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/02-assert.yaml

@@ -24,10 +24,12 @@ spec:
     - name: OTEL_NODE_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.hostIP
     - name: OTEL_POD_IP
       valueFrom:
         fieldRef:
+          apiVersion: v1
           fieldPath: status.podIP
     - name: NODE_PATH
       value: /usr/local/lib/node_modules
@@ -36,15 +38,15 @@ spec:
     - name: OTEL_TRACES_EXPORTER
       value: otlp
     - name: OTEL_EXPORTER_OTLP_ENDPOINT
-      value: http://localhost:4317
+      value: http://localhost:4318
     - name: OTEL_EXPORTER_OTLP_TIMEOUT
-      value: "20"
+      value: "20000"
     - name: OTEL_TRACES_SAMPLER
-      value: parentbased_traceidratio
-    - name: OTEL_TRACES_SAMPLER_ARG
-      value: "0.85"
+      value: always_on
     - name: SPLUNK_TRACE_RESPONSE_HEADER_ENABLED
       value: "true"
+    - name: OTEL_METRICS_EXPORTER
+      value: otlp
     - name: OTEL_SERVICE_NAME
       value: my-nodejs-multi
     - name: OTEL_RESOURCE_ATTRIBUTES_POD_NAME
@@ -61,6 +63,9 @@ spec:
       value: jaeger,b3
     - name: OTEL_RESOURCE_ATTRIBUTES
     name: myapp
+    ports:
+    - containerPort: 3000
+      protocol: TCP
     volumeMounts:
     - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
       readOnly: true

tests/e2e-instrumentation/instrumentation-nodejs-multicontainer/02-install-app.yaml

@@ -22,6 +22,8 @@ spec:
         fsGroup: 3000
       containers:
       - name: myapp
+        ports:
+        - containerPort: 3000
         image: ghcr.io/open-telemetry/opentelemetry-operator/e2e-test-app-nodejs:main
         securityContext:
           allowPrivilegeEscalation: false
@@ -30,6 +32,15 @@ spec:
         env:
         - name: NODE_PATH
           value: /usr/local/lib/node_modules
+        readinessProbe:
+          httpGet:
+            path: /rolldice
+            port: 3000
+            scheme: HTTP
+          initialDelaySeconds: 5
+          periodSeconds: 15
+          timeoutSeconds: 2
+          failureThreshold: 3
       - name: myrabbit
         image: rabbitmq:3
         securityContext: