Skip to content

Commit 01ce182

Browse files
committed
fixing more broken things
1 parent 73b1952 commit 01ce182

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/Instrumentation/Curl/tests/Integration/CurlMultiInstrumentationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public function test_curl_multi_error()
9393

9494
$this->assertCount(1, $this->storage);
9595
$span = $this->storage->offsetGet(0);
96-
$this->assertEquals('curl_multi_exec', $span->getAttributes()->get(TraceAttributes::CODE_FUNCTION));
96+
$this->assertEquals('curl_multi_exec', $span->getAttributes()->get(TraceAttributes::CODE_FUNCTION_NAME));
9797
$this->assertEquals('unknown://scheme.com/', actual: $span->getAttributes()->get(TraceAttributes::URL_FULL));
9898
$this->assertSame('GET', $span->getName());
9999
}

src/Instrumentation/Laravel/src/Watchers/LogWatcher.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
use Illuminate\Log\LogManager;
1010
use OpenTelemetry\API\Instrumentation\CachedInstrumentation;
1111
use OpenTelemetry\API\Logs\LogRecord;
12-
use OpenTelemetry\API\Logs\Severity;
12+
use OpenTelemetry\API\Logs\Map\Psr3;
1313
use TypeError;
1414

1515
class LogWatcher extends Watcher
@@ -56,9 +56,10 @@ public function recordLog(MessageLogged $log): void
5656

5757
$logger = $this->instrumentation->logger();
5858

59+
/* @phan-suppressPhanUndeclaredClassMethod */
5960
$record = (new LogRecord($log->message))
6061
->setSeverityText($log->level)
61-
->setSeverityNumber(Severity::fromPsr3($log->level))
62+
->setSeverityNumber(Psr3::severityNumber($log->level))
6263
->setAttributes($attributes);
6364

6465
$logger->emit($record);

src/ResourceDetectors/Azure/tests/Unit/AppService/DetectorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function test_valid_app_service_attributes()
3232
[ResourceAttributes::CLOUD_PROVIDER, null, 'azure'],
3333
[ResourceAttributes::CLOUD_RESOURCE_ID, Detector::ENV_REGION_NAME_KEY, '/subscriptions/owner_name/resourceGroups/resouce_group/providers/Microsoft.Web/sites/demo-app'],
3434
[ResourceAttributes::CLOUD_REGION, Detector::ENV_REGION_NAME_KEY, 'westus'],
35-
[ResourceAttributes::DEPLOYMENT_ENVIRONMENT, Detector::ENV_WEBSITE_SLOT_NAME_KEY, 'testing'],
35+
[ResourceAttributes::DEPLOYMENT_ENVIRONMENT_NAME, Detector::ENV_WEBSITE_SLOT_NAME_KEY, 'testing'],
3636
[ResourceAttributes::HOST_ID, Detector::ENV_WEBSITE_HOSTNAME_KEY, 'example.com'],
3737
[ResourceAttributes::SERVICE_INSTANCE_ID, Detector::ENV_WEBSITE_INSTANCE_ID_KEY, uniqid()],
3838
[ResourceAttributes::SERVICE_NAME, Detector::ENV_WEBSITE_SITE_NAME_KEY, self::SERVICE_NAME],

0 commit comments

Comments
 (0)