Skip to content

Commit 0262b34

Browse files
committed
Add mock objects to unit tests
1 parent 91aaffc commit 0262b34

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

tests/Unit/Instrumentation/AwsSdk/AwsSdkInstrumentationTest.php

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,17 @@
88
use OpenTelemetry\API\Trace\TracerInterface;
99
use OpenTelemetry\Aws\Xray\Propagator;
1010
use OpenTelemetry\Instrumentation\AwsSdk\AwsSdkInstrumentation;
11-
use OpenTelemetry\SDK\Trace\TracerProvider;
1211
use OpenTelemetry\SDK\Trace\TracerProviderInterface;
1312
use PHPUnit\Framework\TestCase;
1413

1514
class AwsSdkInstrumentationTest extends TestCase
1615
{
17-
private TracerProvider $tracerProvider;
1816
private AwsSdkInstrumentation $awsSdkInstrumentation;
1917

2018
protected function setUp(): void
2119
{
2220
BypassFinals::enable();
23-
$this->tracerProvider = $this->createMock(TracerProvider::class);
24-
$this->provider = $this->createMock(TracerProviderInterface::class);
25-
$this->tracer = $this->createMock(TracerInterface::class);
26-
2721
$this->awsSdkInstrumentation = new AwsSdkInstrumentation();
28-
$this->awsSdkInstrumentation->setTracerProvider($this->tracerProvider);
2922
}
3023

3124
public function testInstrumentationClassName()
@@ -69,17 +62,25 @@ public function testGetXrayPropagator()
6962

7063
public function testGetTracerProvider()
7164
{
65+
$tracerProvider = $this->createMock(TracerProviderInterface::class);
66+
$this->awsSdkInstrumentation->setTracerProvider($tracerProvider);
67+
7268
$this->assertSame(
7369
$this->awsSdkInstrumentation->getTracerProvider(),
74-
$this->tracerProvider
70+
$tracerProvider
7571
);
7672
}
7773

7874
public function testGetTracer()
7975
{
80-
$this->provider->method('getTracer')->willReturn($this->tracer);
81-
$this->awsSdkInstrumentation->setTracerProvider($this->provider);
82-
$this->assertSame($this->tracer, $this->awsSdkInstrumentation->getTracer());
76+
$tracer = $this->createMock(TracerInterface::class);
77+
$tracerProvider = $this->createMock(TracerProviderInterface::class);
78+
$tracerProvider->expects($this->once())
79+
->method('getTracer')
80+
->willReturn($tracer);
81+
82+
$this->awsSdkInstrumentation->setTracerProvider($tracerProvider);
83+
$this->assertSame($tracer, $this->awsSdkInstrumentation->getTracer());
8384
}
8485

8586
public function testInstrumentationActivated()

0 commit comments

Comments
 (0)