Fix psalm issues

Author: tidal

tests/Integration/Symfony/OtelSdkBundle/DependencyInjection/OtelSdkExtensionTest.php

@@ -170,6 +170,7 @@ public function testAlwaysOffRootSamplerRegression(): void
 
     /**
      * @throws Exception
+     * @psalm-suppress PossiblyNullArrayAccess
      */
     public function testSpanLimits(): void
     {
@@ -260,6 +261,13 @@ public function testSpanProcessors(): void
         }
     }
 
+    /**
+     * @psalm-suppress PossiblyInvalidCast
+     * @psalm-suppress RedundantCondition
+     * @psalm-suppress InvalidArrayOffset
+     * @psalm-suppress PossiblyNullArrayAccess
+     * @psalm-suppress PossiblyNullArgument
+     */
     public function testSpanExporters(): void
     {
         $data = $this->loadTestData('exporters')['trace']['exporters'];
@@ -336,6 +344,9 @@ public function testSpanExporters(): void
 
     // HELPER METHODS
 
+    /**
+     * @psalm-suppress PossiblyInvalidCast
+     */
     private function assertReference(string $class, ?object $reference, ?string $idSuffix = null): void
     {
         $this->assertIsReference(
@@ -372,6 +383,10 @@ private function assertIsReference(?object $reference): void
         );
     }
 
+    /**
+     * @psalm-suppress NullableReturnStatement
+     * @psalm-suppress InvalidNullableReturnType
+     */
     private function getClassFromReference(Reference $reference): string
     {
         return $this->getContainer()

tests/Integration/Symfony/OtelSdkBundle/OtelSdkBundleTest.php

@@ -179,9 +179,9 @@ public function testExporterWithSimpleConfig(): void
     }
 
     /**
-     * @test
      * @depends testExporterWithSimpleConfig
      * @throws Exception
+     * @psalm-suppress PossiblyUndefinedMethod
      */
     public function testTracingWithSimpleConfig(): void
     {
@@ -207,6 +207,7 @@ public function testTracingWithSimpleConfig(): void
     /**
      * @depends testExporterWithSimpleConfig
      * @throws Exception
+     * @psalm-suppress PossiblyUndefinedMethod
      */
     public function testTracingWithAlwaysOffSampler(): void
     {
@@ -270,6 +271,7 @@ private function getTracerProviderId(): string
 
     /**
      * @return MockObject|ClientInterface
+     * @psalm-suppress MismatchingDocblockReturnType
      */
     private function registerHttpClientMock(): ClientInterface
     {

tests/Unit/Symfony/OtelSdkBundle/Factory/GenericFactoryTraitTest.php

@@ -46,18 +46,21 @@ public function setUp(): void
         BypassFinals::enable();
     }
 
-    private function init()
+    private function init(): void
     {
         $this->initResolver();
         $this->initFactory();
     }
 
-    private function initResolver()
+    private function initResolver(): void
     {
         $this->resolver = $this->createOptionsResolverMock();
     }
 
-    private function initFactory(string $class = TestedClass::class)
+    /**
+     * @psalm-suppress PossiblyInvalidArgument
+     */
+    private function initFactory(string $class = TestedClass::class): void
     {
         $this->factory = GenericFactoryImplementation::create(
             $class,
@@ -66,7 +69,7 @@ private function initFactory(string $class = TestedClass::class)
     }
 
     // TESTS
-    public function testCreate()
+    public function testCreate(): void
     {
         $this->init();
 
@@ -76,7 +79,10 @@ public function testCreate()
         );
     }
 
-    public function testCreateWithNonExistingClass()
+    /**
+     * @psalm-suppress PossiblyInvalidArgument
+     */
+    public function testCreateWithNonExistingClass(): void
     {
         $this->initResolver();
         $class = 'NonExistingClass';
@@ -91,7 +97,8 @@ class_exists($class)
         );
     }
 
-    public function testGetOptionsResolver()
+    /** @noinspection UnnecessaryAssertionInspection */
+    public function testGetOptionsResolver(): void
     {
         $this->init();
 
@@ -101,22 +108,17 @@ public function testGetOptionsResolver()
         );
     }
 
-    public function testGetReflectionClass()
+    public function testGetReflectionClass(): void
     {
         $this->init();
 
-        $this->assertInstanceOf(
-            ReflectionClass::class,
-            $this->factory->getReflectionClass()
-        );
-
         $this->assertSame(
             TestedClass::class,
             $this->factory->getReflectionClass()->getName()
         );
     }
 
-    public function testGetClass()
+    public function testGetClass(): void
     {
         $this->init();
 
@@ -126,7 +128,7 @@ public function testGetClass()
         );
     }
 
-    public function testGetOptions()
+    public function testGetOptions(): void
     {
         $this->init();
 
@@ -136,7 +138,7 @@ public function testGetOptions()
         );
     }
 
-    public function testGetRequiredOptions()
+    public function testGetRequiredOptions(): void
     {
         $this->init();
 
@@ -146,7 +148,7 @@ public function testGetRequiredOptions()
         );
     }
 
-    public function testGetDefaults()
+    public function testGetDefaults(): void
     {
         $this->init();
 
@@ -156,7 +158,7 @@ public function testGetDefaults()
         );
     }
 
-    public function testSetDefault()
+    public function testSetDefault(): void
     {
         $this->init();
 
@@ -173,7 +175,7 @@ public function testSetDefault()
         );
     }
 
-    public function testSetDefaults()
+    public function testSetDefaults(): void
     {
         $this->init();
 
@@ -190,7 +192,7 @@ public function testSetDefaults()
         );
     }
 
-    public function testBuildWithDefaults()
+    public function testBuildWithDefaults(): void
     {
         $option = 'foo_bar';
         $value = 'foo';
@@ -231,7 +233,7 @@ public function testBuildWithDefaults()
         );
     }
 
-    public function testBuildWithOptions()
+    public function testBuildWithOptions(): void
     {
         $options = [
             'foo_bar' => 'baz',
@@ -272,7 +274,10 @@ public function testBuildWithOptions()
         );
     }
 
-    public function testBuildClassWithoutConstructor()
+    /**
+     * @psalm-suppress PossiblyInvalidArgument
+     */
+    public function testBuildClassWithoutConstructor(): void
     {
         $this->initResolver();
 
@@ -287,7 +292,7 @@ public function testBuildClassWithoutConstructor()
         );
     }
 
-    public function testBuildWithDefaultNull()
+    public function testBuildWithDefaultNull(): void
     {
         $options = ['foo_bar' => 'baz'];
 
@@ -312,9 +317,10 @@ public function testBuildWithDefaultNull()
 
     // UTIL
 
-    // /** @psalm-suppress PossiblyUndefinedMethod **/
     /**
      * @return OptionsResolver|MockObject
+     * @psalm-suppress PossiblyInvalidArgument
+     * @psalm-suppress MismatchingDocblockReturnType
      */
     private function createOptionsResolverMock(): OptionsResolver
     {