Skip to content

Commit 0c79acb

Browse files
committed
fix symfony breakages
* update TraceableTracerProvider to support SDK 1.1.0+ (add updateConfigurator method). * update sdk dependency to 1.1 (which drops PHP 7.4+8.0 support) * update SystemClock refs from sdk to api * update psalm config
1 parent 4e6037a commit 0c79acb

File tree

7 files changed

+19
-12
lines changed

7 files changed

+19
-12
lines changed

src/Symfony/composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"license": "Apache-2.0",
66
"authors": [
77
],
8-
"minimum-stability": "dev",
98
"prefer-stable": true,
109
"require": {
1110
"php": "^7.4 || ^8.0",
@@ -35,14 +34,14 @@
3534
"friendsofphp/php-cs-fixer": "^3.0",
3635
"google/protobuf": "^3.23",
3736
"guzzlehttp/guzzle": "^7.3",
38-
"guzzlehttp/psr7": "^2.0@RC",
37+
"guzzlehttp/psr7": "^2.0",
3938
"jangregor/phpstan-prophecy": "^1.0",
4039
"kriswallsmith/buzz": "^1.2",
4140
"matthiasnoback/symfony-dependency-injection-test": "^4.3",
4241
"mikey179/vfsstream": "^1.6",
4342
"nyholm/psr7": "^1.4",
4443
"open-telemetry/dev-tools": "dev-main",
45-
"open-telemetry/sdk": "^1",
44+
"open-telemetry/sdk": "^1.1",
4645
"phan/phan": "^4.1 || ^5",
4746
"phpspec/prophecy-phpunit": "^2.0",
4847
"phpstan/phpstan": "^1.4",
@@ -76,8 +75,9 @@
7675
"sort-packages": true,
7776
"allow-plugins": {
7877
"composer/package-versions-deprecated": true,
78+
"php-http/discovery": false,
7979
"symfony/runtime": true,
80-
"php-http/discovery": false
80+
"tbachert/spi": true
8181
}
8282
}
8383
}

src/Symfony/psalm.xml.dist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<psalm
33
errorLevel="3"
44
cacheDirectory="var/cache/psalm"
5+
findUnusedBaselineEntry="false"
6+
findUnusedCode="false"
57
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
68
xmlns="https://getpsalm.org/schema/config"
79
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd">

src/Symfony/src/OtelSdkBundle/Debug/TraceableTracerProvider.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use OpenTelemetry\API\Trace\TracerInterface;
88
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DataCollector\OtelDataCollector;
99
use OpenTelemetry\SDK\Common\Future\CancellationInterface;
10+
use OpenTelemetry\SDK\Common\InstrumentationScope\Configurator;
1011
use OpenTelemetry\SDK\Trace\TracerProviderInterface;
1112

1213
/** @phan-file-suppress PhanUndeclaredInterface */
@@ -40,4 +41,8 @@ public function getTracer(string $name, ?string $version = null, ?string $schema
4041
{
4142
return $this->tracerProvider->getTracer($name, $version, $schemaUrl, $attributes);
4243
}
44+
45+
public function updateConfigurator(Configurator $configurator): void
46+
{
47+
}
4348
}

src/Symfony/src/OtelSdkBundle/Resources/config/sdk.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
namespace OpenTelemetry\Contrib\Symfony\OtelSdkBundle\Resources;
66

77
use OpenTelemetry\API;
8+
use OpenTelemetry\API\Common\Time\SystemClock;
89
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\Ids;
910
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\Parameters;
1011
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\Util\ConfigHelper;
1112
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\Util\ServiceHelper;
1213
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\Util\ServicesConfiguratorHelper;
1314
use OpenTelemetry\SDK;
1415
use OpenTelemetry\SDK\Common\Attribute\Attributes;
15-
use OpenTelemetry\SDK\Common\Time\SystemClock;
1616
use OpenTelemetry\SDK\Resource;
1717
use OpenTelemetry\SDK\Trace;
1818
use OpenTelemetry\SDK\Trace\Sampler;

src/Symfony/src/OtelSdkBundle/composer.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
"homepage": "https://github.com/open-telemetry/opentelemetry-php-contrib/graphs/contributors"
1111
}
1212
],
13-
"minimum-stability": "dev",
1413
"prefer-stable": true,
1514
"require": {
16-
"php": "^7.4 || ^8.0",
17-
"open-telemetry/sdk-contrib": "self.version",
18-
"open-telemetry/sdk": "self.version",
15+
"php": "^8.1",
16+
"open-telemetry/sdk": "^1.1",
17+
"open-telemetry/exporter-otlp": "^1.0",
18+
"open-telemetry/exporter-zipkin": "^1.0",
19+
"open-telemetry/transport-grpc": "^1.0",
1920
"php-http/message": "^1.12",
2021
"php-http/discovery": "^1.14",
2122
"symfony/config": "^4.4|^5.3|^6.0",
2223
"symfony/options-resolver": "^4.4|^5.3|^6.0",
23-
"symfony/polyfill-php80": "^1.16",
2424
"symfony/dependency-injection": "^4.4|^5.3|^6.0"
2525
},
2626
"autoload": {

src/Symfony/tests/Integration/OtelSdkBundle/DependencyInjection/OtelSdkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace OpenTelemetry\Tests\Contrib\Symfony\Integration\OtelSdkBundle\DependencyInjection;
66

77
use Exception;
8+
use OpenTelemetry\API\Common\Time\SystemClock;
89
use OpenTelemetry\Contrib\Otlp\SpanExporterFactory as OtlpExporterFactory;
910
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\OtelSdkExtension;
1011
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\Parameters;
@@ -15,7 +16,6 @@
1516
use OpenTelemetry\Contrib\Zipkin\SpanExporterFactory as ZipkinSpanExporterFactory;
1617
use OpenTelemetry\SDK;
1718
use OpenTelemetry\SDK\Common\Attribute\Attributes;
18-
use OpenTelemetry\SDK\Common\Time\SystemClock;
1919
use OpenTelemetry\SDK\Trace\SpanProcessor;
2020
use OpenTelemetry\Tests\Contrib\Symfony\Integration\OtelSdkBundle\Mock;
2121
use OpenTelemetry\Tests\Contrib\Symfony\Integration\OtelSdkBundle\Mock\SpanExporterFactory as MockSpanExporterFactory;

src/Symfony/tests/Integration/OtelSdkBundle/Resources/SdkConfigTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
namespace OpenTelemetry\Tests\Contrib\Symfony\Integration\OtelSdkBundle\Resources;
66

77
use Exception;
8+
use OpenTelemetry\API\Common\Time\SystemClock;
89
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\OtelSdkExtension;
910
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\DependencyInjection\Parameters;
1011
use OpenTelemetry\Contrib\Symfony\OtelSdkBundle\Util\ServiceHelper;
1112
use OpenTelemetry\SDK\Common\Attribute\Attributes;
12-
use OpenTelemetry\SDK\Common\Time\SystemClock;
1313
use OpenTelemetry\SDK\Resource;
1414
use OpenTelemetry\SDK\Trace;
1515
use OpenTelemetry\SDK\Trace\Sampler;

0 commit comments

Comments
 (0)