Skip to content

Commit 1deb2b4

Browse files
Laravel: watchers accept TracerInterface.
1 parent 65e413e commit 1deb2b4

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Instrumentation/Laravel/src/Watchers/ClientRequestWatcher.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
use Illuminate\Http\Client\Events\ResponseReceived;
1111
use Illuminate\Http\Client\Request;
1212
use Illuminate\Http\Client\Response;
13-
use OpenTelemetry\API\Instrumentation\CachedInstrumentation;
1413
use OpenTelemetry\API\Trace\SpanInterface;
1514
use OpenTelemetry\API\Trace\SpanKind;
1615
use OpenTelemetry\API\Trace\StatusCode;
16+
use OpenTelemetry\API\Trace\TracerInterface;
1717
use OpenTelemetry\SemConv\TraceAttributes;
1818
use Symfony\Component\HttpFoundation\Response as HttpResponse;
1919

@@ -25,7 +25,7 @@ class ClientRequestWatcher extends Watcher
2525
protected array $spans = [];
2626

2727
public function __construct(
28-
private CachedInstrumentation $instrumentation,
28+
private readonly TracerInterface $tracer,
2929
) {
3030
}
3131

@@ -52,7 +52,7 @@ public function recordRequest(RequestSending $request): void
5252
if ($parsedUrl->has('query')) {
5353
$processedUrl .= '?' . $parsedUrl->get('query');
5454
}
55-
$span = $this->instrumentation->tracer()->spanBuilder($request->request->method())
55+
$span = $this->tracer->spanBuilder($request->request->method())
5656
->setSpanKind(SpanKind::KIND_CLIENT)
5757
->setAttributes([
5858
TraceAttributes::HTTP_REQUEST_METHOD => $request->request->method(),

src/Instrumentation/Laravel/src/Watchers/QueryWatcher.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
use Illuminate\Contracts\Foundation\Application;
88
use Illuminate\Database\Events\QueryExecuted;
99
use Illuminate\Support\Str;
10-
use OpenTelemetry\API\Instrumentation\CachedInstrumentation;
1110
use OpenTelemetry\API\Trace\SpanKind;
11+
use OpenTelemetry\API\Trace\TracerInterface;
1212
use OpenTelemetry\SemConv\TraceAttributes;
1313

1414
class QueryWatcher extends Watcher
1515
{
1616
public function __construct(
17-
private CachedInstrumentation $instrumentation,
17+
private readonly TracerInterface $tracer,
1818
) {
1919
}
2020

@@ -38,7 +38,7 @@ public function recordQuery(QueryExecuted $query): void
3838
$operationName = null;
3939
}
4040
/** @psalm-suppress ArgumentTypeCoercion */
41-
$span = $this->instrumentation->tracer()->spanBuilder('sql ' . $operationName)
41+
$span = $this->tracer->spanBuilder('sql ' . $operationName)
4242
->setSpanKind(SpanKind::KIND_CLIENT)
4343
->setStartTimestamp($this->calculateQueryStartTime($nowInNs, $query->time))
4444
->startSpan();

0 commit comments

Comments
 (0)