next bunch of psalm fixes

Author: intuibase

src/Instrumentation/HttpAsyncClient/src/HttpAsyncClientInstrumentation.php

@@ -18,6 +18,7 @@
 use Psr\Http\Message\ResponseInterface;
 use Throwable;
 
+/** @psalm-suppress UnusedClass */
 class HttpAsyncClientInstrumentation
 {
     public const NAME = 'http-async-client';
@@ -29,6 +30,7 @@ public static function register(): void
             schemaUrl: 'https://opentelemetry.io/schemas/1.30.0',
         );
 
+        /** @psalm-suppress UnusedFunctionCall */
         hook(
             HttpAsyncClient::class,
             'sendAsyncRequest',

src/Instrumentation/IO/src/IOInstrumentation.php

@@ -14,6 +14,7 @@
 use OpenTelemetry\SemConv\Version;
 use Throwable;
 
+/** @psalm-suppress UnusedClass */
 class IOInstrumentation
 {
     public const NAME = 'io';
@@ -38,6 +39,7 @@ public static function register(): void
 
     /**
      * Simple generic hook function which starts and ends a minimal span
+     * @psalm-suppress UnusedFunctionCall
      */
     private static function _hook(CachedInstrumentation $instrumentation, ?string $class, string $function, string $name): void
     {

src/Instrumentation/IO/tests/Integration/IOInstrumentationTest.php

@@ -5,6 +5,7 @@
 namespace OpenTelemetry\Tests\Instrumentation\IO\tests\Integration;
 
 use ArrayObject;
+use CurlHandle;
 use OpenTelemetry\API\Instrumentation\Configurator;
 use OpenTelemetry\Context\ScopeInterface;
 use OpenTelemetry\SDK\Trace\ImmutableSpan;
@@ -41,6 +42,7 @@ public function tearDown(): void
     public function test_io_calls(): void
     {
         $resource = fopen('php://memory', 'r');
+        $this->assertIsResource($resource);
         $this->assertCount(1, $this->storage);
         $this->span = $this->storage->offsetGet(0);
         $this->assertSame('fopen', $this->span->getName());
@@ -52,8 +54,8 @@ public function test_io_calls(): void
         $this->span = $this->storage->offsetGet(1);
         $this->assertSame('file_put_contents', $this->span->getName());
         $this->assertSame('php://memory', $this->span->getAttributes()->get('code.params.filename'));
-        
-        $str = file_get_contents('php://memory');
+
+        file_get_contents('php://memory');
         $this->assertCount(3, $this->storage);
         $this->span = $this->storage->offsetGet(2);
         $this->assertSame('file_get_contents', $this->span->getName());
@@ -70,6 +72,7 @@ public function test_io_calls(): void
         $this->assertSame('fread', $this->span->getName());
 
         $ch = curl_init('foo');
+        $this->assertInstanceOf(CurlHandle::class, $ch);
         $this->assertCount(6, $this->storage);
         $this->span = $this->storage->offsetGet(5);
         $this->assertSame('curl_init', $this->span->getName());

src/Instrumentation/MongoDB/src/MongoDBInstrumentationSubscriber.php

@@ -68,8 +68,9 @@ public function commandStarted(CommandStartedEvent $event): void
         $collectionName = MongoDBCollectionExtractor::extract($command);
         $databaseName = $event->getDatabaseName();
         $commandName = $event->getCommandName();
-        /** @phpstan-ignore-next-line */
-        if (version_compare(phpversion('mongodb'), '1.20.0', '>=')) {
+
+        $version = phpversion('mongodb');
+        if ($version !== false && version_compare($version, '1.20.0', '>=')) {
             $host = $event->getHost();
             $port = $event->getPort();
         } else {

src/Instrumentation/Psr14/src/Psr14Instrumentation.php

@@ -17,6 +17,7 @@
 
 /**
  * @psalm-suppress ArgumentTypeCoercion
+ * @psalm-suppress UnusedClass
  */
 class Psr14Instrumentation
 {
@@ -32,6 +33,7 @@ public static function register(): void
 
         /**
          * Create a span for each PSR-14 event that is dispatched.
+         * @psalm-suppress UnusedFunctionCall
          */
         hook(
             EventDispatcherInterface::class,

src/Instrumentation/Psr14/tests/Fixture/SampleEventClass.php

@@ -9,11 +9,10 @@
  */
 final class SampleEventClass
 {
+    /** @psalm-suppress PossiblyUnusedProperty */
     public string $item;
 
-    public function __construct(
-        string $item = 'test',
-    ) {
+    public function __construct(string $item = 'test') {
         $this->item = $item;
     }
 }

src/Instrumentation/Psr15/src/Psr15Instrumentation.php

@@ -21,6 +21,7 @@
 
 /**
  * @psalm-suppress ArgumentTypeCoercion
+ * @psalm-suppress UnusedClass
  */
 class Psr15Instrumentation
 {

src/Instrumentation/Psr16/src/Psr16Instrumentation.php

@@ -53,6 +53,7 @@ public static function register(): void
         };
 
         foreach (['get', 'set', 'delete', 'clear', 'getMultiple', 'setMultiple', 'deleteMultiple', 'has'] as $f) {
+            /** @psalm-suppress UnusedFunctionCall */
             hook(class: CacheInterface::class, function: $f, pre: $pre, post: $post);
         }
     }

src/Instrumentation/Psr18/src/Psr18Instrumentation.php

@@ -20,6 +20,7 @@
 use function strtolower;
 use Throwable;
 
+/** @psalm-suppress UnusedClass */
 class Psr18Instrumentation
 {
     /** @psalm-suppress ArgumentTypeCoercion */
@@ -32,6 +33,7 @@ public static function register(): void
             'https://opentelemetry.io/schemas/1.30.0',
         );
 
+        /** @psalm-suppress UnusedFunctionCall */
         hook(
             ClientInterface::class,
             'sendRequest',

src/Instrumentation/Slim/src/PsrResponsePropagationSetter.php

@@ -21,6 +21,7 @@ public static function instance(): self
         return $instance ??= new self();
     }
 
+    /** @psalm-suppress PossiblyUnusedMethod */
     public function keys($carrier): array
     {
         assert($carrier instanceof ResponseInterface);