Skip to content

Commit 3f2b330

Browse files
committed
Fix tests
Use Docker image Require min of PHP 7.3 Exclude examples from static analysis for now
1 parent 29fb65f commit 3f2b330

19 files changed

+149
-125
lines changed

.github/workflows/php.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
matrix:
1616
operating-system: [ubuntu-latest]
17-
php-versions: ['7.3', '7.4', '8.0']
17+
php-versions: ['7.4', '8.0']
1818

1919
steps:
2020
- uses: actions/checkout@v2

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}
1111
],
1212
"require": {
13-
"php": "^7.3 || ^8.0",
13+
"php": "^7.4 || ^8.0",
1414
"ext-json": "*",
1515
"open-telemetry/opentelemetry": "dev-main"
1616
},

detectors/aws/Ec2Detector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
use GuzzleHttp\Client;
2424
use GuzzleHttp\Exception\RequestException;
2525
use GuzzleHttp\Psr7\Request;
26-
use OpenTelemetry\Sdk\Resource\ResourceConstants;
27-
use OpenTelemetry\Sdk\Resource\ResourceInfo;
28-
use OpenTelemetry\Sdk\Trace\Attributes;
26+
use OpenTelemetry\SDK\Resource\ResourceConstants;
27+
use OpenTelemetry\SDK\Resource\ResourceInfo;
28+
use OpenTelemetry\SDK\Trace\Attributes;
2929

3030
/**
3131
* The AwsEc2Detector can be used to detect if a process is running in AWS EC2

detectors/aws/EcsDetector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020
namespace Detectors\Aws;
2121

22-
use OpenTelemetry\Sdk\Resource\ResourceConstants;
23-
use OpenTelemetry\Sdk\Resource\ResourceInfo;
24-
use OpenTelemetry\Sdk\Trace\Attributes;
22+
use OpenTelemetry\SDK\Resource\ResourceConstants;
23+
use OpenTelemetry\SDK\Resource\ResourceInfo;
24+
use OpenTelemetry\SDK\Trace\Attributes;
2525

2626
/**
2727
* The AwsEcsDetector can be used to detect if a process is running in AWS

detectors/aws/EksDetector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
use GuzzleHttp\Client;
2323
use GuzzleHttp\Exception\RequestException;
2424
use GuzzleHttp\Psr7\Request;
25-
use OpenTelemetry\Sdk\Resource\ResourceConstants;
26-
use OpenTelemetry\Sdk\Resource\ResourceInfo;
27-
use OpenTelemetry\Sdk\Trace\Attributes;
25+
use OpenTelemetry\SDK\Resource\ResourceConstants;
26+
use OpenTelemetry\SDK\Resource\ResourceInfo;
27+
use OpenTelemetry\SDK\Trace\Attributes;
2828

2929
/**
3030
* The AwsEksDetector can be used to detect if a process is running in AWS

detectors/aws/LambdaDetector.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020

2121
namespace Detectors\Aws;
2222

23-
use OpenTelemetry\Sdk\Resource\ResourceConstants;
24-
use OpenTelemetry\Sdk\Resource\ResourceInfo;
25-
use OpenTelemetry\Sdk\Trace\Attributes;
23+
use OpenTelemetry\SDK\Resource\ResourceConstants;
24+
use OpenTelemetry\SDK\Resource\ResourceInfo;
25+
use OpenTelemetry\SDK\Trace\Attributes;
2626

2727
/**
2828
* The AwsLambdaDetector can be used to detect if a process is running in AWS Lambda

docker-compose.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
version: '3.7'
22
services:
33
php:
4-
build:
5-
context: .
6-
dockerfile: docker/Dockerfile
4+
image: ghcr.io/open-telemetry/opentelemetry-php/opentelemetry-php-base:latest
75
volumes:
86
- ./:/usr/src/myapp
97
zipkin:

docker/Dockerfile

Lines changed: 0 additions & 17 deletions
This file was deleted.

instrumentation/aws/xray/AwsXrayIdGenerator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@
1919

2020
namespace Instrumentation\Aws\Xray;
2121

22-
use OpenTelemetry\Sdk\Trace\IdGenerator;
23-
use OpenTelemetry\Sdk\Trace\RandomIdGenerator;
22+
use OpenTelemetry\SDK\Trace\IdGeneratorInterface;
23+
use OpenTelemetry\SDK\Trace\RandomIdGenerator;
2424

2525
/**
2626
* An ID generator that generates trace IDs that conforms to AWS X-Ray format
2727
* Refer to the AWS X-Ray documentation:
2828
* https://docs.aws.amazon.com/xray/latest/devguide/xray-api-sendingdata.html#xray-api-traceids
2929
*/
30-
class AwsXrayIdGenerator implements IdGenerator
30+
class AwsXrayIdGenerator implements IdGeneratorInterface
3131
{
3232
private const TRACE_ID_RANDOM_HEX_LENGTH = 24;
3333

phpstan.neon.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ parameters:
1111
- vendor
1212
- proto
1313
- tests/TraceContext/W3CTestService
14+
- examples # TODO: Remove this once examples are updated

0 commit comments

Comments
 (0)