Fix post hook exception possibility in opentelemetry-auto-curl

vsimon · vsimon · commit 6de883350e87 · 2025-03-20T16:02:25.000-07:00
For open-telemetry/opentelemetry-php #1531
diff --git a/src/Instrumentation/Curl/src/CurlHandleMetadata.php b/src/Instrumentation/Curl/src/CurlHandleMetadata.php
@@ -137,7 +137,7 @@ public function updateFromCurlOption(int $option, mixed $value)
 
                 break;
             case CURLOPT_VERBOSE:
-                $this->verboseEnabled = $value;
+                $this->verboseEnabled = (bool) $value;
 
                 break;
         }
@@ -162,5 +162,4 @@ public static function redactUrlString(string $fullUrl)
 
         return $scheme . $user . $pass . $host . $port . $path . $query . $fragment;
     }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ public function updateFromCurlOption(int $option, mixed $value)`
`137`	`137`
`138`	`138`	`break;`
`139`	`139`	`case CURLOPT_VERBOSE:`
`140`		`- $this->verboseEnabled = $value;`
	`140`	`+ $this->verboseEnabled = (bool) $value;`
`141`	`141`
`142`	`142`	`break;`
`143`	`143`	`}`
`@@ -162,5 +162,4 @@ public static function redactUrlString(string $fullUrl)`
`162`	`162`
`163`	`163`	`return $scheme . $user . $pass . $host . $port . $path . $query . $fragment;`
`164`	`164`	`}`
`165`		`-`
`166`	`165`	`}`