linting/static analysis fixes

Author: smaddock

src/Instrumentation/ReactHTTP/examples/http+async_nonblocking.php

@@ -42,6 +42,7 @@
 Loop::futureTick(async(static function () use ($context, $root) {
     $contextScope = $context->activate();
     $rootScope = $root->activate();
+
     try {
         $browser = new Browser();
 

src/Instrumentation/ReactHTTP/examples/http_only.php

@@ -37,6 +37,7 @@
 
 Loop::futureTick(static function () use ($root) {
     $rootScope = $root->activate();
+
     try {
         $browser = new Browser();
 

src/Instrumentation/ReactHTTP/examples/http_only_promises.php

@@ -37,6 +37,7 @@
 
 Loop::futureTick(static function () use ($root) {
     $rootScope = $root->activate();
+
     try {
         $browser = new Browser();
 

src/Instrumentation/ReactHTTP/src/ReactHttpInstrumentation.php

@@ -34,7 +34,7 @@ public static function register(): void
         hook(
             Transaction::class,
             'send',
-            pre: static function (Transaction $transaction, array $params, string $class, string $function, ?string $filename, ?int $lineno) use ($instrumentation): ?array {
+            pre: static function (Transaction $transaction, array $params, string $class, string $function, ?string $filename, ?int $lineno) use ($instrumentation): array {
                 $request = $params[0];
 
                 $propagator = Globals::propagator();
@@ -44,11 +44,10 @@ public static function register(): void
                     $request = $request->withoutHeader($field);
                 }
 
-                /** @psalm-suppress ArgumentTypeCoercion */
                 $spanBuilder = $instrumentation
                     ->tracer()
                     // https://opentelemetry.io/docs/specs/semconv/http/http-spans/#http-client-span
-                    ->spanBuilder(sprintf('%s', $request->getMethod()))
+                    ->spanBuilder(sprintf('%s', $request->getMethod()) ?: 'HTTP')
                     ->setParent($parentContext)
                     ->setSpanKind(SpanKind::KIND_CLIENT)
                     ->setAttribute(TraceAttributes::HTTP_REQUEST_METHOD, $request->getMethod())
@@ -88,6 +87,7 @@ public static function register(): void
 
                 return [$request];
             },
+            /** @psalm-suppress UnusedClosureParam */
             post: static function (Transaction $transaction, array $params, PromiseInterface $promise, ?Throwable $exception): PromiseInterface {
                 $scope = Context::storage()->scope();
                 $scope?->detach();
@@ -111,7 +111,6 @@ public static function register(): void
                         // @codeCoverageIgnoreStart
                         foreach ((array) (get_cfg_var('otel.instrumentation.http.response_headers') ?: []) as $header) {
                             if ($response->hasHeader($header)) {
-                                /** @psalm-suppress ArgumentTypeCoercion */
                                 $span->setAttribute(
                                     sprintf('%s.%s', TraceAttributes::HTTP_RESPONSE_HEADER, strtolower($header)),
                                     $response->getHeaderLine($header)
@@ -136,7 +135,6 @@ public static function register(): void
                             // @codeCoverageIgnoreStart
                             foreach ((array) (get_cfg_var('otel.instrumentation.http.response_headers') ?: []) as $header) {
                                 if ($t->getResponse()->hasHeader($header)) {
-                                    /** @psalm-suppress ArgumentTypeCoercion */
                                     $span->setAttribute(
                                         sprintf('%s.%s', TraceAttributes::HTTP_RESPONSE_HEADER, strtolower($header)),
                                         $t->getResponse()->getHeaderLine($header)

src/Instrumentation/ReactHTTP/tests/Integration/ReactHttpInstrumentationTest.php

@@ -52,15 +52,15 @@ public function setUp(): void
         $sender->method('send')
             ->willReturnCallback(function (RequestInterface $request) {
                 return match ($request->getUri()->getPath()) {
-                    '/success' => resolve(Response::plaintext('Hello world')),
                     '/network_error' => resolve((new Response())->withStatus(400)),
-                    '/unknown_error' => reject(new \Exception('Unknown'))
+                    '/unknown_error' => reject(new \Exception('Unknown')),
+                    default => resolve(Response::plaintext('Hello world'))
                 };
             });
+        /** @psalm-suppress InternalClass,InternalMethod */
         $transaction = new Transaction($sender, $loop);
         $this->browser = new Browser(null, $loop);
         $ref = new \ReflectionProperty($this->browser, 'transaction');
-        $ref->setAccessible(true);
         $ref->setValue($this->browser, $transaction);
 
         /**