Fix bug: samplers not correctly populate

tidal · tidal · commit b232e4d04621 · 2021-10-27T09:26:06.000+02:00
diff --git a/instrumentation/symfony/OtelSdkBundle/DependencyInjection/OtelSdkExtension.php b/instrumentation/symfony/OtelSdkBundle/DependencyInjection/OtelSdkExtension.php
@@ -145,6 +145,9 @@ private function configureTraceSamplers(): void
 
         $this->getDefinitionByClass(Samplers::PARENT_BASED)
             ->setArguments($arguments);
+
+        $this->getDefinitionByClass(Trace\TracerProvider::class)
+            ->setArgument(1, self::createReferenceFromClass(Samplers::PARENT_BASED));
     }
 
     private function configureSpanLimits(): void

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,9 @@ private function configureTraceSamplers(): void`
`145`	`145`
`146`	`146`	`$this->getDefinitionByClass(Samplers::PARENT_BASED)`
`147`	`147`	`->setArguments($arguments);`
	`148`	`+`
	`149`	`+ $this->getDefinitionByClass(Trace\TracerProvider::class)`
	`150`	`+ ->setArgument(1, self::createReferenceFromClass(Samplers::PARENT_BASED));`
`148`	`151`	`}`
`149`	`152`
`150`	`153`	`private function configureSpanLimits(): void`