add test cases

Author: mitchierichie

src/Aws/tests/Integration/AwsSdkInstrumentationTest.php

@@ -5,14 +5,20 @@
 namespace OpenTelemetry\Tests\Aws\Integration;
 
 use Aws\AwsClientInterface;
+use Aws\CommandInterface;
 use Aws\EventBridge\EventBridgeClient;
+use Aws\Kms\Exception\KmsException;
 use Aws\S3\S3Client;
 use Aws\Sqs\SqsClient;
+use GuzzleHttp\Promise;
+use OpenTelemetry\API\Trace\StatusCode;
 use OpenTelemetry\Aws\AwsSdkInstrumentation;
 use OpenTelemetry\Aws\Xray\Propagator;
 use OpenTelemetry\SDK\Trace\ReadWriteSpanInterface;
 use OpenTelemetry\SDK\Trace\TracerProvider;
 use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\RequestInterface;
+use stdClass;
 
 class AwsSdkInstrumentationTest extends TestCase
 {
@@ -213,4 +219,91 @@ public function testPreventsRepeatedInstrumentationOfSameClient()
             );
         }
     }
+
+    public function testFailedOperationRecordsSpan()
+    {
+        $kmsClient = $this->getTestClient('KMS', ['region' => 'eu-west-1']);
+
+        $spanProcessor = new CollectingSpanProcessor();
+        $this->awsSdkInstrumentation->setTracerProvider(new TracerProvider([$spanProcessor]));
+        $this->awsSdkInstrumentation->setPropagator(new Propagator());
+        $this->awsSdkInstrumentation->instrumentClients([$kmsClient]);
+        $this->awsSdkInstrumentation->init();
+        $this->awsSdkInstrumentation->activate();
+
+        try {
+            $kmsClient->decrypt(['CiphertextBlob' => random_bytes(16)]);
+        } catch (KmsException) {}
+
+        $collectedSpans = $spanProcessor->getCollectedSpans();
+        $this->assertCount(1, $collectedSpans);
+
+        $span = array_shift($collectedSpans);
+
+        /** @var ReadWriteSpanInterface $span */
+        $this->assertTrue($span->hasEnded());
+        $this->assertSame(StatusCode::STATUS_ERROR, $span->toSpanData()->getStatus()->getCode());
+    }
+
+    public function testRejectsSafelyWithNonStringableObject()
+    {
+        $kmsClient = $this->getTestClient('KMS', ['region' => 'eu-west-1']);
+
+        $spanProcessor = new CollectingSpanProcessor();
+        $this->awsSdkInstrumentation->setTracerProvider(new TracerProvider([$spanProcessor]));
+        $this->awsSdkInstrumentation->setPropagator(new Propagator());
+        $this->awsSdkInstrumentation->instrumentClients([$kmsClient]);
+        $this->awsSdkInstrumentation->init();
+        $this->awsSdkInstrumentation->activate();
+
+        $kmsClient->getHandlerList()->appendSign(function (callable $handler) {
+            return function () use ($handler) {
+                return Promise\Create::rejectionFor(new stdClass());
+            };
+        });
+
+        try {
+            $kmsClient->decrypt(['CiphertextBlob' => random_bytes(16)]);
+        } catch (Promise\RejectionException) {}
+
+        $collectedSpans = $spanProcessor->getCollectedSpans();
+        $this->assertCount(1, $collectedSpans);
+
+        $span = array_shift($collectedSpans);
+
+        /** @var ReadWriteSpanInterface $span */
+        $this->assertTrue($span->hasEnded());
+        $this->assertSame(StatusCode::STATUS_ERROR, $span->toSpanData()->getStatus()->getCode());
+    }
+
+    public function testRejectsSafelyWithString()
+    {
+        $kmsClient = $this->getTestClient('KMS', ['region' => 'eu-west-1']);
+
+        $spanProcessor = new CollectingSpanProcessor();
+        $this->awsSdkInstrumentation->setTracerProvider(new TracerProvider([$spanProcessor]));
+        $this->awsSdkInstrumentation->setPropagator(new Propagator());
+        $this->awsSdkInstrumentation->instrumentClients([$kmsClient]);
+        $this->awsSdkInstrumentation->init();
+        $this->awsSdkInstrumentation->activate();
+
+        $kmsClient->getHandlerList()->appendSign(function (callable $handler) {
+            return function () use ($handler) {
+                return Promise\Create::rejectionFor('failed');
+            };
+        });
+
+        try {
+            $kmsClient->decrypt(['CiphertextBlob' => random_bytes(16)]);
+        } catch (Promise\RejectionException) {}
+
+        $collectedSpans = $spanProcessor->getCollectedSpans();
+        $this->assertCount(1, $collectedSpans);
+
+        $span = array_shift($collectedSpans);
+
+        /** @var ReadWriteSpanInterface $span */
+        $this->assertTrue($span->hasEnded());
+        $this->assertSame(StatusCode::STATUS_ERROR, $span->toSpanData()->getStatus()->getCode());
+    }
 }