Skip to content

Commit fbb65ce

Browse files
committed
document mongo todos
1 parent 483e0bf commit fbb65ce

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/Instrumentation/MongoDB/src/MongoDBInstrumentationSubscriber.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ private static function endSpan(?Throwable $exception = null): void
136136
$span->end();
137137
}
138138

139+
/**
140+
* @todo In a load-balanced scenario, the hello response may be empty.
141+
*/
139142
public function serverChanged(ServerChangedEvent $event): void
140143
{
141144
$host = $event->getHost();

src/Instrumentation/MongoDB/src/MongoDBTraceAttributes.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
namespace OpenTelemetry\Contrib\Instrumentation\MongoDB;
66

7+
/**
8+
* @todo These attributes are not part of the specification and should be removed before this package goes stable,
9+
* unless they are on the way to being added to the specification. See https://github.com/open-telemetry/opentelemetry-specification/blob/v1.40.0/specification/telemetry-stability.md
10+
*/
711
interface MongoDBTraceAttributes
812
{
913
public const DB_MONGODB_MASTER = 'db.mongodb.master';

0 commit comments

Comments
 (0)