Skip to content

Conversation

@090809
Copy link
Contributor

@090809 090809 commented Feb 15, 2025

@090809 090809 requested a review from a team as a code owner February 15, 2025 03:22
@welcome
Copy link

welcome bot commented Feb 15, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@brettmc
Copy link
Contributor

brettmc commented Feb 16, 2025

Change looks sensible tome. Is there a test that could be added/updated to cover this?

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (2d17302) to head (be13ae0).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #331      +/-   ##
============================================
+ Coverage     80.67%   80.70%   +0.03%     
+ Complexity     1295     1294       -1     
============================================
  Files           114      114              
  Lines          5486     5495       +9     
============================================
+ Hits           4426     4435       +9     
  Misses         1060     1060              
Flag Coverage Δ
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.66% <ø> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 87.73% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 62.68% <100.00%> (+0.51%) ⬆️
Instrumentation/MongoDB 74.03% <ø> (ø)
Instrumentation/MySqli 96.09% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.89% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/Laravel/src/Watchers/RedisCommand/Serializer.php 95.45% <100.00%> (+3.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d17302...be13ae0. Read the comment docs.

@090809
Copy link
Contributor Author

090809 commented Feb 17, 2025

Hi @brettmc
I added simple test for serialization variables.
I think that there must be other test for Watcher, but it need's some rewrites in original TestCase, and I worry, it can affect next 1.1 release of Laravel Auto Instrumentation

@ChrisLightfootWild
Copy link
Contributor

Hi @brettmc I added simple test for serialization variables. I think that there must be other test for Watcher, but it need's some rewrites in original TestCase, and I worry, it can affect next 1.1 release of Laravel Auto Instrumentation

Thanks for bearing that in mind! I will sort any merge conflicts later 💪

@brettmc brettmc merged commit 65de07e into open-telemetry:main Feb 25, 2025
104 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants