Skip to content

fix Pre Hook Exception in case _controller is not stringable #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2025
Merged

fix Pre Hook Exception in case _controller is not stringable #366

merged 2 commits into from
Jul 9, 2025
+55 −1

Conversation

@trigrab
Copy link
Contributor

@trigrab trigrab commented May 10, 2025 •
edited
Loading

@trigrab trigrab requested a review from a team as a code owner May 10, 2025 11:59
@welcome
Copy link

welcome bot commented May 10, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 10, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

Nevay
Nevay reviewed May 10, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.46%. Comparing base (e6272aa) to head (a8c7f8e).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #366   +/-   ##
=========================================
  Coverage     83.45%   83.46%           
- Complexity     1957     1958    +1     
=========================================
  Files           143      143           
  Lines          8190     8193    +3     
=========================================
+ Hits           6835     6838    +3     
  Misses         1355     1355
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.55% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 91.98% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 69.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <100.00%> (+0.14%) ⬆️
Instrumentation/Yii 77.50% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rumentation/Symfony/src/SymfonyInstrumentation.php 80.18% <100.00%> (+0.55%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6272aa...a8c7f8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trigrab trigrab force-pushed the fix-pre-hook-exception branch 2 times, most recently from d9eeb36 to 6e1f5d6 Compare June 26, 2025 12:06
@trigrab trigrab force-pushed the fix-pre-hook-exception branch from 6e1f5d6 to dfb2582 Compare June 27, 2025 07:00
@trigrab trigrab force-pushed the fix-pre-hook-exception branch from dfb2582 to a8c7f8e Compare June 28, 2025 00:10
@brettmc brettmc merged commit 1c61b16 into open-telemetry:main Jul 9, 2025
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

+2 more reviewers

@umulmrum umulmrum umulmrum left review comments

@Nevay Nevay Nevay left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-contrib] Pre hook exception Symfony\Component\HttpKernel\Controller\ErrorController could not be converted to string

4 participants

@trigrab @brettmc @umulmrum @Nevay