Slim: adding stable http server metrics #396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
============================================
+ Coverage 82.82% 83.48% +0.65%
- Complexity 1948 1967 +19
============================================
Files 142 144 +2
Lines 8142 8215 +73
============================================
+ Hits 6744 6858 +114
+ Misses 1398 1357 -41 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Open
|
Back to draft. Possibly it can be improved in future with the tracking mechanism proposed for PDO metrics... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just implemented the one stable metric along with recommended attributes here. The metrics generation uses PSR interfaces, so I think we can eventually split it out into its own package and it should work with other frameworks.
Reference: https://opentelemetry.io/docs/specs/semconv/http/http-metrics/
edit: I've been thinking over how to add
http.routeusing this mechanism, and it's really not possible without dodgy and/or ugly hacks. That's got me thinking, what if this was instead implemented as a Span Processor or class similar to this one that's called from our existingSpanProcessorInterface::onEnd(ReadableSpanInterface $span)- at this point we would have access to all the attributes we want, plus request time. It would also have the bonus of working for all http server spans, they just need to be using SemConv correctly to identify themselves (which they should be) - eg kind=server && http.request.method is setAlternative implementation: open-telemetry/opentelemetry-php#1651