Skip to content

Commit f776242

Browse files
authored
build windows x64 threadsafe (#147)
1 parent cff5b65 commit f776242

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,29 +73,30 @@ jobs:
7373
pear package
7474
cp opentelemetry-*.tgz binaries/
7575
- name: Upload artifacts
76-
uses: actions/upload-artifact@v3
76+
uses: actions/upload-artifact@v4
7777
with:
7878
name: opentelemetry-pecl
7979
path: ext/binaries/*.tgz
8080
if-no-files-found: error
8181

8282
windows:
83-
runs-on: windows-2019
83+
runs-on: windows-2022
8484
continue-on-error: false
8585
strategy:
8686
fail-fast: false
8787
matrix:
8888
php: ['8.0', '8.1', '8.2', '8.3']
89+
ts: ['ts', 'nts']
8990
steps:
9091
- name: Checkout
9192
uses: actions/checkout@v4
92-
- name: Install PHP ${{ matrix.php }}
93+
- name: Install PHP ${{ matrix.php }}-${{ matrix.ts }}
9394
id: setup-php-sdk
94-
uses: php/setup-php-sdk@v0.8
95+
uses: php/setup-php-sdk@v0.9
9596
with:
9697
version: ${{ matrix.php }}
9798
arch: x64
98-
ts: nts
99+
ts: ${{ matrix.ts }}
99100
- name: Install dependencies
100101
uses: ilammy/msvc-dev-cmd@v1
101102
with:
@@ -112,15 +113,16 @@ jobs:
112113
run: nmake test TESTS=--show-diff
113114
- name: Copy binaries
114115
env:
115-
BUILD_NAME: "opentelemetry-${{matrix.php}}-windows-x64-nts}}"
116+
BUILD_NAME: "opentelemetry-${{matrix.php}}-windows-x64-${{matrix.ts}}"
116117
run: |
117118
md binaries\$BUILD_NAME
118-
copy x64\Release\php_opentelemetry.dll binaries\$BUILD_NAME\php_opentelemetry.dll
119+
$file = Get-ChildItem -Path x64 -Recurse -Filter php_opentelemetry.dll
120+
Copy-Item -Path $file.FullName -Destination binaries\$BUILD_NAME
119121
- name: Upload artifacts
120-
uses: actions/upload-artifact@v3
122+
uses: actions/upload-artifact@v4
121123
with:
122-
name: opentelemetry-${{matrix.php}}-windows-x64-nts
123-
path: ext\x64\Release\php_opentelemetry.dll
124+
name: opentelemetry-${{matrix.php}}-windows-x64-${{matrix.ts}}
125+
path: ext\x64\**\php_opentelemetry.dll
124126
if-no-files-found: error
125127

126128
release-if-tag:

0 commit comments

Comments
 (0)