[Symfony auto-instrumentation] Messenger instrumentation should use SpanKind::KIND_PRODUCER, SpanKind::KIND_CONSUMER

[dkarlovi]

Steps to reproduce

Enable Symfony auto-instrumentation with default setup.

What is the expected behavior?

Spans when creating the message should be marked with SpanKind::KIND_PRODUCER.

Spans when handling the message should be marked with SpanKind::KIND_CONSUMER.

https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#span-kind

What is the actual behavior?

Everything is marked KIND_INTERNAL and it seems the consumer is currently not instrumented at all (I might be wrong here, please feel free to correct me).

Additionally, it seems to me the names of the spans are also not correct, as shown in the table in the spec linked above?

[AA2512]

@agoallikmaa @brettmc
Can you please assign this to me

[RichardChukwu]

Hello @AA2512 please I'd like to know if this is still being worked please? @brettmc for possible assigning

Thank you

[brettmc]

Hello and welcome, @RichardChukwu
Please feel free to submit to work on this and submit a PR.

[RichardChukwu]

Got it, I'll do just that. Thank you @brettmc

[chiomalovet]

Hi @brettmc can i take this up

[dkarlovi]

@chiomalovet it was just assigned to @RichardChukwu, unless he changed his mind, he should get dibs for a while to give it a shot.

[chiomalovet]

On Tue, 8 Oct 2024 at 2:04 PM, Dalibor Karlović ***@***.***> wrote: @chiomalovet <https://github.com/chiomalovet> it was just assigned to @RichardChukwu <https://github.com/RichardChukwu>, unless he changed his mind, he should get dibs for a while to give it a shot. — Reply to this email directly, view it on GitHub <#1314 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2JQPTMNSYLGUBWTUON24X3Z2PJ5TAVCNFSM6AAAAABH7T4FAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZG44TCMZSHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Alright no problem Let me look for another one to work on

[dkarlovi]

Let me look for another one to work on

Great, there's not a shortage of work on the project(s)! 😄

[RichardChukwu]

Hello @dkarlovi please can you specify the exact folder location for this. I can't seem to figure out here symfony auto-instrumentation is in the repo inorder to apply a fix

[dkarlovi]

@RichardChukwu I know what you mean, I have the same issue navigating these OTEL repos, it's very confusing if you're not here day to day, I was about to suggest the contrib repo gets merged into this repo since the packages are now released from the split repos anyway. WDYT @bobstrecansky @brettmc?

To answer your question, it's here I believe:
https://github.com/open-telemetry/opentelemetry-php-contrib/tree/main/src/Instrumentation/Symfony