Skip to content

implement span suppression #1579

@brettmc

Description

@brettmc

Is your feature request related to a problem?
When multiple auto-instrumentation packages are installed, we can see nested/redundant extra CLIENT spans. Ideally, and according to spec, there should only be one CLIENT span per operation, and the child of a CLIENT span should be a remote SERVER span.

Some discussion in open-telemetry/opentelemetry-php-contrib#361 (comment)

Describe the solution you'd like
Java has SpanSuppressionStrategy to achieve this, and that might be a good way to go.

I think that ultimately we would want an auto-instrumentation to not create a CLIENT span if one has already been created (however, it should still perform other logic such as injecting trace propagation headers).

Also consider whether we can use this to resolve #1534

A PoC has been developed in #1599 so if we go ahead with that, I think the steps should be:

Metadata

Metadata

Assignees

No one assigned

    Labels

    pinnedWill not be removed by stalebot

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions