Remove event logger #1480
Remove event logger #1480
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1480 +/- ##
============================================
+ Coverage 68.44% 68.50% +0.05%
+ Complexity 2885 2866 -19
============================================
Files 428 422 -6
Lines 8775 8708 -67
============================================
- Hits 6006 5965 -41
+ Misses 2769 2743 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
was just removed from spec, replacement is not defined yet.
brettmc
changed the title
|
Worth mentioning and discussion, is that in this PR I've removed some methods etc related to event logger. The spec really wants us to not ever make breaking changes to the API. However:
The event logger was |
4 participants
Event Logger has been removed from spec, in favour of Logger.EmitEvent. We have deprecated EventLogger in
main, this removes it from2.xand addsEmitEventas its replacement.